Fwd: [ooni-probe] [PATCH] Fix typo in the meek tests - ooni-dev

15 Oct 2015


      Hello,
This mail doesn't have seemed to end up on the tor-dev lists as intended, but
— in either case — this list is probably a better place for it.  Since Pabs'
patch is a one-character change which should fix a SyntaxError in one of the
nettests, I've gone ahead and applied it to the Github ooni-probe master
branch and pushed there.  (The git-rw.tpo repo master branch is out of sync
with the GH one, FWIW.  I didn't understand why this would be the case, but I
assumed that you all have some organisation reasons for doing so and so I
didn't update the git-rw.tpo repo.)
I hope this was okay to do.
Cheers!
-- 
 ♥Ⓐ isis agora lovecruft
_________________________________________________________
OpenPGP: 4096R/0A6A58A14B5946ABDE18E207A3ADB67A2CDB8B35
Current Keys: https://blog.patternsinthevoid.net/isis.txt


----- Forwarded message from Paul Wise pabs3@bonedaddy.net -----

> Return-Path: pabs3@bonedaddy.net
> Delivered-To: isis+torproject@patternsinthevoid.net
> Received: from patternsinthevoid.net
> 	by greyarea.patternsinthevoid.net (Dovecot) with LMTP id L+9dKDFzH1bpQAAABwIL0w
> 	for isis+torproject@patternsinthevoid.net; Thu, 15 Oct 2015 09:34:41 +0000
> Received: from localhost (localhost [127.0.0.1])
> 	by patternsinthevoid.net (Postfix) with ESMTP id 9E3153D4E11
> 	for isis+torproject@patternsinthevoid.net; Thu, 15 Oct 2015 09:34:41 +0000 (UTC)
> X-Virus-Scanned: Debian amavisd-new at patternsinthevoid.net
> Received: from patternsinthevoid.net ([127.0.0.1])
> 	by localhost (greyarea.patternsinthevoid.net [127.0.0.1]) (amavisd-new, port 10024)
> 	with ESMTP id fhGf8GwobJgy
> 	for isis+torproject@patternsinthevoid.net;
> 	Thu, 15 Oct 2015 09:34:15 +0000 (UTC)
> Received: from eugeni.torproject.org (eugeni.torproject.org [38.229.72.13])
> 	by patternsinthevoid.net (Postfix) with ESMTPS id 710B73D4E10
> 	for isis+torproject@patternsinthevoid.net; Thu, 15 Oct 2015 09:34:14 +0000 (UTC)
> X-Virus-Scanned: Debian amavisd-new at
> Received: from eugeni.torproject.org ([127.0.0.1])
> 	by localhost (eugeni.torproject.org [127.0.0.1]) (amavisd-new, port 10024)
> 	with ESMTP id m1eKAgkSKpP1; Thu, 15 Oct 2015 09:33:42 +0000 (UTC)
> Received: from master.debian.org (master.debian.org [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001])
> 	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
> 	(Client did not present a certificate)
> 	by eugeni.torproject.org (Postfix) with ESMTPS id 5B5B238753;
> 	Thu, 15 Oct 2015 09:33:38 +0000 (UTC)
> From: Paul Wise pabs3@bonedaddy.net
> To: isis@torproject.org, tor-dev@lists.torproject.org
> Cc: Paul Wise pabs3@bonedaddy.net
> Subject: [ooni-probe] [PATCH] Fix typo in the meek tests
> Date: Thu, 15 Oct 2015 17:31:09 +0800
> Message-Id: 1444901469-19326-1-git-send-email-pabs3@bonedaddy.net
> X-Mailer: git-send-email 2.6.1
> 
> ---
>  ooni/nettests/blocking/meek_fronted_requests.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ooni/nettests/blocking/meek_fronted_requests.py b/ooni/nettests/blocking/meek_fronted_requests.py
> index 3795008..2ccd72e 100644
> --- a/ooni/nettests/blocking/meek_fronted_requests.py
> +++ b/ooni/nettests/blocking/meek_fronted_requests.py
> @@ -48,7 +48,7 @@ class meekTest(httpt.HTTPTest):
>          """
>  
>          if self.input:
> -           if (isinstance(self.input, tuple) or isinstace(self.input, list)):
> +           if (isinstance(self.input, tuple) or isinstance(self.input, list)):
>                 self.domainName, self.header = self.input
>             else:
>                 self.domainName, self.header = self.input.split(':')
> -- 
> 2.6.1
> 

----- End forwarded message -----