tbb-commits June 2023

tbb-commits@lists.torproject.org

1 participants
138 discussions

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 05 Jun '23

05 Jun '23

Pier Angelo Vendrame pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: f8d0eb2d by Pier Angelo Vendrame at 2023-06-05T18:52:53+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 40552: Improve the description of the modal to provide a bridge manually. - - - - - fc0557ed by Pier Angelo Vendrame at 2023-06-05T18:52:54+02:00 fixup! Add TorStrings module for localization Bug 40552: New texts for the add a bridge manually modal - - - - - 5 changed files: - browser/components/torpreferences/content/provideBridgeDialog.jsm - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css - browser/modules/TorStrings.jsm - toolkit/torbutton/chrome/locale/en-US/settings.properties Changes: ===================================== browser/components/torpreferences/content/provideBridgeDialog.jsm ===================================== @@ -17,7 +17,7 @@ class ProvideBridgeDialog { static get selectors() { return { - header: "#torPreferences-provideBridge-header", + description: "#torPreferences-provideBridge-description", textarea: "#torPreferences-provideBridge-textarea", }; } @@ -25,11 +25,25 @@ class ProvideBridgeDialog { _populateXUL(window, aDialog) { const selectors = ProvideBridgeDialog.selectors; + const openHelp = () => { + window.top.openTrustedLinkIn( + TorStrings.settings.learnMoreBridgesURL, + "tab" + ); + }; + this._dialog = aDialog; const dialogWin = this._dialog.parentElement; - dialogWin.setAttribute("title", TorStrings.settings.provideBridgeTitle); - this._dialog.querySelector(selectors.header).textContent = - TorStrings.settings.provideBridgeHeader; + dialogWin.setAttribute("title", TorStrings.settings.provideBridgeTitleAdd); + const learnMore = window.document.createXULElement("label"); + learnMore.className = "learnMore text-link"; + learnMore.setAttribute("is", "text-link"); + learnMore.setAttribute("value", TorStrings.settings.learnMore); + learnMore.addEventListener("click", openHelp); + const descr = this._dialog.querySelector(selectors.description); + descr.textContent = ""; + const pieces = TorStrings.settings.provideBridgeDescription.split("%S"); + descr.append(pieces[0], learnMore, pieces[1] || ""); this._textarea = this._dialog.querySelector(selectors.textarea); this._textarea.setAttribute( "placeholder", @@ -42,12 +56,7 @@ class ProvideBridgeDialog { this._dialog.addEventListener("dialogaccept", e => { this.onSubmit(this._textarea.value); }); - this._dialog.addEventListener("dialoghelp", e => { - window.top.openTrustedLinkIn( - TorStrings.settings.learnMoreBridgesURL, - "tab" - ); - }); + this._dialog.addEventListener("dialoghelp", openHelp); } init(window, aDialog) { ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -8,7 +8,9 @@ xmlns:html="http://www.w3.org/1999/xhtml"> <dialog id="torPreferences-provideBridge-dialog" buttons="help,accept,cancel"> - <html:h3 id="torPreferences-provideBridge-header"></html:h3> + <description> + <html:div id="torPreferences-provideBridge-description"><br/></html:div> + </description> <html:textarea id="torPreferences-provideBridge-textarea" multiline="true" rows="3"/> <script type="application/javascript"><![CDATA[ "use strict"; ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -586,8 +586,8 @@ groupbox#torPreferences-bridges-group textarea { } /* Provide bridge dialog */ -#torPreferences-provideBridge-header { - margin-top: 8px; +#torPreferences-provideBridge-textarea { + margin-top: 16px; } /* Connection settings dialog */ ===================================== browser/modules/TorStrings.jsm ===================================== @@ -161,8 +161,9 @@ const Loader = { captchaTextboxPlaceholder: "Enter the characters from the image", incorrectCaptcha: "The solution is not correct. Please try again.", // Provide bridge dialog - provideBridgeTitle: "Provide Bridge", - provideBridgeHeader: "Enter bridge information from a trusted source", + provideBridgeTitleAdd: "Add a Bridge Manually", + provideBridgeDescription: + "Add a bridge provided by a trusted organization or someone you know. If you don’t have a bridge, you can request one from the Tor Project. %S", provideBridgePlaceholder: "type address:port (one per line)", // Connection settings dialog connectionSettingsDialogTitle: "Connection Settings", ===================================== toolkit/torbutton/chrome/locale/en-US/settings.properties ===================================== @@ -104,8 +104,9 @@ settings.captchaTextboxPlaceholder=Enter the characters from the image settings.incorrectCaptcha=The solution is not correct. Please try again. # Provide bridge dialog -settings.provideBridgeTitle=Provide Bridge -settings.provideBridgeHeader=Enter bridge information from a trusted source +settings.provideBridgeTitleAdd=Add a Bridge Manually +# Translation note: %S is a Learn more link. +settings.provideBridgeDescription=Add a bridge provided by a trusted organization or someone you know. If you don’t have a bridge, you can request one from the Tor Project. %S settings.provideBridgePlaceholder=type address:port (one per line) # Connection settings dialog @@ -129,3 +130,7 @@ settings.allowedPortsPlaceholder=Comma-seperated values # Log dialog settings.torLogDialogTitle=Tor Logs settings.copyLog=Copy Tor Log to Clipboard + +# Legacy strings - remove once 12.0 has gone EOL +settings.provideBridgeTitle=Provide Bridge +settings.provideBridgeHeader=Enter bridge information from a trusted source View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/014f64… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/014f64… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] fixup! Bug 40597: Implement TorSettings module
by Pier Angelo Vendrame (＠pierov) 05 Jun '23

05 Jun '23

Pier Angelo Vendrame pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 014f6414 by Pier Angelo Vendrame at 2023-06-01T22:03:04+02:00 fixup! Bug 40597: Implement TorSettings module Bug 41801: Fix handleProcessReady in TorSettings.init - - - - - 1 changed file: - browser/modules/TorSettings.jsm Changes: ===================================== browser/modules/TorSettings.jsm ===================================== @@ -299,7 +299,7 @@ const TorSettings = (() => { Services.obs.addObserver(this, TorTopics.ProcessIsReady); if (TorMonitorService.isRunning) { - handleProcessReady(); + this.handleProcessReady(); } } }, @@ -308,22 +308,22 @@ const TorSettings = (() => { async observe(subject, topic, data) { console.log(`TorSettings: Observed ${topic}`); - // once the tor daemon is ready, we need to apply our settings - const handleProcessReady = async () => { - // push down settings to tor - await this.applySettings(); - console.log("TorSettings: Ready"); - Services.obs.notifyObservers(null, TorSettingsTopics.Ready); - }; - switch (topic) { case TorTopics.ProcessIsReady: Services.obs.removeObserver(this, TorTopics.ProcessIsReady); - await handleProcessReady(); + await this.handleProcessReady(); break; } }, + // once the tor daemon is ready, we need to apply our settings + async handleProcessReady() { + // push down settings to tor + await this.applySettings(); + console.log("TorSettings: Ready"); + Services.obs.notifyObservers(null, TorSettingsTopics.Ready); + }, + // load our settings from prefs loadFromPrefs() { console.log("TorSettings: loadFromPrefs()"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/014f641… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/014f641… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Revert "Bug 40869: Temporarily set obfs4 to a fixed commit"
by boklm (＠boklm) 05 Jun '23

05 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 94050678 by Nicolas Vigier at 2023-06-05T10:29:21+02:00 Revert "Bug 40869: Temporarily set obfs4 to a fixed commit" This reverts commit 40298e792e7cd498e8534d65cb1220ff4e43e325. - - - - - 723c63a0 by Nicolas Vigier at 2023-06-05T17:24:57+02:00 Bug 40869: obfs4 is renamed to lyrebird - - - - - 11 changed files: - Makefile - projects/browser/Bundle-Data/Docs-TBB/Licenses/PluggableTransports/LICENSE - projects/browser/Bundle-Data/PTConfigs/linux/torrc-defaults-appendix - projects/browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix - projects/browser/Bundle-Data/PTConfigs/windows/torrc-defaults-appendix - projects/obfs4/build → projects/lyrebird/build - projects/obfs4/config → projects/lyrebird/config - projects/tor-expert-bundle/build - projects/tor-expert-bundle/config - projects/tor-expert-bundle/pt_config.json - projects/tor-onion-proxy-library/build Changes: ===================================== Makefile ===================================== @@ -601,11 +601,11 @@ go_vendor-conjure-alpha: submodule-update go_vendor-webtunnel-alpha: submodule-update $(rbm) build webtunnel --step go_vendor --target alpha --target torbrowser-linux-x86_64 -go_vendor-obfs4-alpha: submodule-update - $(rbm) build obfs4 --step go_vendor --target alpha --target torbrowser-linux-x86_64 +go_vendor-lyrebird-alpha: submodule-update + $(rbm) build lyrebird --step go_vendor --target alpha --target torbrowser-linux-x86_64 -go_vendor-obfs4-nightly: submodule-update - $(rbm) build obfs4 --step go_vendor --target nightly --target torbrowser-linux-x86_64 +go_vendor-lyrebird-nightly: submodule-update + $(rbm) build lyrebird --step go_vendor --target nightly --target torbrowser-linux-x86_64 ################## ===================================== projects/browser/Bundle-Data/Docs-TBB/Licenses/PluggableTransports/LICENSE ===================================== @@ -145,10 +145,10 @@ warranty. See LICENSE.CC0. =============================================================================== -obfs4 +lyrebird -Copyright (c) 2014, Yawning Angel <yawning at torproject dot org> -All rights reserved. +Copyright (c) 2023, The Tor Project +Copyright (c) 2014-2023, Yawning Angel <yawning at schwanenlied dot me> Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: ===================================== projects/browser/Bundle-Data/PTConfigs/linux/torrc-defaults-appendix ===================================== @@ -1,5 +1,5 @@ -## obfs4proxy configuration -ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec ./TorBrowser/Tor/PluggableTransports/obfs4proxy +## lyrebird configuration +ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec ./TorBrowser/Tor/PluggableTransports/lyrebird ## snowflake configuration ClientTransportPlugin snowflake exec ./TorBrowser/Tor/PluggableTransports/snowflake-client ===================================== projects/browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix ===================================== @@ -1,5 +1,5 @@ -## obfs4proxy configuration -ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec PluggableTransports/obfs4proxy +## lyrebird configuration +ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec PluggableTransports/lyrebird ## snowflake configuration ClientTransportPlugin snowflake exec PluggableTransports/snowflake-client ===================================== projects/browser/Bundle-Data/PTConfigs/windows/torrc-defaults-appendix ===================================== @@ -1,5 +1,5 @@ -## obfs4proxy configuration -ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec TorBrowser\Tor\PluggableTransports\obfs4proxy.exe +## lyrebird configuration +ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec TorBrowser\Tor\PluggableTransports\lyrebird.exe ## snowflake configuration ClientTransportPlugin snowflake exec TorBrowser\Tor\PluggableTransports\snowflake-client.exe ===================================== projects/obfs4/build → projects/lyrebird/build ===================================== @@ -17,9 +17,8 @@ cd /var/tmp/build/[% project %]-[% c('version') %] tar -xf $rootdir/[% c('input_files_by_name/go_vendor') %] -cd obfs4proxy -go build -mod=vendor -ldflags '-s' -cp -a obfs4proxy[% IF c("var/windows") %].exe[% END %] $distdir +go build -mod=vendor -ldflags '-s' ./cmd/lyrebird +cp -a lyrebird[% IF c("var/windows") %].exe[% END %] $distdir cd $distdir [% c('tar', { ===================================== projects/obfs4/config → projects/lyrebird/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 -version: 0.0.14-tor2 -git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/obfs… -git_hash: 'obfs4proxy-[% c("version") %]' +version: 0.1.0 +git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyre… +git_hash: 'lyrebird-[% c("version") %]' tag_gpg_id: 1 gpg_keyring: anti-censorship.gpg @@ -9,16 +9,15 @@ container: use_container: 1 var: - go_vendor_sha256sum: 5d2d82d00afc5fe044ee6df718ffe066b7d9e5446944c0ee0870e060e4e6bcc8 + go_vendor_sha256sum: d95d1fa8ce3904b76395b20ef169e8ef2b039fa485764b74739bb6290631537d targets: nightly: - # Set fixed commit until tor-browser-build#40869 is done - git_hash: a34b4cad6d3c20f4abdec357e01101751a583f88 + git_hash: main version: '[% c("abbrev") %]' tag_gpg_id: 0 var: - go_vendor_sha256sum: 8b7e04a43bfbcdc829ea5093d8ee0a50eddefad543acd201b25424b33a7f882b + go_vendor_sha256sum: d95d1fa8ce3904b76395b20ef169e8ef2b039fa485764b74739bb6290631537d steps: build: @@ -32,7 +31,7 @@ steps: enable: '[% c("var/android") %]' - name: go_vendor pkg_type: go_vendor - project: obfs4 + project: lyrebird norec: sha256sum: '[% c("var/go_vendor_sha256sum") %]' target_replace: ===================================== projects/tor-expert-bundle/build ===================================== @@ -9,7 +9,7 @@ tar -xkf $rootdir/[% c('input_files_by_name/tor') %] cd tor mkdir pluggable_transports && cd pluggable_transports -tar -xkf $rootdir/[% c('input_files_by_name/obfs4') %] +tar -xkf $rootdir/[% c('input_files_by_name/lyrebird') %] tar -xkf $rootdir/[% c('input_files_by_name/snowflake') %] tar -xkf $rootdir/[% c('input_files_by_name/webtunnel') %] tar -xkf $rootdir/[% c('input_files_by_name/conjure') %] ===================================== projects/tor-expert-bundle/config ===================================== @@ -14,8 +14,8 @@ input_files: - project: container-image - name: tor project: tor - - name: obfs4 - project: obfs4 + - name: lyrebird + project: lyrebird - name: snowflake project: snowflake - project: webtunnel ===================================== projects/tor-expert-bundle/pt_config.json ===================================== @@ -1,7 +1,7 @@ { "recommendedDefault" : "obfs4", "pluggableTransports" : { - "obfs4proxy" : "ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec ${pt_path}obfs4proxy${pt_extension}", + "lyrebird" : "ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec ${pt_path}lyrebird${pt_extension}", "snowflake" : "ClientTransportPlugin snowflake exec ${pt_path}snowflake-client${pt_extension}", "webtunnel" : "ClientTransportPlugin webtunnel exec ${pt_path}webtunnel-client${pt_extension}", "conjure" : "ClientTransportPlugin conjure exec ${pt_path}conjure-client${pt_extension} -registerURL https://registration.refraction.network/api" ===================================== projects/tor-onion-proxy-library/build ===================================== @@ -36,8 +36,8 @@ patch -p1 < $rootdir/0001-Bug-40800-Add-WebTunnel-support.patch # Overwrite the obfs4proxy binary provided by Pluto and add Snowflake [% IF arch == "armv7" -%] - cp $ptdir/obfs4proxy external/pluto/bin/armeabi-v7a/ - cp $ptdir/obfs4proxy external/pluto/bin/armeabi/ + cp $ptdir/lyrebird external/pluto/bin/armeabi-v7a/obfs4proxy + cp $ptdir/lyrebird external/pluto/bin/armeabi/obfs4proxy cp $ptdir/snowflake-client external/pluto/bin/armeabi-v7a/ cp $ptdir/snowflake-client external/pluto/bin/armeabi/ cp $ptdir/conjure-client external/pluto/bin/armeabi-v7a/ @@ -45,12 +45,12 @@ patch -p1 < $rootdir/0001-Bug-40800-Add-WebTunnel-support.patch cp $ptdir/webtunnel-client external/pluto/bin/armeabi-v7a/ cp $ptdir/webtunnel-client external/pluto/bin/armeabi/ [% ELSIF arch == "aarch64" -%] - cp $ptdir/obfs4proxy external/pluto/bin/arm64-v8a/ + cp $ptdir/lyrebird external/pluto/bin/arm64-v8a/obfs4proxy cp $ptdir/snowflake-client external/pluto/bin/arm64-v8a/ cp $ptdir/conjure-client external/pluto/bin/arm64-v8a/ cp $ptdir/webtunnel-client external/pluto/bin/arm64-v8a/ [% ELSE -%] - cp $ptdir/obfs4proxy external/pluto/bin/[% arch %]/ + cp $ptdir/lyrebird external/pluto/bin/[% arch %]/obfs4proxy cp $ptdir/snowflake-client external/pluto/bin/[% arch %]/ cp $ptdir/conjure-client external/pluto/bin/[% arch %]/ cp $ptdir/webtunnel-client external/pluto/bin/[% arch %]/ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.0-mullvad] Bug 40871: Update keyring/boklm.gpg for new subkeys
by boklm (＠boklm) 02 Jun '23

02 Jun '23

boklm pushed to branch maint-12.0-mullvad at The Tor Project / Applications / tor-browser-build Commits: 747e1261 by Nicolas Vigier at 2023-06-02T11:32:41+02:00 Bug 40871: Update keyring/boklm.gpg for new subkeys - - - - - 1 changed file: - keyring/boklm.gpg Changes: ===================================== keyring/boklm.gpg ===================================== Binary files a/keyring/boklm.gpg and b/keyring/boklm.gpg differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.0] Bug 40871: Update keyring/boklm.gpg for new subkeys
by boklm (＠boklm) 02 Jun '23

02 Jun '23

boklm pushed to branch maint-12.0 at The Tor Project / Applications / tor-browser-build Commits: 0bfd0b01 by Nicolas Vigier at 2023-06-02T11:32:02+02:00 Bug 40871: Update keyring/boklm.gpg for new subkeys - - - - - 1 changed file: - keyring/boklm.gpg Changes: ===================================== keyring/boklm.gpg ===================================== Binary files a/keyring/boklm.gpg and b/keyring/boklm.gpg differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40871: Update keyring/boklm.gpg for new subkeys
by boklm (＠boklm) 02 Jun '23

02 Jun '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 6f8b9584 by Nicolas Vigier at 2023-06-01T18:12:09+02:00 Bug 40871: Update keyring/boklm.gpg for new subkeys - - - - - 1 changed file: - keyring/boklm.gpg Changes: ===================================== keyring/boklm.gpg ===================================== Binary files a/keyring/boklm.gpg and b/keyring/boklm.gpg differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-102.12.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 01 Jun '23

01 Jun '23

Pier Angelo Vendrame pushed new branch tor-browser-102.12.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-102.12.0esr-12.5-1
by richard (＠richard) 01 Jun '23

01 Jun '23

richard pushed new branch base-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-102.12.0esr-12.5-1-build1
by richard (＠richard) 01 Jun '23

01 Jun '23

richard pushed new tag base-browser-102.12.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.12.0esr-12.5-1-build1
by richard (＠richard) 01 Jun '23

01 Jun '23

richard pushed new tag tor-browser-102.12.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

tbb-commits June 2023