Pier Angelo Vendrame pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser
Commits:
248a7e5f by Pier Angelo Vendrame at 2024-01-18T14:21:21+01:00
Bug 42374: Check for spoof English in number conversions
Some of the code that converts numbers to strings for inputs uses ICU
functions to localize numbers, but it does not check for spoof English.
Also, not all functions where consistent in the conversion, so this
commit addresses also this.
- - - - -
2 changed files:
- dom/html/input/NumericInputTypes.cpp
- intl/unicharutil/util/ICUUtils.cpp
Changes:
=====================================
dom/html/input/NumericInputTypes.cpp
=====================================
@@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!maximum.isNaN());
nsAutoString maxStr;
- char buf[32];
- DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf));
- maxStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(maximum, maxStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr);
@@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!minimum.isNaN());
nsAutoString minStr;
- char buf[32];
- DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf));
- minStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(minimum, minStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr);
=====================================
intl/unicharutil/util/ICUUtils.cpp
=====================================
@@ -49,6 +49,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) {
mCurrentFallbackIndex = 2;
// Else take the app's locale:
+ const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() &&
+ !mContent->OwnerDoc()->AllowsL10n();
+ if (spoofLocale) {
+ aBCP47LangTag.AssignLiteral("en-US");
+ return;
+ }
+
nsAutoCString appLocale;
LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag);
return;
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/248a7e5…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/248a7e5…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
839022b4 by Pier Angelo Vendrame at 2024-01-18T14:20:49+01:00
Bug 42374: Check for spoof English in number conversions
Some of the code that converts numbers to strings for inputs uses ICU
functions to localize numbers, but it does not check for spoof English.
Also, not all functions where consistent in the conversion, so this
commit addresses also this.
- - - - -
2 changed files:
- dom/html/input/NumericInputTypes.cpp
- intl/unicharutil/util/ICUUtils.cpp
Changes:
=====================================
dom/html/input/NumericInputTypes.cpp
=====================================
@@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!maximum.isNaN());
nsAutoString maxStr;
- char buf[32];
- DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf));
- maxStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(maximum, maxStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr);
@@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!minimum.isNaN());
nsAutoString minStr;
- char buf[32];
- DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf));
- minStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(minimum, minStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr);
=====================================
intl/unicharutil/util/ICUUtils.cpp
=====================================
@@ -49,6 +49,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) {
mCurrentFallbackIndex = 2;
// Else take the app's locale:
+ const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() &&
+ !mContent->OwnerDoc()->AllowsL10n();
+ if (spoofLocale) {
+ aBCP47LangTag.AssignLiteral("en-US");
+ return;
+ }
+
nsAutoCString appLocale;
LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag);
return;
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/839…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/839…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser
Commits:
a7932fac by Pier Angelo Vendrame at 2024-01-18T11:10:48+01:00
Bug 42374: Check for spoof English in number conversions
Some of the code that converts numbers to strings for inputs uses ICU
functions to localize numbers, but it does not check for spoof English.
Also, not all functions where consistent in the conversion, so this
commit addresses also this.
- - - - -
2 changed files:
- dom/html/input/NumericInputTypes.cpp
- intl/unicharutil/util/ICUUtils.cpp
Changes:
=====================================
dom/html/input/NumericInputTypes.cpp
=====================================
@@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!maximum.isNaN());
nsAutoString maxStr;
- char buf[32];
- DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf));
- maxStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(maximum, maxStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr);
@@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) {
MOZ_ASSERT(!minimum.isNaN());
nsAutoString minStr;
- char buf[32];
- DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf));
- minStr.AssignASCII(buf);
- MOZ_ASSERT(ok, "buf not big enough");
-
+ ConvertNumberToString(minimum, minStr);
return nsContentUtils::FormatMaybeLocalizedString(
aMessage, nsContentUtils::eDOM_PROPERTIES,
"FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr);
=====================================
intl/unicharutil/util/ICUUtils.cpp
=====================================
@@ -49,6 +49,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) {
mCurrentFallbackIndex = 2;
// Else take the app's locale:
+ const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() &&
+ !mContent->OwnerDoc()->AllowsL10n();
+ if (spoofLocale) {
+ aBCP47LangTag.AssignLiteral("en-US");
+ return;
+ }
+
nsAutoCString appLocale;
LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag);
return;
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7932fa…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7932fa…
You're receiving this email because of your account on gitlab.torproject.org.
richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build
Commits:
c12f1511 by Nicolas Vigier at 2024-01-18T10:33:05+00:00
Bug 41037: Set time on signing machine before starting signing
After a reboot, the time on our signing machine is incorrect. To avoid
signing a release with incorrect timestamps, we set the time on the
signing machine at the beginning of the signing process.
(cherry picked from commit de4e1feba72e8357c9f40ec3c555aa0dce5e0df2)
- - - - -
3 changed files:
- tools/signing/do-all-signing
- tools/signing/machines-setup/setup-signing-machine
- + tools/signing/machines-setup/sudoers.d/set-date
Changes:
=====================================
tools/signing/do-all-signing
=====================================
@@ -29,6 +29,11 @@ test -f "$steps_dir/linux-signer-gpg-sign.done" ||
read -sp "Enter gpg passphrase: " GPG_PASS
echo
+function set-time-on-signing-machine {
+ local current_time=$(date -u)
+ ssh "$ssh_host_linux_signer" sudo /usr/bin/date -s "'$current_time'"
+}
+
function wait-for-finished-build {
"$script_dir/wait-for-finished-build"
}
@@ -171,6 +176,7 @@ function do_step {
export SIGNING_PROJECTNAME
+do_step set-time-on-signing-machine
do_step wait-for-finished-build
do_step sync-builder-unsigned-to-local-signed
do_step sync-scripts-to-linux-signer
=====================================
tools/signing/machines-setup/setup-signing-machine
=====================================
@@ -91,6 +91,7 @@ sudoers_file sign-mar
sudoers_file sign-exe
sudoers_file sign-apk
sudoers_file sign-rcodesign
+sudoers_file set-date
authorized_keys boklm boklm-tb-release.pub boklm-yk1.pub
create_user richard signing
=====================================
tools/signing/machines-setup/sudoers.d/set-date
=====================================
@@ -0,0 +1 @@
+%signing ALL = NOPASSWD: /usr/bin/date -s *
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c…
You're receiving this email because of your account on gitlab.torproject.org.
richard pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
de4e1feb by Nicolas Vigier at 2024-01-18T09:50:25+01:00
Bug 41037: Set time on signing machine before starting signing
After a reboot, the time on our signing machine is incorrect. To avoid
signing a release with incorrect timestamps, we set the time on the
signing machine at the beginning of the signing process.
- - - - -
3 changed files:
- tools/signing/do-all-signing
- tools/signing/machines-setup/setup-signing-machine
- + tools/signing/machines-setup/sudoers.d/set-date
Changes:
=====================================
tools/signing/do-all-signing
=====================================
@@ -29,6 +29,11 @@ test -f "$steps_dir/linux-signer-gpg-sign.done" ||
read -sp "Enter gpg passphrase: " GPG_PASS
echo
+function set-time-on-signing-machine {
+ local current_time=$(date -u)
+ ssh "$ssh_host_linux_signer" sudo /usr/bin/date -s "'$current_time'"
+}
+
function wait-for-finished-build {
"$script_dir/wait-for-finished-build"
}
@@ -171,6 +176,7 @@ function do_step {
export SIGNING_PROJECTNAME
+do_step set-time-on-signing-machine
do_step wait-for-finished-build
do_step sync-builder-unsigned-to-local-signed
do_step sync-scripts-to-linux-signer
=====================================
tools/signing/machines-setup/setup-signing-machine
=====================================
@@ -91,6 +91,7 @@ sudoers_file sign-mar
sudoers_file sign-exe
sudoers_file sign-apk
sudoers_file sign-rcodesign
+sudoers_file set-date
authorized_keys boklm boklm-tb-release.pub boklm-yk1.pub
create_user richard signing
=====================================
tools/signing/machines-setup/sudoers.d/set-date
=====================================
@@ -0,0 +1 @@
+%signing ALL = NOPASSWD: /usr/bin/date -s *
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
a4286e22 by Pier Angelo Vendrame at 2024-01-15T19:41:34+01:00
MB 38: Mullvad Browser configuration
- - - - -
6323523b by Pier Angelo Vendrame at 2024-01-15T19:41:36+01:00
MB 1: Mullvad Browser branding
See also:
mullvad-browser#5: Product name and directory customization
mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding
mullvad-browser#14: Remove Default Built-in bookmarks
mullvad-browser#35: Add custom PDF icons for Windows builds
mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata
mullvad-browser#51: Update trademark string
mullvad-browser#104: Update shipped dll metadata copyright/licensing info
mullvad-browser#107: Add alpha and nightly icons
- - - - -
48351652 by Pier Angelo Vendrame at 2024-01-15T19:41:36+01:00
MB 20: Allow packaged-addons in PBM.
We install a few addons from the distribution directory, but they are
not automatically enabled for PBM mode.
This commit modifies the code that installs them to also add the PBM
permission to the known ones.
- - - - -
306635f6 by Pier Angelo Vendrame at 2024-01-15T19:41:36+01:00
MB 63: Customize some about pages for Mullvad Browser
Also:
mullvad-browser#57: Purge unneeded about: pages
- - - - -
1026aa85 by Pier Angelo Vendrame at 2024-01-15T19:41:37+01:00
MB 37: Customization for the about dialog
- - - - -
b7b874db by Henry Wilkes at 2024-01-15T19:41:37+01:00
MB 39: Add home page about:mullvad-browser
- - - - -
d5de1c25 by hackademix at 2024-01-15T19:41:37+01:00
MB 97: Remove UI cues to install new extensions.
- - - - -
5defc607 by hackademix at 2024-01-15T19:41:37+01:00
MB 47: uBlock Origin customization
- - - - -
e61d7a1b by Pier Angelo Vendrame at 2024-01-15T19:41:38+01:00
MB 21: Disable the password manager
This commit disables the about:login page and removes the "Login and
Password" section of about:preferences.
We do not do anything to the real password manager of Firefox, that is
in toolkit: it contains C++ parts that make it difficult to actually
prevent it from being built..
Finally, we modify the the function that opens about:login to report an
error in the console so that we can quickly get a backtrace to the code
that tries to use it.
- - - - -
bd64d5f0 by Pier Angelo Vendrame at 2024-01-15T19:41:38+01:00
MB 87: Disable the default browser box on Windows and Linux
Windows and Linux will be distributed only as portable apps at the
beginning, so they should not be settable as default browsers.
We will need to improve the logic once we decide to ship system-wide
installers, too.
- - - - -
ca4556bb by Pier Angelo Vendrame at 2024-01-15T19:41:38+01:00
MB 112: Updater customization for Mullvad Browser
MB 71: Set the updater base URL to Mullvad domain
- - - - -
a941cc0c by Nicolas Vigier at 2024-01-15T19:41:39+01:00
MB 79: Add Mullvad Browser MAR signing keys
- - - - -
f0e54b46 by Nicolas Vigier at 2024-01-15T19:41:50+01:00
squash! MB 79: Add Mullvad Browser MAR signing keys
MB 256: Add mullvad-browser nightly mar signing key
- - - - -
facc272b by Pier Angelo Vendrame at 2024-01-15T19:42:09+01:00
MB 34: Hide unsafe and unwanted preferences UI
about:preferences allow to override some of our defaults, that could
be fingeprintable or have some other unwanted consequences.
- - - - -
a91fca82 by Pier Angelo Vendrame at 2024-01-15T19:42:10+01:00
MB 160: Disable the cookie exceptions button
Besides disabling the "Delete on close checkbox", disable also the
"Manage Exceptions" button when always using PBM.
- - - - -
271fd4b4 by hackademix at 2024-01-15T19:42:10+01:00
MB 163: prevent uBlock Origin from being uninstalled/disabled
- - - - -
93dc7201 by Richard Pospesel at 2024-01-15T19:42:11+01:00
MB 188: Customize Gitlab Issue and Merge templates
- - - - -
d3db3643 by rui hildt at 2024-01-15T19:42:11+01:00
MB 213: Customize the search engines list
- - - - -
7c7c3bcb by hackademix at 2024-01-15T19:42:11+01:00
MB 214: Enable cross-tab identity leak protection in "quiet" mode
- - - - -
30 changed files:
- + .gitlab/issue_templates/Rebase Browser - Alpha.md
- + .gitlab/issue_templates/Rebase Browser - Stable.md
- .gitlab/merge_request_templates/default.md
- browser/app/Makefile.in
- browser/app/macbuild/Contents/Info.plist.in
- browser/app/module.ver
- browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest
- + browser/app/profile/000-mullvad-browser.js
- browser/app/profile/001-base-profile.js
- browser/base/content/aboutDialog.xhtml
- browser/base/content/appmenu-viewcache.inc.xhtml
- browser/base/content/browser-menubar.inc
- browser/base/content/browser-places.js
- browser/base/content/browser.js
- browser/base/content/default-bookmarks.html
- browser/base/content/nsContextMenu.js
- browser/base/content/overrides/app-license.html
- browser/base/content/pageinfo/pageInfo.xhtml
- browser/base/content/utilityOverlay.js
- browser/branding/branding-common.mozbuild
- + browser/branding/mb-alpha/VisualElements_150.png
- + browser/branding/mb-alpha/VisualElements_70.png
- + browser/branding/mb-alpha/configure.sh
- + browser/branding/mb-alpha/content/about-logo.png
- + browser/branding/mb-alpha/content/about-logo.svg
- + browser/branding/mb-alpha/content/about-logo(a)2x.png
- + browser/branding/mb-alpha/content/about-wordmark.svg
- + browser/branding/mb-alpha/content/about.png
- + browser/branding/mb-alpha/content/aboutDialog.css
- + browser/branding/mb-alpha/content/firefox-wordmark.svg
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cd…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cd…
You're receiving this email because of your account on gitlab.torproject.org.
asciiwolf deleted branch asciiwolf-readme-update at The Tor Project / Applications / torbrowser-launcher
--
You're receiving this email because of your account on gitlab.torproject.org.
boklm pushed to branch main at The Tor Project / Applications / torbrowser-launcher
Commits:
96594666 by asciiwolf at 2024-01-17T13:22:42+00:00
Update the Flatpak name
- - - - -
1 changed file:
- README.md
Changes:
=====================================
README.md
=====================================
@@ -27,11 +27,11 @@ Install Flatpak using these [instructions](https://flatpak.org/setup/).
Then install `torbrowser-launcher` like this:
```
-flatpak install flathub com.github.micahflee.torbrowser-launcher -y
+flatpak install flathub org.torproject.torbrowser-launcher -y
```
Run `torbrowser-launcher` either by using the GUI desktop launcher, or by running:
```
-flatpak run com.github.micahflee.torbrowser-launcher
+flatpak run org.torproject.torbrowser-launcher
```
View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/commit…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/commit…
You're receiving this email because of your account on gitlab.torproject.org.