richard pushed to branch base-browser-102.15.0esr-12.5-1 at The Tor Project / Applications / Tor Browser

Commits: 07424d5a by Pier Angelo Vendrame at 2023-08-21T16:53:59+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame

Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms.

Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - 06dc97eb by Pier Angelo Vendrame at 2023-08-21T16:54:00+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium

Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS).

Differential Revision: https://phabricator.services.mozilla.com/D146300

- - - - - 2f154f53 by Jamie Nicol at 2023-08-21T16:54:00+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond

Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - 9920955c by Pier Angelo Vendrame at 2023-08-21T16:54:00+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D157843

- - - - - 3adc1963 by Neill Miller at 2023-08-21T16:54:00+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman

nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition.

Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - 69da4acc by Gabriele Svelto at 2023-08-21T16:54:01+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium

macOS unfair locks enforce that a lock can only be released by the thread which locked it.

On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.

Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - 82b7e3be by Gabriele Svelto at 2023-08-21T16:54:01+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Depends on D148287

Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - 2f38a595 by Kershaw Chang at 2023-08-21T16:54:01+02:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - a8fc4634 by Kathy Brade at 2023-08-21T16:54:02+02:00 Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop

Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1 when the proxy bypass protection is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D161264 - - - - - 5ab9152c by Gabriele Svelto at 2023-08-21T16:54:02+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone

Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - 547a86b4 by Gabriele Svelto at 2023-08-21T16:54:02+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium

On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core.

Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - c1590a8a by Hubert Boma Manilla at 2023-08-21T16:54:02+02:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers

- Block redirects on sourceMappingUrl - Add debugger test

Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 3f3b714f by Hubert Boma Manilla at 2023-08-21T16:54:03+02:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers

.sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content.

This patch refactors to no longer use .sjs files

Differential Revision: https://phabricator.services.mozilla.com/D169739

- - - - - a0f78a7b by Jonathan Kew at 2023-08-21T16:54:03+02:00 Bug 1792157 - Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D175350 - - - - - c784f244 by Rob Wu at 2023-08-21T16:54:03+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin

Depends on D164656

Differential Revision: https://phabricator.services.mozilla.com/D166108

- - - - - 6fc92bac by Kash Shampur at 2023-08-21T16:54:04+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova

Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.

Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - 837577f6 by Pier Angelo Vendrame at 2023-08-21T16:54:04+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden

Now it displays app display name, instead of having Firefox hardcoded.

Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - 1e1216b4 by Jon Coppeard at 2023-08-21T16:54:04+02:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink

GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely.

This fixes the crash produced by the testcase.

Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - 7d437458 by Jon Coppeard at 2023-08-21T16:54:04+02:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink

To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC.

Depends on D169701

Differential Revision: https://phabricator.services.mozilla.com/D169702

- - - - - e2a8fac4 by Pier Angelo Vendrame at 2023-08-21T16:54:05+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers

This helps to prevent linkability of users in the same network.

Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 35bf888a by John Lin at 2023-08-21T16:54:05+02:00 Bug 1832832 - protect encoder accesses in Java callbacks. r=media-playback-reviewers,alwu a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D178564 - - - - - b8444de6 by Arsen Arsenović at 2023-08-21T16:54:05+02:00 Bug 1811714 - Add a few missing <cstdint> includes r=gfx-reviewers,nical

GCC 13s libstdc++ reduced its dependency on some headers like <cstdint>, so it's no longer transitively included through various headers. Include it explicitly.

See also: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

11:16.32 .../components/telemetry/pingsender/pingsender.cpp:30:7: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kConnectionTimeoutMs = 30 * 1000; 11:16.33 ^ 11:16.33 ... /components/telemetry/pingsender/pingsender.cpp:76:9: error: unknown type name 'uint32_t' 11:16.33 const uint32_t kBufferSize = 4 * 1024 - 1; 11:16.34 ^ 11:16.44 2 errors generated. (et al)

Differential Revision: https://phabricator.services.mozilla.com/D167491 - - - - - 74016648 by James Teh at 2023-08-21T16:54:06+02:00 Bug 1772170: Ensure cached Accessibles and offsets are valid before returning them in DocAccessibleParent::SelectionRanges. r=eeejay

Differential Revision: https://phabricator.services.mozilla.com/D148745 - - - - - 7b2c197e by James Teh at 2023-08-21T16:54:06+02:00 Bug 1781169: Ensure that the cached start/end containers contain characters before returning them in DocAccessibleParent::SelectionRanges. r=eeejay

In bug 1772170, I added code to ensure that the cached offsets are valid. However, this didn't account for the possibility that one of the containers contained 0 characters. In that case, offset 0 is itself invalid. If there were also no children, this might in GetChildAtOffset being called and returning null, causing a crash when retrieving selection.

Differential Revision: https://phabricator.services.mozilla.com/D154964 - - - - - 6d99bcf4 by Edgar Chen at 2023-08-21T16:59:33+02:00 Bug 1821884 - Ensure consistent state for fullscreen/pointerlock warnings; r=Gijs

Fullscreen/PointerLock warnings are initialized with hidden="true", but change to hidden="" after being shown and hidden again. I think this started happening when we began using HTML elements instead of XUL as they handle hidden attribute differently.

Differential Revision: https://phabricator.services.mozilla.com/D177790 - - - - - cd05477a by Edgar Chen at 2023-08-21T16:59:34+02:00 Bug 1821884 - Reshow initial fullscreen notification; r=Gijs

Depends on D177790

Differential Revision: https://phabricator.services.mozilla.com/D178339 - - - - - 9b388f08 by Georg Koppen at 2023-08-21T16:59:35+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"

This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.

This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.

- - - - - 27777358 by Henry Wilkes at 2023-08-21T16:59:35+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

- - - - - 1780a710 by Henry Wilkes at 2023-08-21T16:59:36+02:00 Bug 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

- - - - - 363096d5 by Pier Angelo Vendrame at 2023-08-21T16:59:36+02:00 Bug 41116: Normalize system fonts.

System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.

- - - - - 60d648bc by Marco Simonelli at 2023-08-21T16:59:37+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

- - - - - fbe06c2e by Marco Simonelli at 2023-08-21T16:59:37+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

- - - - - b28f9e23 by Marco Simonelli at 2023-08-21T16:59:38+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

- - - - - d702f38d by Marco Simonelli at 2023-08-21T16:59:38+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

- - - - - a05ad213 by Marco Simonelli at 2023-08-21T16:59:38+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

- - - - - a33dd334 by Marco Simonelli at 2023-08-21T16:59:39+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

- - - - - ee9aaf32 by Gaba at 2023-08-21T16:59:39+02:00 Adding issue and merge request templates

- - - - - 5165c55f by Pier Angelo Vendrame at 2023-08-21T16:59:40+02:00 Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

- - - - - ba961d98 by Pier Angelo Vendrame at 2023-08-21T16:59:40+02:00 Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

- - - - - 1fe13246 by Dan Ballard at 2023-08-21T16:59:41+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac

- - - - - 56378613 by Pier Angelo Vendrame at 2023-08-21T16:59:41+02:00 Bug 41108: Remove privileged macOS installation from 102

- - - - - fb3c1d79 by Dan Ballard at 2023-08-21T16:59:42+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies

- - - - - 1db35208 by Matthew Finkel at 2023-08-21T16:59:42+02:00 Bug 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

- - - - - 53939681 by Matthew Finkel at 2023-08-21T16:59:42+02:00 Bug 28125: Prevent non-Necko network connections

- - - - - 998ea589 by Mike Perry at 2023-08-21T16:59:43+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

- - - - - adf7843f by Alex Catarineu at 2023-08-21T16:59:43+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

- - - - - c0d1859b by Georg Koppen at 2023-08-21T16:59:44+02:00 Bug 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

- - - - - 1f86038d by Kathy Brade at 2023-08-21T16:59:44+02:00 Bug 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

- - - - - 6e066ce2 by Kathy Brade at 2023-08-21T16:59:45+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

- - - - - 3f7f4aa5 by Alex Catarineu at 2023-08-21T16:59:45+02:00 Bug 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

- - - - - 24b4716a by Kathy Brade at 2023-08-21T16:59:46+02:00 Bug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

- - - - - ba99e83f by Arthur Edelstein at 2023-08-21T16:59:46+02:00 Bug 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.

- - - - - bb7d8245 by Alex Catarineu at 2023-08-21T16:59:46+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

- - - - - 339fe5ea by Pier Angelo Vendrame at 2023-08-21T16:59:47+02:00 Bug 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

- - - - - 8c404899 by Georg Koppen at 2023-08-21T16:59:47+02:00 Bug 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

- - - - - d748b6ec by Alex Catarineu at 2023-08-21T16:59:48+02:00 Bug 28369: Stop shipping pingsender executable

- - - - - 3342770c by cypherpunks1 at 2023-08-21T16:59:48+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING

- - - - - f91d54be by cypherpunks1 at 2023-08-21T16:59:49+02:00 Bug 41568: Disable LaterRun

- - - - - 9f3496ca by cypherpunks1 at 2023-08-21T16:59:52+02:00 Bug 40717: Hide Windows SSO in settings

- - - - - 57ca0143 by Pier Angelo Vendrame at 2023-08-21T16:59:52+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled.

The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled.

Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature.

- - - - - 5a3c823d by Pier Angelo Vendrame at 2023-08-21T16:59:53+02:00 Bug 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

- - - - - 5d8e09f6 by Mike Perry at 2023-08-21T16:59:53+02:00 Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Bug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

Bug 18297: Use separate Noto JP,KR,SC,TC fonts

Bug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug 23745: Set dom.indexedDB.enabled = true

Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

Bug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

Bug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.

Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

Bug 29916: Make sure enterprise policies are disabled

Bug 2874: Block Components.interfaces from content

Bug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

Bug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.

Bug 30845: Make sure default themes and other internal extensions are enabled

Bug 28896: Enable extensions in private browsing by default

Bug 31065: Explicitly allow proxying localhost

Bug 31598: Enable letterboxing

Disable Presentation API everywhere

Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.

Bug 32321: Disable Mozilla's MitM pings

Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

Bug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

Bug 16441: Suppress "Reset Tor Browser" prompt.

Bug 29120: Use the in-memory media cache and increase its maximum size.

Bug 33697: use old search config based on list.json

Bug 33855: Ensure that site-specific browser mode is disabled.

Bug 30682: Disable Intermediate CA Preloading.

Bug 40061: Omit the Windows default browser agent from the build

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40408: Disallow SVG Context Paint in all web content

Bug 40308: Disable network partitioning until we evaluate dFPI

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40383: Disable dom.enable_event_timing

Bug 40423: Disable http/3

Bug 40177: Update prefs for Fx91esr

Bug 40700: Disable addons and features recommendations

Bug 40682: Disable network.proxy.allow_bypass

Bug 40736: Disable third-party cookies in PBM

Bug 19850: Enabled HTTPS-Only by default

Bug 40912: Hide the screenshot menu

Bug 41292: Disable moreFromMozilla in preferences page

Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

Bug 24686: Set network.http.tailing.enabled to true

Bug 40183: Disable TLS ciphersuites using SHA-1

Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

- - - - - cd77d00d by Richard Pospesel at 2023-08-21T16:59:54+02:00 Bug 41659: Add canonical color definitions to base-browser

- - - - - 766d34b4 by Pier Angelo Vendrame at 2023-08-21T16:59:54+02:00 Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

- - - - - 3a962649 by Alex Catarineu at 2023-08-21T16:59:55+02:00 Bug 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

- - - - - d8a6a56e by Alex Catarineu at 2023-08-21T16:59:55+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView

- - - - - b5ce11e2 by Alex Catarineu at 2023-08-21T16:59:55+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware

- - - - - c5332fba by Alex Catarineu at 2023-08-21T16:59:56+02:00 Bug 26345: Hide tracking protection UI

- - - - - 8ddd7353 by Pier Angelo Vendrame at 2023-08-21T16:59:56+02:00 Bug 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

- - - - - d7128cc2 by Alex Catarineu at 2023-08-21T16:59:57+02:00 Bug 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

- - - - - 0fc75469 by Mike Perry at 2023-08-21T16:59:57+02:00 Bug 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

- - - - - 456cf045 by Igor Oliveira at 2023-08-21T16:59:58+02:00 Bug 23104: Add a default line height compensation

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.

- - - - - 166f71df by Pier Angelo Vendrame at 2023-08-21T16:59:58+02:00 Bug 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.

- - - - - 54dae44a by Matthew Finkel at 2023-08-21T16:59:59+02:00 Bug 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

- - - - - ad4578f4 by Pier Angelo Vendrame at 2023-08-21T16:59:59+02:00 Base Browser strings

This commit adds all the strings needed by following Base Browser patches.

- - - - - 33d02341 by hackademix at 2023-08-21T16:59:59+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

- - - - - 5c7bfebd by hackademix at 2023-08-21T17:00:00+02:00 Bug 41434: Letterboxing, improve logging.

- - - - - bac065c3 by hackademix at 2023-08-21T17:00:00+02:00 Bug 31064: Letterboxing, exempt browser extensions.

- - - - - 09d37910 by hackademix at 2023-08-21T17:00:01+02:00 Bug 32411: Letterboxing, exempt view-source: URIs.

- - - - - 8507c44d by hackademix at 2023-08-21T17:00:01+02:00 Bug 32308: use direct browser sizing for letterboxing.

- - - - - ec5fe21e by hackademix at 2023-08-21T17:00:02+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

- - - - - 11755d8b by Pier Angelo Vendrame at 2023-08-21T17:00:02+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

- - - - - a2414382 by Henry Wilkes at 2023-08-21T17:00:03+02:00 Bug 41371: Temporary hack to fix language selector popup position

- - - - - edb1846e by p13dz at 2023-08-21T17:00:03+02:00 Bug 40283: Workaround for the file upload bug

- - - - - 6676ec96 by Arthur Edelstein at 2023-08-21T17:00:03+02:00 Bug 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

- - - - - fa58311a by Pier Angelo Vendrame at 2023-08-21T17:00:04+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

- - - - - 3473af7a by Henry Wilkes at 2023-08-21T17:00:04+02:00 Bug 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages and about:firefoxview.

Bug 40144: Redirect about:privatebrowsing to the user's home

- - - - - fd4f0d06 by Pier Angelo Vendrame at 2023-08-21T17:00:05+02:00 Bug 41542: Disable the creation of a default profile

Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories.

We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.

- - - - - f7affe97 by Kathy Brade at 2023-08-21T17:00:05+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures

Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary.

- - - - - 31d3235d by Kathy Brade at 2023-08-21T17:00:06+02:00 Bug 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

- - - - - ff2740f5 by Nicolas Vigier at 2023-08-21T17:00:06+02:00 Bug 41682: Add base-browser nightly mar signing key

- - - - - 8c8c7d5d by hackademix at 2023-08-21T17:00:10+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module

- - - - - 3de2aeb1 by hackademix at 2023-08-21T17:00:10+02:00 Bug 41854: Allow overriding download spam protection.

- - - - - 0b827d23 by Pier Angelo Vendrame at 2023-08-21T17:00:10+02:00 Bug 41698: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.

We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

- - - - - 510ce421 by Alex Catarineu at 2023-08-21T17:00:11+02:00 Bug 40069: Add helpers for message passing with extensions

- - - - - cf7ea8e7 by Matthew Finkel at 2023-08-21T17:00:11+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode.

- - - - - 5715aee7 by Pier Angelo Vendrame at 2023-08-21T17:00:12+02:00 Bug 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

- - - - - 7539489d by Pier Angelo Vendrame at 2023-08-21T17:00:12+02:00 Bug 40926: Implemented the New Identity feature

- - - - - 21e43037 by Henry Wilkes at 2023-08-21T17:00:13+02:00 Bug 41736: Customize toolbar for base-browser.

- - - - -

30 changed files:

- .eslintignore - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/ipc/DocAccessibleParent.cpp - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-fullScreenAndPointerLock.js - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml - browser/base/content/fullscreen-and-pointerlock.inc.xhtml - + browser/base/content/languageNotification.js - browser/base/content/main-popupset.inc.xhtml - browser/base/content/navigator-toolbox.inc.xhtml - browser/base/content/test/fullscreen/browser_fullscreen_warning.js - browser/base/jar.mn

The diff was not included because it is too large.

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/139d2ea...