Tom Ritter:
Thanks for this!
On Wed, 13 Mar 2019 at 14:38, Georg Koppen gk@torproject.org wrote:
Q: Do you need a button to disable it globally or after an individual resize?
I'd be fine with a preference being exposed.
So a pref that would disable it globally; but there's no way to disable it otherwise?
Well, I'd be fine if we had like a toolbar button expressing the option to disable that feature. But I'd be fine to test alphas without that.
I realize I didn't unpack the 'individual resize' part. I had had the idea that perhaps a user is very picky about their browser, and they put it in a particular place and damn it, they don't want it letterboxed. We could show a button that disables letterboxing *until* you resize the window again, at which point you're again letterboxed and you would have to click the button again.
I would be happy to not build that ever - even more happy to not build it for the MVP.
Then let's not start with that. :) I think that's too complicated if we aim to ship that feature with individual resizing as you explained above. Or put differently: if users are too annoyed by letterboxing then we should come up with a different solution instead of the individual resizing idea. Right now, I'd just start with letterboxing globally on/off as options and see how that goes.
Q: For very low resolution - under 100 pixels in a dimension - does it need to do something intelligent or just not do any margins at all?
I am not sure I understand the question, could you elaborate?
Let's say we letterbox to multiples of 100px. That means if your resolution is 150x150px, you get letterboxed to 100px x 100px.
What if your resolution is 50px x 50px? Or 50px x 175px? Currently, we don't letterbox you and your resolution is whatever you have it set to, and you're fingerprintable.
Should we do something else? I don't like the idea of locking the browser to a large size the user cannot make smaller.
I would not be worried about that case for a first round of testing as I'd expect the amount of devices that would be affected by that goes to 0. I mean even if we took our current resizing strategy (multiples of 200px x 100px) I doubt there are many computers/phones affected out there. So, not letterboxing for that case right now seems okay to me.
Q: Does it need a user walkthrough explainer? (Probably I think... maybe you can start thinking of how that would look?)
I think that sounds like a good idea.
Me too. Can I ask antonela to put this on her plate? I can brainstorm with her an initial idea of how I envisioned it looking, and just let her take over from there? Depending on how complicated this is, and how far it differs from code I can copy-and-modify, I may not be able to complete this development task though...
Works for me (even though I have not much of a say in antonela's time allocation :) ).
Georg