Re: [tor-dev] [Win32] crash in test/bench.exe

I wrote:

Seems bench.c uses some mutex which is not initialised with 'tor_mutex_init()'. I fail to see which that should be.

With this patch, I no longer get that crash:

--- a/bench.c 2018-01-25 20:15:13 +++ b/bench.c 2018-03-13 12:38:09 @@ -713,6 +713,8 @@ printf("Couldn't seed RNG; exiting.\n"); return 1; } + + init_protocol_warning_severity_level(); crypto_init_siphash_key(); options = options_new(); init_logging(1);

----

But a bit crude. IMHO bench.c shouldn't have to care about such details like mutex'es and atomic counters.