On May 5, 2012, at 3:30 PM, Gisle Vanem wrote:
There are 2 problems with the use of 'stricmp()' (line 295) in tinytest.c.
As it is now, I'm getting an undefined reference to 'stricmp' when linking tinytest.exe and using '-nodefault:oldnames' in the link-flags. Can we please remove this lib from the requirements?
'stricmp()' is used nowhere else in Tor. But rather 'strcasecmp()'.
Can we use that for consistency instead? Need to include "or.h" to include src/compat.h.
Like the lines from src/compat.h says: /* Windows names string functions differently from most other platforms. */ #define strncasecmp _strnicmp #define strcasecmp _stricmp
How about this little patch:
Tinytest is supposed to be an independent library, so including a tor-specific header file doesn't work here.
There are more MSVC-issues in other test/*.c files. I can get back to that.
Please do, thanks.