David Goulet dgoulet@ev0ke.net writes:
Indeed.
I'm unsure between "512 Syntax error in command argument"
"552 Unrecognized entity" [A configuration key, a stream ID, circuit ID, event, mentioned in the command did not actually exist.]
But overall yes!
It looks like the previous code would have done a 512 (when ADD_ONION existed but didn't support authentication yet) so that's probably good here too.
...but, maybe "513 Unrecognized command argument" would be a good candidate, too?
...or even a new one for this case (and future cases) of "recognized, but not yet supported". "560 Not yet implemented" or similar?