The problem is in the "[Tor Weather] Confirmation Successful" email, and it's about the links on the body. Specifically, these links and the text descriptions next to them are mixed up.
Where it says "change your Tor Weather notification preferences here", the link presented is the unsubscribe link. Likewise with the "unsubscribe" text and the preferences link.
Incidentally, I've been looking for the code repository, but what I found (
https://gitweb.torproject.org/weather.git) has different messages. Is this the actual repo?
Regards,
--