Hello Mahrud,
I wanted to ask if you've been using the #4700 branch and how is it going?
We've been planning to include #4700 in the upcoming 0.3.5 release if possible, and we remember that you had some pending patches to it. Do you think you can publish those somewhere if they are to be included upstream?
There are also some further mods that need to happen that I'm not sure if you've performed in your local branch (torrc option & restricting the feature only to onion connections, as per #4700).
Let us know how it's working for you and whether you have any patches that we should have in mind, so that we can see if we can fit it in the 035 release.
Thank you! :)
Hi George,
I was trying to find a way to use the virtual port (i.e. blahblah.onion:*port*) as dst_port, but I couldn't find a suitable in time. For our purposes specifically, we only needed virtual port 443 for https, so I hard-coded 443 in an almost identical branch on top of 0.3.5.0-alpha-dev here: https://github.com/mahrud/tor/commit/a81eac6d0c0a35adc6036e736565f4a8e2f806f...
As far as I know we haven't run into any issues so I kept it minimal, but the torrc option would be very much appreciated!
Thanks, Mahrud
On Wed, Sep 5, 2018 at 5:45 AM George Kadianakis desnacked@riseup.net wrote:
Hello Mahrud,
I wanted to ask if you've been using the #4700 branch and how is it going?
We've been planning to include #4700 in the upcoming 0.3.5 release if possible, and we remember that you had some pending patches to it. Do you think you can publish those somewhere if they are to be included upstream?
There are also some further mods that need to happen that I'm not sure if you've performed in your local branch (torrc option & restricting the feature only to onion connections, as per #4700).
Let us know how it's working for you and whether you have any patches that we should have in mind, so that we can see if we can fit it in the 035 release.
Thank you! :) _______________________________________________ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
Mahrud S dinovirus@gmail.com writes:
Hi George,
I was trying to find a way to use the virtual port (i.e. blahblah.onion:*port*) as dst_port, but I couldn't find a suitable in time. For our purposes specifically, we only needed virtual port 443 for https, so I hard-coded 443 in an almost identical branch on top of 0.3.5.0-alpha-dev here: https://github.com/mahrud/tor/commit/a81eac6d0c0a35adc6036e736565f4a8e2f806f...
As far as I know we haven't run into any issues so I kept it minimal, but the torrc option would be very much appreciated!
Hey Mahrud,
we have a ready-to-merge version of #4700 ready.
Check: https://github.com/torproject/tor/pull/343 for the latest PR.
and https://trac.torproject.org/projects/tor/ticket/4700#comment:21 https://github.com/torproject/tor/pull/327 (the old PR) if you want to read the review comments and bugs.
Let us know if you have any questions or if you don't like something.
Thanks! :)
Hi George,
I think it looks good. Only comment I have is that it would be nice to have an option to change the ipv6 subset, though I imagine people who would use it can easily recompile with their own setting.
I'm also including Gabbi who is working on this now.
Best, Mahrud
On Sat, Sep 15, 2018 at 10:07 AM George Kadianakis desnacked@riseup.net wrote:
Mahrud S dinovirus@gmail.com writes:
Hi George,
I was trying to find a way to use the virtual port (i.e. blahblah.onion:*port*) as dst_port, but I couldn't find a suitable in
time.
For our purposes specifically, we only needed virtual port 443 for https, so I hard-coded 443 in an almost identical branch on top of 0.3.5.0-alpha-dev here:
https://github.com/mahrud/tor/commit/a81eac6d0c0a35adc6036e736565f4a8e2f806f...
As far as I know we haven't run into any issues so I kept it minimal, but the torrc option would be very much appreciated!
Hey Mahrud,
we have a ready-to-merge version of #4700 ready.
Check: https://github.com/torproject/tor/pull/343 for the latest PR.
and https://trac.torproject.org/projects/tor/ticket/4700#comment:21 https://github.com/torproject/tor/pull/327 (the old PR) if you want to read the review comments and bugs.
Let us know if you have any questions or if you don't like something.
Thanks! :)
Mahrud S dinovirus@gmail.com writes:
Hi George,
I think it looks good. Only comment I have is that it would be nice to have an option to change the ipv6 subset, though I imagine people who would use it can easily recompile with their own setting.
Agreed.
IMO we should open a ticket about making the subnet configurable, and handle that in the future.
-
George Kadianakis -
Mahrud S