Hello!
We held our weekly Tor Browser meeting on Monday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-09-16-17.30.lo...
From the weekly updates, we discussed and planned a Tor Browser Alpha
release for Mac OS X due to the new notarization requirement. This will allow for additional testing before Tor Browser 9.0 becomes the stable version. We also discussed backporting a patch onto Tor Browser 8.5 for this and including it in the next stable release.
From the discussions, we decided on making about:blank the default New
Tab page (instead of Firefox's new about:home page), and about:tor will be an alternative option.
We are also beginning the triage of Tor Browser tickets for Bug Smashing and we are adding the keyword "BugSmashFund" on the applicable tickets.
Finally, we are aiming at releasing the new Tor Network Settings UI in an upcoming alpha release. This moves the configuration settings menu from Tor Launcher into the browser's preferences screen (about:preferences#tor).
Below are the notes from our meeting pad:
Discussion: (acat) Should we allow users to change New Tab page to "Firefox Home" (Firefox default new tab page)? see https://trac.torproject.org/projects/tor/ticket/31575 (pili) BugSmashFund: if you see any bugs that are outside sponsor work and would be good to fix after ESR68 work is over please tag on trac with "BugSmashFund" keyword (pili) Gentle reminder to update tickets for September with points estimate and actual points once closed. (anto) could we have #31286 (Tor Network Settings on about:preferences#tor) on alpha channel?
GeKo: Last week: - Bug 30126: Apple notarization - Bug 31538: Windows reproducibility - Bug 31584: Clean-up mingw-w64 project (currently testing a final patch) - fixed Windows nightly build failure (#31732) - wrote a patch for #31725 (mk localization did not work properly) - worked on missing pieces for #30429 - acat/sysrqb where are we with the reviews/fixups for #31010? Is there anything left from your side? - reviews (#24653, #26345, #30304, #31575) - double-checked our hardening flag situation for Windows and Linux bundles after toolchain updates; I think there a no surprises and unknown issues that popped up - caught up with blog comments (having 4 active blog posts to take care of in parallel is harder than thought :) ) This week: - stack smashing protection for Windows binaries (#29013) - #31597 (Mozilla bug review for bugs squashed between Firefox 61-68) - finish missing pieces for #30429 - maybe release for testing #30126 on alpha channel? we'd need #31702 for that which is supposed to apply cleanly for esr68 at least; apple is saying Catalina gets out in October so, we might have a bit more time here? - reviews
mcs and brade: Last week: - Testing and research for #30126 (Make Tor Browser on macOS compatible with Apple's notarization). - Verified that #31464 is no longer an issue (meek and moat are broken on macOS 10.9). - Debugged #31607 (App menu items stop working). - On macOS, menu-related objects are being freed too soon or at the wrong time. - This is a strange issue that is proving to be difficult to debug. (GeKo: Do we know which patch is causing that? If not, could we track down this bug easier that way? mcs: We think it is not caused by a patch but by Tor Launcher opening a modal window during startup but we will confirm) This week/upcoming: - Continue work on #31607 (App menu items stop working). - #31491 (clean up the old meek http helper browser profiles). - Work on other tbb-9.0-must-alpha tickets if time permits. - Reminder: we will be on vacation next week.
sysrqb: Last week: Mostly afk. Releases Began dog-fooding 9.0a6 This week: - Pick up #30943 again (only private tabs as the default) - Investigate auto-complete not working on 9.0a6 Android (#31720) - Maybe look at showing Tor Browser version number on Android (#30943) - Maybe help with getting x86_64 Android builds (#31192)
_hc/eighthave: Last week: tor-android clean-up work, 64-bit builds and configure.ac --enable-android path tor-android reproducible build (given the same docker container) This week: Android-native TorService
tjr: - Worked on the WASM patch but waiting on help: https://bugzilla.mozilla.org/show_bug.cgi?id=1576254 - Landed the alloc/dealloc patch in 68: https://bugzilla.mozilla.org/show_bug.cgi?id=1547519#c32 - There are a couple of concerning test failures for the MinGW build in the esr68 branch that might/are probably related to this. - I need to fix my IDA installation to be able to dig into these though...
boklm: Last week: - Did some reviews: - #31450 (Still use GCC for 64bit Linux debug builds after switch to 68 ESR) - #31264 (tar.gz output files contain non-reproducible timestamps) - #31621 (Fix node bug that makes large writes to stdout fail) - #31641 (Provide link to Tor Browser for Android alpha on our alpha download page) - #31596 (Bump mingw-w64 version to pick up fix for #31567) - #31732 (Windows nightly build failure) - Made a patch for #31448 (gold and lld break linking 32bit Linux bundles we need to resort to bfd) - Opened #31755 (Separate update pings and update requests graphs for Tor Browser alpha and release users) - Looked at #31646 (Update abicheck to require newer libstdc++.so.6) This week: - Test patch for #31538 (Windows bundles based on ESR 68 are not built reproducibly) - Review #27493 ('mk_add_options' or 'export' MOZILLA_OFFICIAL) - Make patch for #31646 (Update abicheck to require newer libstdc++.so.6) - will be afk on Tuesday (tomorrow)
acat: Last week: - #26345 - Finish Disable tracking protection UI in FF67-esr (in review) - Investigated if serviceworkers can still see localized msgs in #30683. - Investigated a bit RemoteSettings background requests: #31740 - Created Bugzilla ticket for #30683 (https://bugzilla.mozilla.org/show_bug.cgi?id=1581537) This week: - 31303: Browser Toolbox fails to open when tor-launcher is present V(is it fine if I take this one pospeselr?) - tbb-9.0-must-alpha tickets
sisbell: Last Week: - #31564: Android bundles not reproducible - implemented solution using apktool. Need verification if it works across build machines with different OS. (GeKo: I'll do that while reviewing) - #31568: Gradle how-to. Found solution to remove missing resources that was causing double artifact entries. Documented this. This week: - open tickets for tor-android-service patches - 31564 (if additional changes needed) - 31192 - x86_64 support
Pili: Last week: - mostly afk - Gave a talk on using onion services for APIs at API Days Barcelona This week: - Looking at our roadmap and capacity - Moving forward with team lead transition tasks
Antonela: - #31660 - Investigating about ESR68 Onboarding > https://trac.torproject.org/projects/tor/ticket/31660 - #31286 - TB9 Network Settings is almost done. Shared with phw and the anti-censorship team to have them in the same page. > https://trac.torproject.org/projects/tor/ticket/31286 - #27511 - Working with TB New Identity > https://trac.torproject.org/projects/tor/ticket/27511 - Back to S27 Onion Services
pospeselr:
Last Week:
got moat bridgedb requests mostly working with new about:preferences#tor page (#31286)
CAPTCHA displayed, guesses can be made and submitted, bridge strings returned back but aren't displayed or saved anywhere
This Week:
rebase current patches to latest esr68 branch >:[
port over the read/write logic for the tor proxy settings, and integrate that into the bridgedb request logic
Have a good week! Matt
Hello!
We held our weekly Tor Browser meeting yesterday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-09-23-17.30.lo...
From the weekly updates, we discussed some details around hardening Tor
Browser on Windows. We also discussed upcoming work by the Guardian Project related to Tor integration in Android apps and how we can benefit from it, as well as working together. In particular, the discussion focused on sharing and learning from each other.
There will be a Tor Browser Release Meeting on Wednesday, 25th September
at 18UTC on #tor-meeting.
There was a discussion point about testing nightly builds with FuzzyFox in the near future, but that discussion was postponed until another meeting.
Below are the notes from our meeting pad:
========================================= Discussion: 9.0a7 release this week? Should we think about enabling fuzzyfox on nightly after 68esr rebasing is completed (maybe after 9.0)?
mcs and brade (will miss the meeting): Last week: - Helped with #31303 (Browser Toolbox fails to open when tor-launcher is present). - Created fixup patches for #30429 (Rebase Tor Browser patches for Firefox ESR 68). - Created patches for #31491 (clean up the old meek http helper browser profiles). - More debugging for #31607 (App menu items stop working). - The fix still eludes us; we reached out to Mozilla for help. This week: - Vacation.
acat (will miss the meeting): Last week: - 31303: Browser Toolbox fails to open when tor-launcher is present - Localization issues: #28196 and #31747. - Revised .onion security expectations patch in #30429. - #27601: backported some fixes - Investigated #15563: ServiceWorkers violate first party isolation... - Fixed #31574: TypeError: addon is null with Tor Browser based on ESR 68 - Revised patch for #31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68 This week: - Finish fixing Localization issues: #28196 and #31747. - #30504: Investigate if New Identity works properly after moving to ESR 68 - Revise .onion security expectations patch in #30429. - #30463: Make sure telemetry reporting is disabled in Tor Browser 9 - Try to finally get https://bugzilla.mozilla.org/show_bug.cgi?id=1573276 landed
GeKo: Last Week: - Firefox bug review (#31597) - stack smashing protection for Firefox on Windows (#29013) - work on create dependencies file issue (#31568) - lots of reviews (#30429, #30943, #31646, #31491, #31303, #31574, #31448, #27601, #25483, #31192) This Week: - Firefox bug review (#31597) - stack smashing protection for Firefox on Windows (#29013) - reviews - release prep for 9.0a7 - will be afk tomorrow
sysrqb: Last week: - Investigated autocomplete on Android not working (#31720) - Updated branch for PBM autostart on Android (#31010) - Created patch for showing Tor Browser version on about:tor on Android (#30943) - Created patch for Android x86_64 support (#31192) This week: - Finish autocomplete on Android not working (#31720) - Finishing Android 68esr rebase (#31010) - Look into Security Slider rendering bug on Android (#31822) - release prep
pospeselr: Last week: - rebased my #31286 (bridge settings) work against ESR68 branch and fixed various issues surrounding that - implemented proxy settings read/write from/to Tor daemon - populating UI with read proxy settings - integrated antonela's new Tor icon :) This Week: - port over the SETCONF logic (so settings are actually saved) - feed proxy settings to BridgeDB when requesting bridges - firewall settings/read/write populate - traveling mid-week but will be on this weekend
tjr: - Kept bugging for feedback on wasm-in-extensions https://bugzilla.mozilla.org/show_bug.cgi?id=1576254 - Have been (slowly) investigating cppunittest failures on esr68 and if there are bad implications from that - Have been working (slowly) on making outer-window-size spoofing the default in Firefox. Lots of tests (failures) to update - Haven't started this, but the rust networking check we have for 68 needs to be redone with a new strategy https://bugzilla.mozilla.org/show_bug.cgi?id=1376621
boklm: Last week: - Some reviews: - #31564 (Android bundles based on ESR 68 are not built reproducibly anymore) - #31584 (Clean up mingw-w64 project) - Looked at #31729 (Warning about missing GTK wayland related packages in configure script) - Made patch for #31646 (Update abicheck to require newer libstdc++.so.6) This week: - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets - Review #27493 ('mk_add_options' or 'export' MOZILLA_OFFICIAL), #30334 (build_go_lib for executables), #29187 (Bump NSIS version to 3.04) - Will be afk tomorrow (Tuesday)
Antonela: - #31286 - TB9 Network Settings, added some missed assets - Filed #31768 - TB9 Net Settings Onboarding - #30022, #30025 - S27 Onion, Errors and Tor Browser this week. I have a lot of questions, so please be patient :) - #27511 - TB9? New Identity, nah are running user research in Brasil with a journalists group
sisbell: Last Week: - #31192: Support x86_64: made changes and verified this works on emulator - #31564: Android Reproducibility: Upgraded to Buster. Still need to test if build works with JDK 11 This week: - 31564 - upgrade JDK and verify build with latest apktool from buster - Submit merge request for tor-android-library with latest version of tor
eighthave/_hc: Last Week: - I was sick all week, so I mostly did mindless size optimization of tor for Android https://github.com/guardianproject/tor-android/issues/18, but it looks like it'll shave 1-2MB of each arch - I was not able to get -ffunction-sections and -gc-sections going, which was standard part of Android ndk-build. It seems to be removed from clang builds though. - I started moving Android config into tor/configure.ac's --enable-android flag https://trac.torproject.org/projects/tor/ticket/28766#comment:6 This Week: - native Android TorService that links in tor daemon as a shared library - how best to share build setups and/or binaries between Tor Browser and others
pili: Last week: - S27 meeting - Roadmap gardening This week: - Tor Browser Release meeting - S27 September report - More roadmap gardening - We have so far planned for 85.15 points worth of work when we have a capacity of 79 points for the month which is not bad for our first time doing this - Please update the actual points for the issues you have worked on: https://trac.torproject.org/projects/tor/query?status=closed&keywords=~T... - #26345 - #27399 - #27601 - #30683 - #30384 - #31308 - #31448 - #31491 - #31604 - #31606 - #31646 - #31656 - Please add points estimation for the following tickets: - #19417 - #30036 - #30460 - #30461 - #31778 - #31641 =========================================
Have a good week! Matt
Hello!
We held our weekly Tor Browser meeting on Monday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-09-30-17.30.lo...
From the weekly updates, we discussed some options for a new icon that
Tor Browser will use for its "New Identity" button. The chosen image should embody the idea of throwing away a person's current digital identity (as it is seen by websites) and creating a new one. This is not an easy task, and, in addition to this, the concept of "identity" as provided in a web browser is not intuitive. The team is considering some options on ticket #25711 [0].
During the meeting there was a call-for-proposals for submitting talks to FOSDEM (both main track and non-main track).
Next, we dove into some details about the on-going issue with building reproducible Tor Browser APKs for Android. The new Tor Browser Alpha version based on Firefox 68esr introduced new build dependencies that do not output the same exact result every time (for the same source code). This is being investigated in ticket #31564 [1].
We also heard some updates about tor integration into NameCoin.
Lastly, we chose a time for meeting again this week on the topic of moving Tor Browser onto Mozilla's Rapid Release cycle. The meeting will be tomorrow (Thursday) at 1500 UTC.
[0] https://trac.torproject.org/projects/tor/ticket/27511#comment:17 [1] https://bugs.torproject.org/31564
================================================== Week of September 30, 2019
Discussion: sysrqb: Meeting this week for discussing questions about moving onto rapid release cycle
GeKo: Last week: - release preparations - work on feature audit (#31597, #31591) - investigation of ko bundles bustage (#31886) https://www.urbandictionary.com/define.php?term=bustage - backported patch for macOS Catalina (#31702) - investigation of OpenSSL CVE ticket (#31383): boklm: nice catch! I think that means we can close the ticket? Let's do so tomorrow if there is no new input. [boklm: Yes, I think we can close it if no other input tomorrow] - tried to find patches for stack smashing protection bug (#29013) and PDB files exposure (#31546); Thanks for Martin Storsjö the former seems achievable soon-ish - reviews (a bit #31010, #31844, #31192/#30380, #25483, #31664, #31575, #31720, backport for bug 1573276, #28196, #31822, #30429, #24920) - started to look over ff68-esr tickets not yet considered for TB 9 This week: - release preparations - finish triaging ff68-esr tickets for TB 9 - work on feature audit (#31597, #31591) - come up with patch for #29013 - reviews
antonela:
- #27511 - New Identity button, any thought? https://trac.torproject.org/projects/tor/ticket/27511#comment:17
- #31286 - Net Settings, all good pospeselr? pospeselr: so good, unless you have opinions on how tor daemon logs should be viewed/acquired. | For sure i have, do we have a child ticket? is a blocker for TB9.0 stable? pospeselr: no I don't think so, but was planning on implementing this today, catch me after the meeting :) | will do :3
- #31768 - TB9 Onboarding, working on it with Dunqan
- #31778 - Anything needed on my side for this?
- S27: We are working on #30025 - Better onion errors in clients. There are multiple tickets involved, but we are first listing onion errors here #30090. If you want to join us, we will discuss it tomorrow Tuesday at 15UTC in #tor-meeting. asn sent https://lists.torproject.org/pipermail/tor-dev/2019-September/014046.html
- S30: We have a kickoff meeting next Monday October 7th, 15UTC in #tor-meeting. UX and TB teams will work together on Objective 3. https://trac.torproject.org/projects/tor/ticket/31265 [Improve Tor Browser experience for human rights defenders under censorship.]Closed
pospeselr: Last week: - fully functional patch for #31286 up for review This week: - test builds for y'all to look at - some more work on #31286 remains, probably a few days worth (not including any revisions needed from code-review)
- Tor log viewer
- smarter SETCONF behavior
- proper string support
- update the learnmore links
- other misc cleanup/refactoring/todo completion
Jeremy Rand: Last week: - Submitted initial patch for #19859. Nick reviewed it, wants some minor changes, but should be straightforward to get into a mergeable state. - Maintain a pool of clean connections for Electrum-NMC stream isolation. Eliminates latency cost of having stream isolation in Electrum-NMC. Submitted upstream to Electrum; will be in Electrum-NMC 3.3.8. - Electrum-NMC stream isolation covers all network-related RPC methods. Submitted upstream to Electrum; will be in Electrum-NMC 3.3.8. - Stream isolation for Electrum-NMC name-related RPC methods. Will be in Electrum-NMC 3.3.8. - Filed Namecoin Core issue for hashed name lookups. Daniel Kraft (Namecoin Core developer) says he should be able to get it done with circa a day or so of work; he should have time to spend on it within the next couple months. When complete, this will allow us to decrease name lookups to 1 round trip (status quo is 2 round trips). (This is, AFAICT, not a blocker for Tor Browser nightlies, but would be a useful improvement.) - Submitted patch to Electrum for fetching a single header instead of a full chunk when doing SPV verification; will be in Electrum-NMC 3.3.8. - Patched Electrum SPV verifier to work without a wallet; this allows avoiding code duplication for name lookups. Submitted to upstream Electrum; will be in Electrum-NMC 3.3.8. - Patched upstream Electrum gettransaction RPC method to support SPV verification. - Refactored name_show RPC method in Electrum-NMC to use upstream gettransaction RPC method (with above patch) for most of the implementation. Simplifies our code substantially. Will be in Electrum-NMC 3.3.8. - Fixed various small bugs in Electrum-NMC 3.3.8 branch. - Noticed that ~150kB of the binary size cost of adding Electrum-NMC to Tor Browser is taken up by Electrum-NMC's copy of the root CA list; tried and failed to find a straightforward way to make Electrum-NMC use Firefox/NSS's copy of that. Will come back to this in the future, but there are better things to optimize short-term. This week: - Forward-port some remaining optimizations (e.g. parallelized blockchain download and binary size improvements) from the branch I demoed in Stockholm to play well with Electrum-NMC 3.3.8 branch and rbm build environment. - Address Nick's feedback on #19859. - Maybe make some progress on stream isolation in ncprop279 and StemNS.
mcs and brade: Last week: - Vacation. This week: - Test 9.0a7 candidate builds on macOS 10.15 beta 8. - #31019 (Investigate update on Windows via BITS) - double-check that BITS is 100% disabled in Tor Browser 9.0. - #31607 (App menu items stop working). - (maybe) Sponsor 27 meeting r.e. onion service errors vs. SOCKS optimistic data. - End of month / end of quarter administrative tasks.
sysrqb: Last week: Finished mobile/android/ rebase (#31010) Created patch for slider not showing on Android security slider (#31822) Reviewed backports for Catalina (#31702) Reviewed patch for mozconfigs (#27493) Patched tor-android-service for avoiding Dormant mode (#30380) Finished patch for x86_64 (#31192) Reviewed tor-android-service patches (#30199) Finished Private Tabs By Default on Android (and opened follow-up tickets (#24920) Fixed autocomplete on Android (#31720) This week: Release prep and release Investigate EME and bundled fonts on Android (#31880 and #31881) Other Android things
acat: Last week: - Worked on fixing .onion security expectations patch for android (#30429, #31010) - https://bugzilla.mozilla.org/show_bug.cgi?id=1573276 landed - #30504: Investigate if New Identity works properly after moving to ESR 68 - Finish fixing Localization issues: #28196 - Backported patch for #30304: Browser locale can be obtained via DTD strings This week: - Finish fixing .onion security expectations patch for android (#30429, #31010) - Finish fixing Localization issues: #31747 (old onboarding strings) - #30463: Make sure telemetry reporting is disabled in Tor Browser 9 - #19417: asm.js files should be no linkability risk - #31778: Support default dark-theme for the Circuit Display UI - #27511: Add New identity button to toolbar - https://bugzilla.mozilla.org/show_bug.cgi?id=1581537
boklm: Last week: - Fixed #31844 (OpenSSL 1.1.1d fails to compile for some platforms/architectures) - Enabled android-x86_64 nightly builds - Reviewed/tested #29187 (Bump NSIS version to 3.04) - Helped build new release This week: - Help publish the new alpha - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets - Review #30334 (build_go_lib for executables), #29187 (Bump NSIS version to 3.04), #31550 (Fix shellcheck (and related) issues in start-tor-browser)
tjr: - unstuck on wasm: https://bugzilla.mozilla.org/show_bug.cgi?id=1576254
- Expecting finishing this this week, and will prep backport
pili: Last week: - S27 work completion and monthly report - roadmap gardening - Tor Browser release meeting - Fosdem organization This week: - OTF Browser proposal - Fosdem organization - any browser devs in Europe up for doing a talk? - more roadmap gardening - kicking off developer portal work
sisbell: Last Week: - #31564: Android Reproducibility: Tried out a number of things. Got openjdk-8 working with buster. Still problem with apktool version in buster, the version reported is not the actual version so its too old to use. Can’t shrink apk to remove problem resources since Firefox uses dynamic lookup of resources This week: - 31564 - going to track each dependency and manually use aapt/appt2 to rebuild resources. ============================================
- Matt
Hello!
We held our weekly Tor Browser meeting on Monday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-10-07-17.29.lo...
From the weekly updates were quiet this week and we didn't discuss much.
From the discussions, we are planning another Tor Browser Alpha release
at the beginning of next week. After this, we discussed ticket triage and whether we are still happy with the current priorities of tickets targeting 9.0a and 9.0.
Next, we discussed the new icon chosen for the new "New Identity" button. We're going with the broom! The conversation then moved onto string localization and making sure we freeze all new strings soon such that we give translators enough time and we can release fully-localized Tor Browser 9.0.
After this, Mike Perry joined us as a surprise guest and asked some questions related to the networking code audit of Firefox 68esr-based Tor Browser he's doing for us (the ticket for that: https://trac.torproject.org/projects/tor/ticket/31144).
And finally, we began discussing NameCoin's Tor Browser integration work. In particular, there was a question about reducing the size of the NameCoin binary and whether bundling a subset of Certificate Authority Root Certificates is a reasonable solution.
--------------------------------------------------------------- Week of October 7, 2019 Discussion: sysrqb: Next alpha release 14 October, code freeze 10 October sysrqb: Are the current tbb-9.0-must-alpha tickets reasonable? Are we missing any tickets that should be included in a 9.0a? Are there any tickets we can/should delay until 9.0 or 9.5a? GeKo: Are we fine with the broom icon for New Identity? Pili: Reminder to update tickets with "Actual Points" once the ticket is closed
mcs and brade: Last week: - Opened #31910 (replace meek_lite with meek in circuit display). - Closed #31019 (Investigate update on Windows via BITS). - Fixed #31935 (TB9.0a7 is asking for a new profile). - Opened and fixed #31955 (macOS: avoid throwing inside nonBrowserWindowStartup()). - Published patches for #31607 (App menu items stop working). - We are still hoping to receive feedback from Mozilla engineers. - Started to look at #31768 (Introduce Tor network settings and other updates in TB9 onboarding). - Tested 9.0a7 candidate builds on macOS 10.15 beta 8. - Attended the ESR migration meeting. - Did a little thinking about onion service errors vs. SOCKS optimistic data.
This week: - #31768 (Introduce Tor network settings and other updates in TB9 onboarding). - #31910 (replace meek_lite with meek in circuit display). - #31607 (App menu items stop working). - Sponsor 27 meeting r.e. onion service errors vs. SOCKS optimistic data. - Open a Firefox bug for #31547 (Back out or modify patches for Mozilla's bug 1574980). - Create ticket for https://blog.torproject.org/comment/284256#comment-284256
boklm: Last week: - Helped publish the new alpha - Made patches for: - #31293 (tor-android-service gradle failure when probing network interfaces) - #31926 (Add Android x86_64 to the alpha download page) - #31911 (Add information about monitoring disk space for cdn.tpo) - Updated patch for #31564 (Android bundles based on ESR 68 are not built reproducibly anymore) - Worked on #25099 (Update nightly version number) - Reviewed #31550 (Fix shellcheck (and related) issues in start-tor-browser) - Started reviewing #29013 (Provide stack smashing protection for mingw-clang builds) - Looked at the new alpha users update pings graph (#31755) This week: - Finish reviewing #29013 (Provide stack smashing protection for mingw-clang builds) - Look at fpcentral issues after buster upgrade - Try to fix #31987 (Make fpcentral recognize Tor Browser esr68) - Try to fix #31986 (Update fpcentral dependencies) - Review #30334 (build_go_lib for executables) - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets - Help building new alpha
pospeselr: Last week: - test builds! ( https://trac.torproject.org/projects/tor/ticket/31286#comment:26 ) - Tor log viewer in about:preferences#tor - lots of code cleanup, refactoring and general TODO completions This week: - finish resolving acat's patch feedback, finish TODO list and get a final patch candidate up
Jeremy Rand: Last week: - Electrum-NMC binary size optimizations: - Forward-ported all Electrum-NMC binary size optimizations from demo branch to 3.3.8 branch. - Removed Python protobuf package. (Only was needed for Payment Protocol, which isn't a thing for Tor Browser's use case.) - Optimized Python certifi package to only include root CA's from top 10 intermediate CA's in the Alexa Top 1 Million.
- Kudos to Ryan Castellucci for the idea.
- 12.7 KiB instead of 275.5 KiB (uncompressed .pem file).
- Added support for the above optimizations in tor-browser-build.
- ncprop279 binary size optimizations:
- Added build tags to ncdns that disable TLSA-related code. (Not needed for Tor Browser's current use case.)
- Decreases size of ncprop279 binary (without rbm, uncompressed, no symbol stripping) by 0.7 MiB.
- Added support for the above optimizations in tor-browser-build.
This week: - Forward-port parallelized blockchain download from demo branch to 3.3.8 branch; make it play well with rbm build environment. - Address Nick's feedback on #19859. - Maybe make some progress on stream isolation in ncprop279 and StemNS.
sysrqb: Last week: Updated tickets with points Added tbb-no-uplift onto a few older tickets, so torpat.ch is more colorful Started working on squashing and reordering some Android patches within the set of desktop patches (#31918) Spent some time on OTF proposal This week: Finish #31918 Test some branches: #31010, #31822, tor-browser-build patches More reviews
tjr - Finished and landed the allow-wasm-for-extensions patch: https://bugzilla.mozilla.org/show_bug.cgi?id=1576254 \o/ - Will work on esr68 backport this week; but I think it will be one that Tor carries locally and we don't land in esr68 - Got to the bottom of the cppunittest failures on esr68 mingw builds! \o/ - Will try to land tests in that branch this week. - Have been working on a few mingw cleanup bugs. Most have no reason to backport. But at least one does: - https://bugzilla.mozilla.org/show_bug.cgi?id=1585351 <- Due to library maintenance reasons we won't backport this; but Tor should.
GeKo: Last week: -Worked on features review (#31591, #31597) -investigated some issues (#31985, #31954) -wrote small patches for #31822, #31811 -reviews (#27511, #31911, #31914, #31955, #30643, #31935, #19417, #31981, #31979, #31568, #31747 -investigated bug in ar locale (#31929) -had a ton of fun with #31980 -helped with OTF proposal This week: -Finishing #31591 -More work on #31597 -re-enabling language packs signature checks where possible (#31942) -release prep for 9.0a8 -OTF proposal review -reviews
acat: Last week: - Finish fixing Localization issues: #31747 (old onboarding strings) - #30463: Make sure telemetry reporting is disabled in Tor Browser 9 - #19417: asm.js files should be no linkability risk - Finish fixing .onion security expectations patch for android (#30429, #31010) - #27511: Add New identity button to toolbar - Review #31286. This week: - Finish #31778: Support default dark-theme for the Circuit Display UI. - #13543: HTML5 media support may lead to fingerprinting - #31602: Remove Pocket indicators in UI and disable it by default - https://bugzilla.mozilla.org/show_bug.cgi?id=1581537
pili: Last week: - OTF Browser Proposal - Roadmapping for October - FOSDEM20 organisation This week: - Totalling up September points (~40 team points for the month),
- hoping to get some more clarity on team capacity by going through a few more month cycles
- More OTF Browser Proposal - Tor Browser release meeting this week - S27 "extraordinary" meeting this week - FOSDEM20 organisation
- submitted for a stand today
- planning to submit a main track talk this week
sisbell: Last Week: - 31979/30460: TOPL dependency list (regenerated with latest how to doc). I believe this should be resolved regarding the artifact counts. Also verified tor-android-service and tor-onion-proxy-library deps - 31981: remove deprecated patch from tor-android-service - 31568: Updated gradle how to - 31130: Worked on buster upgrade (in progress) This week: - Finish buster upgrade - 30665 - look into clang issue
Antonela: - #27511 - New Identity button, done \o/
- #31286 - Net Settings, almost done!
- #31768 - TB9 Onboarding, Dunqan worked on the fist version, i worked with steph on the content, i'll iterate today/tomorrow based on recent comments
- #31778 - Support for the dark theme, status? (Seems acat is picking that up, GeKo) (cool, thanks! -A)
- S27: Worked on #19251 - Better onion errors in clients. Any comment is appreciated, no hurries. ---------------------------------------------------------
Have a good week, Matt
Hello!
Sorry for the delayed report. We held our weekly Tor Browser meeting last Monday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-10-14-17.30.lo...
Briefly, we discussed ticket priority for the upcoming release, as well as ticket priority for the remainder of the year.
-------------------------------- Week of October 14, 2019 Discussion: -remaining items for 9.0 -next major tasks to work on until the end of the year (I have #30570, #28325, #31660, s27, and s9 (#18867 nightly auto-updates) on my list; does that sound reasonable? Is there more/anything else?) [sysrqb: 31005 maybe a task we want before next year, and get a head start on #29255.] - Electrum-NMC optimization for Python certifi package (only include root CA's from top 10 intermediate CA's in the Alexa Top 1 Million) -- is getting more data on real-world root CA usage in Electrum servers considered a blocker for a merge to Nightly? -Jeremy
tjr (double-booked on meetings, highlight me for a response) - mingw-clang tests are landing in esr68 \o/ - I backported the wasm patch to ESR68; running through try. Should be available today/tomorrow
GeKo: Last week: -release prep for 9.0a8 -esr68 feature review (#31591) -investigated #32013 and #32057 -wrote patch for preference clean-up (first round) Thanks to Thorin for all the hard work! (#27268) -wrote patch for enabling lang pack signature checks on Windows and Linux again (#31942) -reviews (#31286, #30429, #31010, #30460, #13543, #31607, #32041, #30665, #30461, #31144, #31768, #31910, #32018, #31778, #27511, #31568, #31968, #31979, #31564, #31822) -started investigation of reproducibility bugs (#32052/#32053) This week: -help with 9.0a8 release -help with reproducibility bugs recently found (#32052/#32053) -preparing Tor Browser 9 and 9.5 and building it -finish some small patches for 9.5a1-only changes (e.g. #31989) -finish esr68 feature review (#31591) -make more progress on all closed bugs between esr60 and esr68 (#31597) -tracking down address bar issue (#32019) -double-checking #27604 (bundle relocation is broken) [mcs: brade and I could take this task if it would help you] (GeKo: please do. i think we could even think about implementing the small fix I mentioned in the ticket (or something better) at least for 9.5a1) -reviews
Pili: Last week: - OTF Browser proposal - FOSDEM main track talk and stand submission - S27 meeting to discuss prop 304 and prop 309 incompatibilities - Tor Browser release meeting - general roadmap and ticket gardening This week: - OTF Browser proposal - S27 meeting - #30054 - added some updates on next steps - #32011 - added aarch64 .apk to download page - afk next week - traveling to London for MozFest on Monday and afk intermittently throughout the week
sysrqb: Last week: Reviewed and tested acat's #31010 patch Reviewed and tested #31822 patch backport for security slider on mobile Filed a ticket for completely disabling ActivityStream on Android (#31983) Audited wasm implementation #21549 Reviewed Mike's networking audit results, and wrote patches (#31144) This week: Test patches for network potential leaks (#31144) Test wasm (should we try this in 9.5a1? I saw we're enabling asm.js in 9.0) Release prep/Release Revert aarch64 torbutton fixup (#31730 ) Maybe bring search engine parity on mobile (#30017)
Jeremy Rand: Last week: - Namecoin stream isolation
- Addressed Conformal's feedback on btcd/rpcclient PR. It's now ACKed by one of the Conformal devs and should be merged shortly.
- #19859: Addressed Nick's feedback on torspec patch. Awaiting further feedback. - Added stream isolation to hlandau/madns; Hugo has merged the PR. - Patched ncdns to use madns's stream isolation; PR should be merged soon. - Patched ncdns to isolate cache; PR should be merged soon. - Patched ncprop279 to use madns's stream isolation and accept stream isolation data via Prop279; PR should be merged soon. - Electrum-NMC syncup optimizations
- Forward-ported parallel blockchain sync to 3.3.8 branch.
- Noticed that tor-browser-build doesn't have a license.
- Filed #32038
- Was a bit less productive than usual due to spending the weekend babysitting the network during a scheduled softfork.
- This decreased productivity may bleed into the beginning of this week.
This week: - Finish up stream isolation in ncprop279 and dependencies. - Continue working on #19859, assuming my current patches get more feedback.
mcs and brade: Last week: - Finished #31768 (Introduce Tor network settings and other updates in TB9 onboarding). - Finished #31910 (replace meek_lite with meek in circuit display) - Created #31984 (unable to remove directory: tobedeleted) - based on blog comment https://blog.torproject.org/comment/284256#comment-284256 - Prepared for and participated in Sponsor 27 meeting r.e. onion service errors vs. SOCKS optimistic data. This week: - Open a Mozilla bug for #31547 (Back out or modify patches for Mozilla's bug 1574980). [done] - Open a Mozilla bug for #31955 (macOS: avoid throwing inside nonBrowserWindowStartup()). [done] - Investigate #31984 (unable to remove directory: tobedeleted) - Investigate #32039 (Tor Browser 8.5.5 is not working on macOS 10.15 after being freshly installed). - Investigate #32055 (Importing bookmarks from Safari doesn't work). - Help with other tbb-9.0-must tickets as time permits. - Attend Sponsor 27 meeting. - Record Actual Points in our completed tickets.
acat: Last week: - Finish #31778: Support default dark-theme for the Circuit Display UI. - #13543: HTML5 media support may lead to fingerprinting - #31602: Remove Pocket indicators in UI and disable it by default - Review #31286. This week: - #31740: Review RemoteSettings usages in esr68 - Revert aarch64 torbutton fixup (#31730 ) - Investigate/think about #13543 spoofing values. - Help with tbb-9.0-must tickets - Revise https://bugzilla.mozilla.org/show_bug.cgi?id=1581537. [Browser UI locale is leaked in several ways]
pospeselr: Last week: finished candidate patch for #31268 tried to build the build2 candidate over the weekend, ran into several issues
- some gradle weirdness (that went away after a restart)
- can't build snowflake because the commit used in the config doesn't exist anymore due to branch merges [boklm: could you open a ticket for this issue? pospeselr: created #32066]
This week: #31268 review changes misc bug fixes ( #31920, #31749, #31748) Mozilla #1561912
boklm: Last week: - Made patches for: - #31968 (Use sudo if /proc/cpuinfo isn't readable in the start-tor-browser script) - #32018 (Remove unicode Character 'NO-BREAK SPACE' (U+00A0) from fp-central/run.py) - Worked on #32014 (Fix fpcentral after update to buster) - Helped build new alpha release - Looked at reproducibility issues (#32052 and #32053) - Reviewed #29013 (Provide stack smashing protection for mingw-clang builds) This week: - Investigate reproducibility issues (#32052 and #32053) and try to fix them - Help publish new alpha release - Try to fix fpcentral (#32014), and related fpcentral tickets (#31987 and #31986) - Review #30334 (build_go_lib for executables) - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets
sisbell: Last Week: - 30460: TOPL dependency list - fixed/merged - 31981: remove deprecated patch from tor-android-service: fixed/merged - 31568: Updated gradle how to - fixed/merged - 30665: Firefox ESR 68 working - fixed/merged This week: - 32043: tor-android-service: repo fix --------------------------------
- Matt
Hello!
We held our weekly Tor Browser meeting today in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-10-21-17.30.lo...
1) We are releasing Tor Browser 9.0 and Tor Browser 9.5a1 this week! These are both based on Firefox 68.2.0esr.
2) We'll be tracking issues in Tor Browser 9.0 on trac with the keyword tbb-9.0-issues [0].
[0] https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~...
3) Last week, with ticket #28709, we tried enabling FuzzyFox [1], but we found it has problems in Tor Browser. At the meeting, we briefly discussed whether investigating this should happen this week, and we decided we'll delay this until after the upcoming releases.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1432429
4) We'll be changing our triaging process in two weeks and introducing a multi-round, multi-level triage process. We'll begin every day by triaging new tickets. The first round will be around Europe's morning, and the second round will be around Americas morning. We'll begin using a new trac keyword for indicating a ticket needs a deeper review before it can be assigned.
5) We discussed upcoming tickets for the remainder of the year. They are mostly scheduled for November (keyword TorBrowserTeam201911), but some will eventually move to December. 6) Lastly, we discussed changing the team meeting time due to "northern"-hemisphere Daylight Savings timing endings. Parts of Europe change this coming weekend, and parts of North America change their time the following weekend. We decided our next meeting (28 October) will be at 17:30 UTC and the meetings after that will be at 18:30 UTC (until further notice).
=============================== Week of October 21, 2019 Discussion: Releases Browser Tasks and Experiences New ticket triaging process upcoming work (next two months) upcoming meetings and daylight savings time (brade)
sysrqb: Last week: Reviewed acat's #31730 patch Fixed up proxy-bypass patches for #31144 Resolved conflicts of rebasing onto 68.2.0 #32097 Began investigating fuzzyfox problems This week: Releases Finish external app proxy-bypass notification #26529 Ticket reviews Bug fixes Fuzzyfox
boklm: Last week: - Helped publish 9.0a8 - Helped build the new releases and made draft blog post for 9.0 - Investigated reproducibility issues (#32052 and #32053) This week: - Help with publishing new releases - Investigate reproducibility issues (#32052 and #32053) and try to fix them - Try to fix fpcentral (#32014), and related fpcentral tickets (#31987 and #31986) - Review #30334 (build_go_lib for executables) - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets
GeKo: This week - help with OTF proposal (yay, we got it submitted) - work on #32053 (macOS reproducibility issues) - release prep for 9.0 and 9.5a1 - a ton of reviews - work on #32053 Next week - help with releases - work on #32053 (macOS reproducibility issues) - loose esr68 transition ends - help with tbb-9.0-issues
mcs and brade: Last week: - Opened Mozilla bugs for: - #31547 (Back out or modify patches for Mozilla's bug 1574980). - #31955 (macOS: avoid throwing inside nonBrowserWindowStartup() - Investigated #32039 (Tor Browser 8.5.5 is not working on macOS 10.15 after being freshly installed). - Investigated #32055 (Importing bookmarks from Safari doesn't work). - Worked on #27604 (bundle relocation is broken). - Filed and fixed #32154 (Tor Launcher's custom bridge field only allows one line of input). - Provided some UX feedback for #30783 (End of Year Fundraising Campaign Banner). This week/upcoming: - Record Actual Points in our completed tickets (done). - Get back into Sponsor 27 work: #30237 (v3 onion services client auth). - Maybe #32119 (onboarding for "Goodbye Onion Button" could be better). - waiting on UX input. - We will be afk Thursday and Friday this week; sorry for the short notice.
acat: Last week: - Revert aarch64 torbutton fixup (#31730 ) - Investigate/think about #13543 spoofing values. - #31740: Review RemoteSettings usages in esr68 - https://trac.torproject.org/projects/tor/ticket/32092 - Reviewed #22919 - Worked on #28745: THE Torbutton clean-up This week: - Finish #28745 - tor#30783: End of Year Fundraising Campaign Banner - [new] - https://bugs.torproject.org/30783%0F - #27604: Relocating the Tor Browser directory is broken with Tor Browser 8 - #31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68 - Revise https://bugzilla.mozilla.org/show_bug.cgi?id=1581537. [Browser UI locale is leaked in several ways]
Jeremy Rand: Last week: - Several stream isolation patches are now merged to ncdns, ncprop279, and ncdns-repro. - As expected, was a less productive week than usual due to time spent on the scheduled softfork (which is now finished -- softfork was successful). This week: - Continue working on #19859, assuming my current patches get more feedback. Might start porting my spec patches to implementation even if no feedback on spec is immediately received.
antonela: - i've been thinking in a way to share our alpha builds with users for pre-testing and i discovered tor-qa. Geko: is ok if we promote tor-qa for early bird users? who is on that list? > we are building this https://community.torproject.org/user-research/ [GeKo: yes, that would be an option. I don't know who is on that list (but I could look :); it's been quite as of late] - Tor Browser 9 release, doing what is needed: screenshots, reviews, documentation, etc
pospeselr: Last week: - fixed various little bugs relating to #31286 - fixed #32125 (circuit display doesn't work with user-provided bridges without a fingerprint ) - wireshark proxy bypass investigation This week: - tbb-9.0-issues: #32164 - tor log viewer #31803 - icon #31764 - broken paste and go
sisbell: Last Week: - #30501: BridgeList an overloaded field (in review) - #30767: Custom obfs4 bridge does not work for custom bridges (in review) - #30518: Missing command line options (merged/fixed) - #30324: Adapt Android toolchain (fixed) - #30461: Removed patches for tor-android-service (merged/fixed) This week: - 30552 - Cleanup of torrc - 31130 - Android tor Debian ===============================
Have a good week everyone! Matt
Hello!
We held our weekly Tor Browser meeting on Monday in #tor-meeting2. Here is the IRC log: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-10-28-17.30.lo...
First, we successfully released Tor Browser 9.0! It was a significant achievement with the last few months being full of getting Tor Browser stabilized based on Firefox 68esr. Congrats and many thanks to everyone involved in this!
Unfortunately, there isn't much time to waste. We're working on bug fixes this week, as well as implementing the end-of-year campaign in the browser. The next point release is scheduled at the beginning of next week which should include these updates.
From the 9.0 release, we received significant feedback on the new
Letterboxing feature. It was recognized this feature wasn't introduced as well as it should be, and the new margins are both concerning and confusing. We're planning on addressing these issues over the next few releases.
In the meeting, we discussed a situation affecting some Windows users where Tor Browser won't run on an older version of Windows due to a missing library (ucrt). This library is available for installation via Windows updates on most older (supported) Windows versions, but some computers still do not have it installed. Mozilla work around this issue by bundling the library in their builds. We do not currently bundle the library, and we don't know how many users are affected by this. This is being tracked on https://trac.torproject.org/projects/tor/ticket/32327.
Another question was asked about providing access to the cookie behavior configuration in about:preferences. This UI is now controlled by Firefox's Enhanced Tracking Protection (ETP) feature, and the setting UI disappeared when Tor Browser disabled ETP. There are tradeoffs with providing an easy configuration UI for this. This is being tracked on https://trac.torproject.org/projects/tor/ticket/32330.
Meeting Notes: ============================== Week of October 28, 2019 Discussions: Git admins (git{,web,-rw}.torproject.org) Tor Browser 9.0 post-mortem Upcoming releases S27 Work YE Campaign - about:tor page
Jeremy Rand: Last week: - #19859 is believed to be in a complete state (both spec and Tor daemon code). Feedback from Nick is addressed, including adding a unit test. Planning to test that patch for a bit in conjunction with other Namecoin ecosystem stream isolation patches before asking for a merge. - Started implementing stream isolation in StemNS. It's now feature-complete but needs some more testing before a merge. - Implemented and merged patches to ncbtcjson, ncrpcclient, ncdns, and ncprop279 for using a current fork of btcd's RPC client library instead of the ancient 2015-era fork we had been using. This was a prerequisite to getting stream isolation plumbed from ncprop279 to Electrum-NMC. We're still engaging with btcd devs on getting patches merged so that we can abandon that fork completely and use upstream directly. - Implemented and merged patches to ncbtcjson, ncrpcclient, ncdns to pass through stream isolation data to Electrum-NMC. (ncprop279 didn't need any additional patches.) This week: - Minor patch for Electrum-NMC's JSON-RPC server to handle stream isolation in a way that ncrpcclient can convey (it's so nice when one library serializes the arguments in a JSON array while another library deserializes them from a JSON object...). - Finish testing stream isolation with Namecoin. - Ask Nick to review #19859 again once the above testing is complete. - Maybe do some auditing for proxy leaks. - Maybe do some auditing for build reproducibility. - Running out of TODOs; that's a good sign I guess.
mcs and brade: Last week: - Added Actual Points to our completed tickets. - Fixed #32184 (red dot during mar download). - Helped with triage for #32212 (Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on Debian stretch). - Commented in #21542 (use Subprocess.jsm to launch tor). - We were afk Thursday and Friday. This week/upcoming: - Sponsor 27 work: #30237 (v3 onion services client auth). - Maybe #32119 (onboarding for "Goodbye Onion Button" could be better). - waiting on UX input.
GeKo: Last week: - helped with releases; tb9 is out and not exploding yet, yay! - Spent a lot of my time on our blog and other support channels - tbb-9.0-issues (https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~... ) and tbb-9.0.1-can (https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~... ) - unaddressed issues yet - ucrt support on Windows < 10 (missing dlls on some computers; should we actually bundle them? No.) - what about our general cookie setting UI being hidden now? - made progress on tracking down reproducible builds issue on macOS (#32053); now slowly bisecting rust versions - thought about OTF proposal feedback - wrote small patch for our signature checks (#32284) - struggling with closing/finishing remaining esr68 transition issues - reviews (#30783, #31658, #32210, #32188, #32164, #31803, #31764, #32169, #32184) - how do we want to proceed with our mozconfig files in tor-browser (re: #32116)? (let's talk about it next week) This week: - finish more esr68 transition items (#31591, #30429, #31010) - make progress on review of all bugs closed between esr60 and esr68 (#31597) - prepare 9.0.1 and 9.5a2 (pospeselr: can you help building them?) - more work on #32053 - reviews
Pili: Last week: - Mozfest This week - Helped publish the new releases: - More Browser proposal revisions after sponsor review - Reviewing workload and roadmap for November - Catching up from Mozfest - AFK on Friday due to public holiday
tjr - We've updated to clang 9 on -central, I am (slowly, occasionally) working on that for the mingw builds. - Ethan said there is not timeframe for when uplift may resume.
sysrqb: Last week: 9.0 and 9.5a1 releases for Android Code review (#30501, #30518) Opened some tickets for bugs in 9.0 (#32214, #32243, #32303) Investigated a couple of the bugs (#32238, #32303) This week: Created a useful https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser page Fix some bugs: at least obfsproxy on Android Q (#32303) More on the OTF proposal Code reviews Pick up a tbb-9.0-issues ticket
boklm: Last week: - Helped publish the new releases - Fixed some website tickets (#32222, #32223, #32201) - Continued investigating reproducibility issues (#32052 and #32053) - Reviewed #32284 (No need to save all bundles for mar-signing and authenticode-signing check until we are done) - Reviewed #31130 (Use Debian 10 for our Android container images) - Looked at patch for #30334 (build_go_lib for executables) and saw that it needs changes to be rebased on master This week: - Continue investigating reproducibility issues (#32052 and #32053) - Try to rebase patch for #30334 (build_go_lib for executables) - Try to fix fpcentral (#32014), and related fpcentral tickets (#31987 and #31986) - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets
sisbell: Last Week: -#30552: Android- cleanup torc (in review) - removed transparent proxy fields used by orbot and various default field values - #31130 - Android tor Debian - tried a number of approaches, narrowed down right one, defined dependencies needed - #31922 - ApkTool - some investigation This week: - Reviewing and commenting on new TorService code (and VPN cleanup) by eight have - #30501: BridgeList an overloaded field - respond to review/make changes - #31130 - Android tor Debian - expect to have something ready for review by 10/28 -#30842 - Some more emulator testing (fennec as baseline) - Does esr68 work correctly on JellyBean arm devices? - #31922 - ApkTool, I think I have a solution for getting correct version (I can use similar approach as using for openjdk download)
pospeselr: Last Week: - a bunch of small tbb-9.0-issues fixes - filed https://bugzilla.mozilla.org/show_bug.cgi?id=1590538 (broken paste and go)
- mozilla posted a patch that's under review now that's slightly different from my fix
- filed https://bugzilla.mozilla.org/show_bug.cgi?id=1591259 (NS_ERROR_NOT_AVAILABLE thrown on launch)
- no response yet, but not a regression in Tor Browser, its broken in latest Firefox
- figured out problem with my office/build machine (tor-browser-build/tmp not getting cleaned up, filed #32272 to track)
This Week:
- ?
acat: Last week: - Rebased #28745 - Revise https://bugzilla.mozilla.org/show_bug.cgi?id=1581537. [Browser UI locale is leaked in several ways] - tor#30783: End of Year Fundraising Campaign Banner - [new] - https://bugs.torproject.org/30783 - Worked on #27604: Relocating the Tor Browser directory is broken with Tor Browser 8 This week: - Finish fixing #27604: Relocating the Tor Browser directory is broken with Tor Browser 8 - #32255: Missing ORIGIN header breaks CORS in Tor Browser 9.0 - Revise (hopefully last one) https://bugzilla.mozilla.org/show_bug.cgi?id=1581537. [Browser UI locale is leaked in several ways]
antonela - Filed #32324 - Introduce Letterboxing to users - Filed #32325 - Allow Letterboxing opt-in/out ==============================
- Matt
Hello!
It seems I didn't sent this last week. Here are the meeting notes from last Monday's meeting: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-11-04-18.29.lo...
During the meeting we mostly discussed our priorities for November.
Below are the notes from our meeting pad:
Discussions: Status of 68esr rebasing tickets - #30429 and #31010 (GeKo: we are close at least for #30429; I wanted to have a last look over them before closing but am distracted by other work :( #30429 at least should get done this week, though)) Do we need #31650 (pre-crunch and pre-strip PNG in tor-service-android to make it reproducible)?
sysrqb: Last week: Release prep Fixed locale-selector crash #32343 (boklm, thanks for providing a better patch) obfs4proxy incompatibility with Android O (#32303) Reviewed torrc cleanup on Android #30552 Reviewed BridgesList Preferences is an overloaded field #30501 Tweaked EOY campaign patch for mobile #30783 This week: 9.0.1/9.5a2 Releases Finish patch for #32303 Follow up on #31915 patch uplift OTF proposal Fastlane support #26844
pospeselr: Last week: - #32220 prototyping (letter-boxing white borders) - working on patch which adds a border around the page content, and sets the margin to the color of the chrome background to indicate the margin is not part of the content (and varies with theme) - 9.0.1 build This week: - finish up #32220, one remaining outstanding issue: newly created windows do not have enough space to fit the browser element without letter-boxing - start work on exposing an option in about:preferences to toggle letter-boxing (#32325) - investigate #32308 (letter-boxing jiggling on window resize)
Jeremy Rand: Last week: - #19859: Ready for review. - Stream isolation with Namecoin now fully works across the full stack. - Audited Electrum-NMC for proxy leaks; no leaks were detected. - Not surprising, since Electrum is used in Tails and Whonix, so presumably they would have noticed already if there were proxy leaks. - I also open-sourced my proxy leak detector that I originally wrote for my master's thesis 2 years ago; I'll probably post a link on the tor-dev mailing list since it might be interesting for the Tor community. https://github.com/JeremyRand/heteronculous This week: - Main thing left on my end: clean up Git history of Electrum-NMC stable 3.3.8 branch, tag an Electrum-NMC nc3.3.8 release, make tor-browser-build use that Electrum-NMC tag. - Remaining things that might be worth doing (which of these, if any, are blockers for merging Namecoin support to nightly with Namecoin disabled by default?): - Properly handle some AuxPoW edge cases - These edge cases mainly fall into the category "Someone with large amounts of hashrate might be able to make 1 block appear as 2 blocks, until someone else mines a block on top of the real one", and similar attacks that are highly expensive and accomplish virtually nothing attack-wise. Obviously worth fixing, but IMHO it's not something that warrants blocking a nightly merge. - Disable punycode/IDN's in the .bit TLD to prevent homograph attacks - In the DNS world, registries are supposed to prevent homograph registrations; Namecoin treats registrations as binary blobs without regard to Unicode, so Namecoin can't easily prevent homographs. Long-term we should try to find a safe way to allow IDN's, but short-term we should just disable punycode/IDN's from being looked up in ncdns. IMHO disabling punycode/IDN's isn't worth blocking a nightly merge, since it only affects users who have opted into Namecoin by both enabling Namecoin via env var and navigated to a .bit site in the URL bar. - Stop hardcoding username/password/port for Electrum-NMC RPC interface, use random instead - Main reason why Electrum-NMC password-protects the RPC interface is to prevent theft of coins/names. But the Electrum-NMC instance in Tor Browser doesn't have the wallet enabled, so this is mostly a moot point. Accessing the RPC interface *would* allow opening connections with arbitrary stream isolation data... but that's also true of the Tor SOCKS port, which is unauthenticated. AFAIK Tor Browser doesn't allow websites to access localhost via AJAX and similar stuff, so this seems like a pretty minimal attack risk. So IMHO it's not worth blocking a nightly merge. Long-term we should definitely switch to cookie authentication for the Electrum-NMC RPC port. - Audit build reproducibility - In theory everything should be reproducible (it all builds in rbm and I've tried to follow best practices for rbm usage), but there may be issues since I haven't carefully tested for reproducibility (e.g. I've filed a few Go-related reproducibility bugs on Trac that might or might not affect things here). Is audited reproducibility considered a blocker for nightly, or just for alpha/stable? (I have no idea what the policies are for this; I'll follow whatever policies you have in this area.)
mcs and brade: Last week: - Sponsor 27 work: #30237 (v3 onion services client auth). - rebased patches for ESR68/Tor Browser 9. - worked on loose ends. - Reviewed some patches. This week/upcoming: - #30237 (v3 onion services client auth). - Provide updated biographical info to Al for use in proposals.
acat: Last week: - Finish fixing #27604: Relocating the Tor Browser directory is broken with Tor Browser 8 - Landed https://bugzilla.mozilla.org/show_bug.cgi?id=1581537. [Browser UI locale is leaked in several ways] - Checked #32255: Missing ORIGIN header breaks CORS in Tor Browser 9.0 This week: - #23719: Make sure WebExtensions are spared from JIT disabling in higher security settings (Medium-High) - #21952 - Onion-location: increasing the use of onion services through automatic redirects and aliasing - send updated resume to Al for OTF proposal.
tjr: - Working on bumping to clang-9 in -central. - clang-10-trunk just had CFG support land, maybe worth investigating bumping to that
sisbell: Last Week: -#30552/#30501/30767: Made changes to TOPL code based in feedback, various code changes to improve readability, additional unit tests, bug fixes - #31130 - Android tor Debian - solved the Java installation issue which was main barrier to completion, Next will upgrade https-everywhere to buster - #31922 - ApkTool - made changes to config (will be able to test once I complete #31130) This week:’ - #31130: Upgrade https-everywhere to buster and then test final apk - #31922: ApkTool test using Debian version - #30501: Code integration changes to tor-android-service, migration code for different fields
pili: Last week: - Catching up from MozFest - Browser proposal for transition away from ESRs - end of month admin and roadmap gardening This week: - Sponsor 44 report - Start of month roadmap planning
GeKo: Last week - release prep - reviews (#27309, #32342, #32184, #27604, #32188, #30783, #32220, #28745) - small patches for the release (mainly backports): #32321, #32318, #32250 - work on #27268 (while reviewing #28745) - #32053 (macOS reproducibility issue); made small steps in the right direction but we are still not there :( This week: - #32053 - #31597 - finish #30429 - look at/finish #31010 - work on setting up the Android signing (token)
boklm: Last week: - helped with building new releases - Continued investigating reproducibility issues (#32052 and #32053) - Helped with fix for #32342 - Rebased patch for #30334 (build_go_lib for executables) This week: - Help with publishing of new releases - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets - Test/review rebased patch for #30334 (build_go_lib for executables)
- Matt
Hello!
Last Tuesday we held our weekly Tor Browser Team meeting (we rescheduled it from Monday due to a bank holiday in the US).
Here are the meeting notes: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-11-12-18.34.lo...
Most the the meeting was spent discussing our triaging processes. We also (temporarily) moved our meeting pad onto pad.riseup.net until nc (nextcloud) is a viable alternative.
Weekly updates:
==========================================
Week of November 12, 2019
Discussion: What do we triage and how do we triage? Mailing list management What do we need to do to migrate this pad away from Storm? (mcs)
GeKo: Last week: -struggled with the alpha release -I tried my luck with a workaround for #32053 but that failed -Spent a lot of time on OTF proposal -Still looking into reproducibility issue (#32053) by currently bisecting LLVM, but getting closer thanks to the help of Alex Crichton and LLVM devs -backported fix for Mozilla's 1591259 (#31573) -reviews (#28803, #32303, #32413, #32220, #30683 (backport of Mozilla's fix for 1581537), #30558, some pieces of #28745, #32365) -work on #31597 (still not finished) -I spent some of my spare time to start getting RLBox integrated in our build process (#32379 is the parent ticket) This week: -Help with OTF proposal if needed -Hopefully having a working fix for #32053 up for review -reviews -#31597 -make progress on remaining bits for #30429 and #31010 -work on our signing infrastructure (#31161 for Android, #32173 for macOS) -start with Tor Browser design doc update (sysrqb: let me know how you think we should work on that one together) -more RLBox work in spare time
mcs and brade: Last week: - Provided updated biographical info to Al for use in proposals. - Sponsor 27 work: #30237 (v3 onion services client auth). - Worked on loose ends including an improved error indicator and localization support. - Spent a little time on #32394 (Update Progress Bar doesn't use translations). This week/upcoming: - #30237 (v3 onion services client auth). - Tie up loose ends. - Post a patch for review (planned for today or tomorrow). - Think about permanent storage or client auth keys and associated management UI. - Maybe this work can be done under #19757 (Make a menu to add onion and auth-cookie to TB). - Respond in #32418 (up-to-date Torbrowser notifies that it can't update).
pili: Last week: - Roadmapping - OTF Browser Proposal This week: - Looking at past team capacity to try to figure out some patterns - S44 report
sysrqb: Last week: Releases (hopefully) resolved obfs4proxy issue on Android Q in 9.5a2 (#32303) Worked a little on OTF proposal Didn't follow up on #31915 upflift or fastlane Mostly reviewed #30501 revisions Investigated localization broken on Android (#32365) This week: Fastly event talking about Tor Browser Finish #32365 Finish #30501 review Clean up android signing key documentation Catch up on Onion-Location status Follow up on uplift #31915 AFK some of Wednesday and some of Thursday
boklm: Last week: - Helped with building/publishing releases, and followed comments on blog posts - Some reviews - Made patch for #25099 (Update nightly version number) - Started looking at #25101 (Generate incremental mar files for nightly builds) This week: - Will be afk tomorrow (Wednesday) - Work on #18867 (Ship auto-updates for Tor Browser nightly channel) and sub-tickets - Test/review rebased patch for #30334 (build_go_lib for executables)
Jeremy Rand Last week: - Cleaned up Electrum-NMC 3.3.8 Git history. - Tagged Electrum-NMC 3.3.8. - Submitted patch for #30558; ready for review. - Addressed Nick's latest feedback on #19859. This week: - Address whatever review happens on #30558 and #19859.
pospeselr: Last week: - finished up #32220 (letter boxing UX improvements) - #30570 investigation (per-site settings)
acat: Last week: - Investigated perf. issue with #23719 (Make sure WebExtensions are spared from JIT ...) - Ported #30683 firefox patch (dom/locales/$lang/chrome/ allow detecting user locale) - Worked on #21952 - Onion-location: increasing the use of onion services through automatic redirects and aliasing - sent updated resume to Al for OTF proposal. This week: - Continue working on #21952. - Check #32255 (Missing ORIGIN header breaks CORS in Tor Browser 9.0) and take some action (not sure exactly which one) - Revise #28745: THE Torbutton clean-up - Follow up #32297 (try to reproduce with new info from reporter)
sisbell: Last Week: - Put together package diagram of TOPL/tor-android-service classes and how they are integrated. Defined integration areas we need to look at with Orbot/Tor Browser. Sent email to guardian project to open discussion. - #31130 - fixes for checksum and fixes for https-everywhere (in review) - #30501 - made changes to settings to handle sets of properties like bridge lists, addresses rather than flat lines. Made changes to tor-android-service to make it compile time compatible with TOPL This Week: - #30501/torrc changes... - more clearly specify ticket issues, will have new review ready by end of day - Follow up with guardian project for plans moving forward
==========================================
- Matt
Hello!
We held our weekly Tor Browser Team meeting on Monday. Here are the meeting logs: http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-11-18-18.29.lo...
During the meeting we briefly discussed on-going work for making onion services more usable.
Next, we briefly talked about some Android-related work. We have a useful collection of libraries now, but they may not be the best solution, especially as some of our partners in this space are actively developing different solutions. We will have more discussions in the future about how Tor development on Android (and mobile, in general) should continue.
Finally, an idea was proposed of creating a Tor Browser build that makes troubleshooting network connectivity problems earlier. Ticket #32540 was created for this.
Weekly notes:
==================================== Week of November 18, 2019 Discussion: What is the status of our testing suite? (test-reports.tbb.tpo? Are the tests run automatically anywhere and are the results publicly available?)
GeKo:
Last week:
- Help with OTF proposal
- Still banging my head against #32053 :(
- reviews (#30327, #31130, #32508)
- #31597 (closed Mozilla bugs between esr60-esr68)
- worked on the signing infrastructure for macOS #32173
- went over all our signing related tickets and tagged them with `tbb-sign` (https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~...)
- more RLBox work (wrote patches for #32436 and #32437 over the weekend)
- wrote small patch for #32509
- a bit thinking about the design doc update
- HackerOne house-keeping and triage
This week:
- more work on #31597
- more work on #32053
- more work on #32173
- design doc update
- reviews
- more RLBox work in my spare time
mcs and brade: Last week: - Sponsor 27 work: #30237 (v3 onion services client auth). - Tied up loose ends. - Posted patches for review and revised them based on feedback from Richard. - Spent a little time on #10416/#29020 (Tor won't start on Windows when path contains non-ascii characters). - Commented in #32498 (Consider updating MAR_CHANNEL_ID for nightly build). This week/upcoming: - For #19757, think about permanent storage of client auth keys and associated management UI. - Respond in #32418 (up-to-date Torbrowser notifies that it can't update). - Add actual points to completed tickets.
Pili: Last week: - OTF Browser Proposal - S44 Final report - Trac triage - Tor Browser Release meeting - S27 meeting - Tor Browser October report - General roadmap admin This week: - OTF Browser Proposal - S44 final report - Trac triage
Jeremy Rand: Last week: - Addressed review of #30558. - Addressed review of #19859. - Filed #32520. - Debugged #31691 a bit. - Filed #32523. - Filed #32527. This week: - Address whatever review happens on #30558 and #19859.
sysrqb: Last week: Some work on the OTF proposal Fastly event Ticket triage Ticket assignments Misc Tor Browser things This week: More OTF proposal More ticket triage and assignments Write summary of Fastly event and thoughts about onion services
acat: Last week: - Revised #28745: THE Torbutton clean-up - Worked on #21952 (Onion-location: increasing the use of onion services through automatic redirects and aliasing): - Exposed in about:preferences - Implemented automatic redirects as with "Location" header. - Basic visual feedback when redirect ("manual" or automatic) to .onion has happened This week: - Wrap up work on #21952, and do builds so that it can be tested. - Check #32255 (Missing ORIGIN header breaks CORS in Tor Browser 9.0) and take some action (not sure exactly which one) - Follow up #32297 (try to reproduce with new info from reporter)
boklm: Last week: - Updated patch for #25099 (Update nightly version number) - Worked on patch for #25101 (Generate incremental mar files for nightly builds) - Some reviews - Looked at blog comments This week: - Finish patch for #25101 (Generate incremental mar files for nightly builds) - Generate a mar signing key for nightly builds (#31988) - Make patch for #32475 (Reduce the number of locales we provide updates for in nightly) - Test/review rebased patch for #30334 (build_go_lib for executables)
sisbell: Last Week: - #Broke apart #30501 issues. These are (will be) broken into changes 1) No API changes; 2) API changes but easy conversions to Android shared pref format; 3) Breaking API changes and changes needed to underlying shared prefs (with data migration needed). (1) issues are #30767, #32516; (2) #32501, #32518 + more this week; (3) #30501 - BridgeList + sets for enumerations of addresses - #30767 - TOPL Custom obfs4 bridge does not work work for Android - Recreated isolated commit (in review) - #32516 - TOPL Cleanup write methods. Various cleanup to simplify writing of torrc fields. - #32501 dormant canceled field - previous patch broke tor-android-service: I added a couple of commits to bring these changes into tor-android-service and TOPL. We should be able to remove patches in browser build after this. - #32476 More investigation into JNI. Open question if this supports Desktop platforms or whether changes are Android specific only. This Week: - Define and work on issues for (2) API breaking changes and (3) if time - Follow up with guardian project to define more specific plans - Prototype with JNI - #31992 apktool workaround - Would like to do MR for #30767, #32516, #32501 to TOPL project this week
pospeselr: Last Week: - US holiday on monday - reviewed #30237 (mcs/brade onion service auth) - deep dive into NoScript for #30570 (per-site settings) - fixed about:preferences#tor UX bug #32508 This Week: - hmm see why the fix for #32508 isn't working as expected - investigating feasibility of adding first-party isolation double-keying to NoScript, prototype Next Week: - Holiday travelling from the 24th through the 6th with limited/unpredictable availability Next Month: - Moving cross-country sometime in the middle of December also with limited/unpredictable availability ====================================
Have a good week, Matt
Hello everyone!
Two weeks ago we held our weekly Tor Browser Team meeting. The notes are available http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-11-25-18.31.lo...
That was a short week for many people because the U.S. celebrated a bank holiday on Thursday and Friday. We prepared for two upcoming releases, 9.0.2 (stable) and 9.5a3 (alpha).
During the meeting we discussed three main topic, plus set last-minute goals for fixing bugs in the releases.
The discussions were: 1) Should Tor Browser provide a preference for disabling updates? The question was asked because in older version of Tor Browser (and Firefox), there existed a preference for this, but Mozilla removed. We decided there exist some preferences which may be used for this purpose, and we will test and document how these prefs should be set as a solution. If the tests fail, then we will consider implementing a new pref for this, but we prefer not going that route.
2) Can Tor Browser enable the JIT in privileged code, when the JIT is disabled for content? We experimented with enabling WebAssembly for webextensions when it is not allowed in content scripts, however there still exists a performance problem because the JIT is still disabled. We'll work with Mozilla on finding a solution for enabling the JIT, as well, in privileged contexts when the JIT is disabled in the content.
3) We discussed two upcoming UI changes within Tor Browser related to website redirection from a registered domain to an onion address.
=================================================================== Discussion: - upcoming releases (are we good? last minute things we want to get into? who will build the releases?) - ticket assignments for everyone
pospeselr (afk this meeting):
Last week:
- updated uplift patch for Mozilla 159445 (letterboxing UX improvements)
- fixes for #32359 and #32508 (security level UX stuff)
- flu!
- #30570 investigation/protoyping
- pinged NoScript's Giorgo via email to get his opinion on how we can make this+NoScript play nicely together
This week:
- more flu!
- holiday travel through Dec 6th, intermittent online availability this week, better availabiilty next
- #30570
- antonela: we should chat this week and get an idea of what the UX we want to do here looks like (the technical/backend side of things are looking a bit scary :p )
mcs and brade: Last week: - Sponsor 27 work: #19757 (permanent storage of client auth keys and associated management UI). - The Network Team is working on #32562 for us (Allow ONION_CLIENT_AUTH_ADD credentials to be made permanent). - Commented in #31506 (Write up comprehensive advice to "Tor unexpectedly exited"). - Commented in #32327 (apt-win-crt*dll files are missing on some Windows 8 and Windows 7 systems). - Investigated #32418 (Torbrowser tells on every start, that it can't update although it is newest). Should we provide a pref to disable updates, like Tor Browser and Firefox had previously? This week/upcoming: - More work on #19757 (permanent storage of client auth keys and associated management UI). - Review #32498 (MAR_CHANNEL_ID for nightly builds). - Add actual points to completed tickets. - Out of the office most of Wednesday-Friday this week (U.S. Thanksgiving holiday).
GeKo: Last week: - help with the OTF proposal (I believe we submitted what I believe to be a better proposal in time, thanks to everyone who helped) - #32053 (I tried to fix this bug by another workaround but that failed :( I asked on the LLVM bug whether that could give us at least some clue) - #31597 (Go over all closed bugs/bugs where patches landed between Firefox 61 and 68) - #25021 (design doc update; I revisited all Release notes between 7.0 and 9.0 and noted down all tickets potentially affecting the design doc; now the next step is to take the text and match that to those bugs and update it where needed, discarding the tickets not needed) - wrote small patches for #30548 (cleaning up our tor-browser-build keyring file), #30786 (add th locale), #30787 (add lt locale), and #32531 (Mozilla backport of a patch) - reviews (#30548, #30888, #28745, #32255, #32497, first stab at #30558, #32475, another round for #31130) - made good progress over the weekend on RLBox work; I am close to what Mozilla is currently having ready This week: - more work on #32053, #31597, and #25021 - provide patches for ms inclusion as well (#30788) - reviews - release prep - work on apple signing infrastructure update (#32173 + #32556) - potentially more RLBox investigation in my spare time
tjr
- Did something, yay! But still very time-limited, so please proactively ping me if you have questions or would like me to see something and possibly provide input
- Got -central updated to clang-9: https://bugzilla.mozilla.org/show_bug.cgi?id=1590624
This included an stl-wrapper fix that affects esr68, but apparently doesn't cause problems? Maybe? [GeKo: How would problems look like? So far, I don't know of a bug we've heard of that would match a potential issue here. But maybe I just don't understand stl-wrappers good enough. However, we maybe might want to backport that fix for the alpha to test it and be able to quickly use it for stable, too, in case there *is* actually an issue we should fix/be concerned about.] [tjr: I have zero idea. Mine manifested as a compilation error.]
clang-9 is desirable because it's one step closer to clang-10, which includes support for Control Flow Guard (on Windows)
- My next task is to work on a backlog of #ifndef __MINGW32__'s that have gone into -central because mingw-w64 headers are missing stuff
- In not-tor work, I have developed a google sheets <-> Bugzilla syncing script that allows (what I think is) a better dashboard of bugs and easy, notes of the status of bugs. If such a thing would be useful to you, LMK
- Apparently the next ESR is 78. Everything subject to change I presume.
Nightly Start: 5/4/2020 Beta Release: 6/1/2020 Release: 6/30/2020
Jeremy Rand: Last week: - Addressed Georg's feedback on #30558. - Nick merged #19859, so it's no longer blocking an eventual merge of #30558. This week: - Address whatever review happens on #30558. - @Georg, do you happen to have a (totally non-binding) guess on the probability of #30558 getting fully reviewed by end of 2019, assuming that I respond to review approximately as quickly as I've been doing so far? If it does get merged by then, there's a chance I'd be interested in doing a talk at the 36C3 Critical Decentralization Cluster stage about that work (I think that's the stage that the Tor Assembly will be using as well). It's fine if it's not fully reviewed by then; if so, I won't do the talk; I'm just trying to gauge things so that I can plan more effectively. [GeKo: I'll get it fully reviewed by then (hopefully this week and/or next week should be enough to get through all of the changes); however, I can't promise that the code will be merged by the end of the year as I don't know what I'll find. :)] [Jeremy: ok, sounds good. :)]
boklm: Last week: - Made patches for: - #32527 (rbm downloads 0B sig file if network drops; rejects sig on next run) - #32497 (Change nightly update channel to nightly) - #32475 (Reduce the number of locales we provide updates for in nightly) - #32498 (Update MAR_CHANNEL_ID for nightly) - Worked on patch for #25101 (Generate incremental mar files for nightly builds) - Reviewed #30548 (Clean up keyring files) - Blog triage This week: - Review #30786 (Ship Thai Tor Browser in alpha series) - Help with build of new releases - Finish patch for #25101 (Generate incremental mar files for nightly builds) - Generate a mar signing key for nightly builds (#31988) - Work on #25102 (Add script to sign nightly build mar files) - Test/review rebased patch for #30334 (build_go_lib for executables) - Will be at Reproducible Builds summit the following week: https://reproducible-builds.org/events/Marrakesh2019/
pili: Last week: - trac triage - Ticket assignment meeting - Some work on S27 reports - Tor Browser presentation at https://womanlidertic.donesenxarxa.cat/es/programa2019/ - S9 report This week: - Mainly S9 report
sysrqb: Last week: - Mailing list, bug, blog triage - Code reviews - OTF proposal - Misc. meetings - Not much code written This week: - Release prep - Finish #32365 (localization is broken on Android)
acat: Last week: - Wrap up work on #21952, and do builds so that it can be tested. - #32255 (Missing ORIGIN header breaks CORS in Tor Browser 9.0): - Upstreamed: https://bugzilla.mozilla.org/show_bug.cgi?id=1598647 - Revised #28745: THE Torbutton clean-up - Tried to reproduce #32297 (unsuccessfully) This week: - Revise #21952 according to anto's review comments. - What should we do with #23719: Make sure WebExtensions are spared from JIT disabling in higher security settings (Medium-High)?
https://bugzilla.mozilla.org/show_bug.cgi?id=1599226
- #22919: Form tracking and OS fingerprinting (only Windows, but without Javascript)
Antonela
- I'm back from vacations
- per-site security settings: https://trac.torproject.org/projects/tor/ticket/30570#comment:12
- letterboxing: https://trac.torproject.org/projects/tor/ticket/32324#comment:7
- prioritize onions: https://trac.torproject.org/projects/tor/attachment/ticket/21952/21952%20-%2...
How should we treat the lock icon?
Is privacy&security the best place in about:preferences for general onion redirect opt-in?
- do we have S27 meeting this week? [yes]
sisbell: Last Week: - #31992 - ApkTool - located issue as aapt when processing resources
- #30676 Fixes for custom bridges in torch building - Created independent modules for tor-service/TOPL - #32476 TorService JNI, got up to speed on JNI and went through guardian project implementation This week: - #30501: BridgeList Preferences, move over previous work to new commit, these will be breaking changes - #32476: JNI - I have some more specific suggestions for implementation. Some work to see about creating a JNI layer independent of TorService (Something like TorEmbedded) - Adding unit tests for some topl components. - #31130: Buster support - just one small issue left on determining dependencies. Will have this done early in week for review. =======================================================
- Matt
Hello everyone,
Last Monday we held our weekly Tor Browser Team Meeting. The notes are available http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-12-02-18.29.lo...
We briefly talked about team/ticket maintenance, and we are looking at allocating funding for fixing bugs using the Bug Smashing funds we received in August (yay!).
We held a conversation about what purpose the .mozconfig* files within the tor-browser repository should have. We decided they should be useful/usable for developers now, and we may change how they are maintained in the future.
Finally we discussed a problem with localized Tor Browser installations, where the locale of the browser may leak to websites, therefore people who use locales that are not very popular may place themselves in small anonymity sets. Should we warn users about this before/after they download the browser? When and how should we do it? These are open questions, and we're still looking for some help answering them.
===========================================
Discussion: - Release - December ticket assignment and Reviewers - #32116 - #32602 (Consider what to do about locales used by very few people)
pospeselr: Last week: - US thanksgiving holiday travel fun - more flu! - 9.0.2-build2 build -> https://people.torproject.org/~richard/builds/9.0.2-build2/ - Mozila 1594455 uplifting progress (letterboxing improvements) https://bugzilla.mozilla.org/show_bug.cgi?id=1594455 - Prototype patch for #32325 (add option to disable letterboxing to about:preferences) - going to try and get this uplifted to firefox directly to avoid having to write two rather different patches to handle our disparate localization systems - screenshot: https://share.riseup.net/#Mgnlm4ZlDQO9mlUtGGZ5fg This week: - update #32116 patch with comments pointing devs to actual mozconfig's in tor-browser-build - submit #32325 patch to Mozilla - review/comment on #32645 (Update URL bar onion indicators) - nail down UX design on #30570
boklm: (might be afk during meeting) Last week: - Finished first part for #25101 (Generate incremental mar files for nightly builds) - Helped with build of new releases - Added test for #27265 (In some cases, rbm will download files in the wrong project directory) - Updated patch for #32475 (Reduce the number of locales we provide updates for in nightly) - Reviewed #31130 (Use Debian 10 for our Android container images) - Looked at blog comments This week: - Will be at Reproducible Builds summit the next 3 days - Help with publishing of the new releases - Work on: - #31988 (Generate a mar signing key for nightly builds) - #25102 (Add script to sign nightly build mar files) - Try to find some time to test rebased patch for #30334 (build_go_lib for executables)
GeKo: Last week:
- more work on #32053 (made good progress; a patch is hopefully ready later this week), #31597 (made good progress), and #25021 (made not so good progress :( )
- wrote patches for #32556, #32505, 32618
- reviews (#32616, #32498, #32255, #32475, #25101, #32365, #32606, #27265, #32527)
- release prep
- work on apple signing infrastructure update (#32173, #32556)
- more RLBox investigation in my spare time
This week: - #32053, #31597, #25021 - start with the BIG ticket triage - reviews - more RLBox work in spare time
mcs and brade: Last week: - Enjoyed some time off for the U.S. Thanksgiving holiday. - Sponsor 27 work: #19757 (permanent storage of client auth keys and associated management UI). - Code reviews: - #32498 (Update MAR_CHANNEL_ID for nightly build). - #32505 (Tighten our rules in our entitlements file for macOS). - Reviewed recent Mozilla updater changes and worked on #32616 (disable GetSecureOutputDirectoryPath() functionality). This week/upcoming: - More work on #19757 (permanent storage of client auth keys and associated management UI). - Code reviews.
Jeremy Rand: Last week: - Decided to be a subversive by not taking time off for Thanksgiving :) - Tested boklm's patch for #32527. - Debugged #32520 a bit, submitted a patch that doesn't need libfaketime. - Spent most of my dev time on non-Tor things while I'm waiting for more feedback to show up for #30558. This week: - Address whatever review happens on #30558. - @pili Would it be beneficial for me to attend S27-related meetings to provide a Namecoin perspective? If there's stuff happening there that's relevant, I'm happy to attend; if it's not going to be relevant; then that's fine too and I can save my time for other things. :)
sysrqb: Last week: Release prep and building Some ticket reviews This week: Releases Sending some overdue emails tor browser spec updates android signing key documentation
antonela - opened #32645 Update URL bar onion indicators - reviewed #21952 Onion location - reviewed #32325 Allow letterboxing opt-in/out - reviewed #30570 Implement per-site security settings support
sisbell: Last Week: - #31130 - Buster Support - small change to use snapshot repo. Tested Android variant build - #32476 - Review/Comments of JNI services - #32534 - Review/Comment on new jtorctl implementation - #32501 - Fixed formatting in TorSettings interface (TOPL) - ready for review - #32516 - Write methods in TorConfigBuilder - fixed a number of issues to make methods cleaner, more consistent. - #32405 - Crash after bootstrap - fixed/merged - Thanksgiving holiday This week: - test buster on different variants - #28704 Compile Tor and dependencies (#28764 SSL, #28765 LibEvent)
Pili: Last week: - S9 Phase 2 report This week: - Catching up on roadmap and projects after reporting season - Please start tagging bugs with "BugSmashFund" and adding points to it so we can start "using" the pot of money :) - Please update your November Actual Points - Reminder about moving off Storm and into NextCloud - please move any documents you want to keep to Nextcloud ===========================================
- Matt
Hello!
We held our weekly meeting on 9 December. The logs are available http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-12-09-18.29.lo... .
In that meeting we discussed on which platforms Tor Browser is supported. The current set of supported operating systems and processor architectures is significantly based on Mozilla's list, but that list hasn't been defined. This question wasn't resolved during the meeting.
I created a wiki page, as a starting point for what we have now. I may have some errors on that page, so please correct it if there are any errors (in particular, the supported compilers per platform).
https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Supported_Platf...
The second topic we discussed was writing a specification for the information provided at https://aus1.torproject.org/torbrowser/update_3/release/downloads.json . It is a convenient source of the currently available Tor Browser versions, however there isn't any documentation of its format (except ticket #16551). This should be added in the tor-browser-spec repository, and it should be described on the (future) Dev web portal.
We concluded the meeting by having a meta-discussion on how we annotate topics on the meeting pad. Until now, discussion topics were bolded on the pad, but that does not translate into plain-text emails. We decided for future meetings we will both bold the line and add a '[discuss]' annotation at the beginning of the line.
=============== Week of December 9, 2019
Discussion:
- Which Tiers Mozilla has (https://developer.mozilla.org/en-US/docs/Mozilla/Supported_build_configurati...) do we want to support? Where do we draw the line?
- it seems the *bsds are maintained elsewhere? (seems okay to me)
- what about windows aarch64 (which is even a tier 1 platform for Mozilla)?
- then we have #12631 (Tor Browser for ARM architecture) and #28326 (Tor Browser for PPC64LE). would we just take a patch or even build those things during releases and make them available on the website?
- We have https://aus1.torproject.org/torbrowser/update_3/release/downloads.json for helping other projects/folks that depend on parsing the latest Tor Browser updates (great)
but we have not place where this is documented (not so great). Where do we want to put that info?
- One idea was to create a retroactive proposal in our tor-browser-spec repo where users can then learn about it but maybe there is a smarter plan
- Should we delete old meeting notes? - Reminder to move documents off storm and into Nextcloud
GeKo:
Last week:
- #32053 (patch is finally up for review), #31597, #25021
- started with the BIG ticket triage
- reviews (#30558, #32676, #28475, #32659, #32116)
- summarized the current macOS signing situation with some possible ways forward (Jeremy: is there a link to this summary? sysrqb informs me that it's in #32173, thanks.)
- more RLBox work in spare time
- poked a bit at mingw-w64-clang GeckoDriver build issue on the weekend (https://bugzilla.mozilla.org/show_bug.cgi?id=1489320)
This week:
- likely help with another revision of the OTF proposal
- #31597 (hopefully finishing that one this week), #25021
- more old ticket triage
- reviews
- more RLBox work in spare time
mcs and brade: Last week: - Sponsor 27 work: #19757 (permanent storage of client auth keys and associated management UI). - Added comments to a few tickets: - #32654 (Torbrowser overides user disabling tor proxy after restart). - #32460 (download page has confusing flow, especially with donate banner). This week/upcoming: - More work on #19757 (permanent storage of client auth keys and associated management UI). - #32674 (Change link on 'Get involved' in about:tor to new community portal). - Review for #21952 (Onion-Location).
Jeremy Rand: Last week: - Addressed Georg's review so far on #30558. This week: - Address whatever additional review happens on #30558. - Review boklm's rebased #30334 patch.
boklm: Last week: - helped publish new releases - looked at blog comments - fixed #32675 (Add lt, ms, th locales to the alpha download page) - attended reproducible builds summit - helped with patch for #32676 (Consider publishing a tarball with all Tor Browser langpacks) - rebased patch for #30334 (build_go_lib for executables) and started testing it This week: - Finish reviewing/testing #30334 (build_go_lib for executables) - Review #32053 (Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)) - Work on #18867 subtickets: - #31988 (Generate a mar signing key for nightly builds) - #25102 (Add script to sign nightly build mar files) - Look at macOS signing situation
tjr: Submitted the form boundary randomization patch for review MinGW Build improvements, mostly on mozilla's/central's end: bump to clang 9 bump mingw version and remove a bunch of ifdefs for undefined stuff in mingw build libssp (without building gcc!) for fortify source and stack-protector
pospeselr: Last week: - revisions for Mozilla 1594455 (letterboxing UX improvements) - revisions for Mozilla 1601040 (letterboxing settings in about:preferences#privacy) - started real work on #30570, creating new dummy permissions for javascript and active content This week: - afk in second half of the week - continue work on #30570 and keeping the ball rolling on those Mozilla tickets Next week: - offline most of next week but not afk
sysrqb: Last week: Releases Ticket maintenance/triage Drafted some emails This week: More ticket maintenance OTF proposal More drafting emails Android signing key documentation Updating Tor Browser Design Doc
sisbell: Last Week: - #28764 - OpenSSL Android - working with latest - #28765 - LibEvent Android - working with 2.1.11 (If we use current 2.1.8 we need to apply a patch) - #28766 - Tor Build for Android - in progress This week: - #28766 - Tor Android build - #31130 - test builds for whezzy and stretch work with latest Debian version - Follow up about jtorctl deployment to maven repo
pili: Last week: - Ticket Triage - October and November Tor Browser reports - S27 reports This week: - December and January roadmap review - OTF Proposal revisions Next week: - AFK from December 20th 2019 - January 7th 2020 (might extend it to January 8th or 9th...)
antonela: - reviewing TorBrowserTeam201912 + ux-team tickets
https://trac.torproject.org/projects/tor/ticket/32228
https://trac.torproject.org/projects/tor/ticket/32119
https://trac.torproject.org/projects/tor/ticket/21952
https://trac.torproject.org/projects/tor/ticket/30570
- S27 - https://trac.torproject.org/projects/tor/ticket/32645 - anything we would like to discuss during the next All Hands meeting with Firefox folks?
https://pad.riseup.net/p/h_AP8p92R9AhcDaxAUxk ===============
Thanks, Matt
Hello!
We held our weekly meeting on Monday. The logs are available http://meetbot.debian.net/tor-meeting2/2019/tor-meeting2.2019-12-16-18.30.lo... .
This was a short meeting. This was also the last scheduled Tor Browser Team meeting of 2019 (!). The next team meeting will be on 6 January, 2020.
We have a Tor Browser release coming on 7 January, so all of our patches should be ready for that release by the end of this week. We are having a Tor Browser Release meeting on Wednesday (18 Dec).
Finally, I'd like to thank Georg (GeKo, gk) for his fearless leadership of Tor Browser for many years. As he moves onto new and interesting challenges on the Network Health team, he will be missed on this team (although we know he is not too far away). We wish him the best of luck.
Have happy holidays everyone!
============= Week of December 16, 2019
Discussion: Next team meeting Release prep
pospeselr: Last week: - pushed updated patch for #32116 (tor-browser mozconfig fixes) - Mozilla 1594455 and 1601040 revisions - a bit of 30570 work This week: - 31855 (remove end of year fundraising campaign) - offline this week after Monday, but back from afk on Wednesday
mcs and brade: Last week: - Sponsor 27 work: - #19757 (permanent storage of client auth keys and associated management UI). - We posted work-in-progress screenshots here: https://trac.torproject.org/projects/tor/ticket/19757#comment:18 - Remaining work is mainly to make the UI functional by hooking it up with control port commands. - Added tickets and comments to the S27 report pad: https://pad.riseup.net/p/aAZQ_UDNrJiwSRxTrFoK - Created a patch for #32674 (Change about:tor ‘Get involved' to point to new community portal). - Completed code review for #21952 (Onion-Location). This week/upcoming: - #32636 (Clean up locales shipped with Tor Launcher). - We will be taking time off from Tor work starting 19-December (this Thursday); back on 6-January-2020.
sysrqb: Last week: Finished most team lead transition items Began testing #28764 and #28765 Discovered CMake broke nightly builds #32741 Began updating security-slider part of the design doc This week: Looking at a possible crash (maybe Android-specific) #32744 Continue updating design doc Release prep Triaging tickets
boklm: Last week: - Worked on #18867 subtickets: - Setup generation of incrementals (#25101) and fixed #32738 (If the linux64 mar-tools does not exist, we should use the other mar-tools available) - Signing of nightly sha256sums files with gpg (#32750 and #32751) - Started a script to sign nightly mar files and publish them (#25102), and subtickets - Started a script to generate a mar signing key for nightly builds (#31988) - Some reviews: - #32053 ((Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)) - #32739 (Bump clang to 8.0.1) - Looked at android build issue (#32761) - Looked at blog comments This week: - Try to finish the work on #18867 (Ship auto-updates for Tor Browser nightly channel) - Look at macOS signing situation
Jeremy Rand: Last week: - Addressed Georg's review so far on #30558. This week: - Address whatever additional review happens on #30558. - Review boklm's rebased #30334 patch.
Pili: Last week: - Browser Proposal meetings and revisions - BugSmashFund tagging - Some trac triage - General roadmap gardneing This week: - Wrapping up things before vacation - afk from Friday 20th December 2019 - Monday 6th January 2020 - back on January 7th (probably) - ping me if there is anything urgent you need me to look at before I go
GeKo:
- Last week:
- helped a bit with OTF proposal
- #31597 (almost done), #25021
- more old ticket triage
- reviews (#30558, #32741, #32751, #26861, #27045, #32750)
- more RLBox work in spare time (not much, though, alas)
- a bit HackerOne work
- spent some time deobfuscating JavaScript malware served in a fake Tor Browser
- This week:
- finish #31597
- work on #25021
- reviews
- more ticket triage
- finish up some loose ends from my Tor Browser ToDo list
Antonela
- reviewed #21952 =============
Thanks, Matt
tor-project@lists.torproject.org