Hi all,
I _think_ I've managed to build a 64-bit version of Tor Browser for Mac OS. Specifically, I built the entire bundle, but only TorBrowser was modified to be 64bit. The changes I made are here: https://github.com/tomrittervg/tor-browser/commit/79fbe1e3ffde1ac3577a9937aa... (ignore the last couple lines commenting out some options I had added, then removed).
The bundles are here: https://ritter.vg/misc/transient/2014-09-02-4.x-1-build1-tjr5/
It would be fantastic if anyone could test the bundles and/or the patch and determine if
a) you agree it's 64 bit b) it works c) anyone else can reproduce a 64 bit build (I'm not going for full reproducibility right now, just a successfull build that is 64 bit)
-tom
Tom Ritter:
The bundles are here: https://ritter.vg/misc/transient/2014-09-02-4.x-1-build1-tjr5/
Nice, thanks for looking into it and doing these builds! This gives us another option wrt the question on how to handle users that are still using OS X 10.6 and that may or may not need 32bit bundles.
It would be fantastic if anyone could test the bundles and/or the patch and determine if
a) you agree it's 64 bit
yes, the browser itself is 64 bit, I agree.
b) it works
I gave it a short test and it worked on my OS X 10.6.8.
c) anyone else can reproduce a 64 bit build (I'm not going for full reproducibility right now, just a successfull build that is 64 bit)
I don't have the time right now, I can test later if nobody is faster. Anyway, looking at your changes I'd be surprised if you wouldn't get exactly the same .dmg files doing the build twice.
Georg
On 9/2/14, 11:25 PM, Tom Ritter wrote:
Hi all,
I _think_ I've managed to build a 64-bit version of Tor Browser for Mac OS. Specifically, I built the entire bundle, but only TorBrowser was modified to be 64bit. The changes I made are here: https://github.com/tomrittervg/tor-browser/commit/79fbe1e3ffde1ac3577a9937aa... (ignore the last couple lines commenting out some options I had added, then removed).
The bundles are here: https://ritter.vg/misc/transient/2014-09-02-4.x-1-build1-tjr5/
It would be fantastic if anyone could test the bundles and/or the patch and determine if
a) you agree it's 64 bit b) it works
I did a quick test on a Mac OS 10.9.4 system and I also confirmed that all of the Firefox binaries are 64-bit. The tor and pluggable transport pieces are still 32-bit (but you already knew that). Would there be any advantage from a security perspective if we also deliver 64-bit binaries for tor and related components?
c) anyone else can reproduce a 64 bit build (I'm not going for full reproducibility right now, just a successfull build that is 64 bit)
I need to do some ESR31 patch work first....
On 3 September 2014 08:13, Mark Smith mcs@pearlcrescent.com wrote:
I did a quick test on a Mac OS 10.9.4 system and I also confirmed that all of the Firefox binaries are 64-bit. The tor and pluggable transport pieces are still 32-bit (but you already knew that). Would there be any advantage from a security perspective if we also deliver 64-bit binaries for tor and related components?
Speaking generally, not knowing about all the components or specifics - you get some small wins moving to 64 bit - mainly the increased address space for ASLR and defense against practical integer overflow. But it can be dangerous too - Nick's a wonderful programmer but there are classes of bugs that result from 32-64 bit conversions. http://www.viva64.com/en/a/0065/ I would not be surprised if there was _some_ bug somewhere because of it.
I'm not sure if there are other components in the bundle, related to firefox.exe but not part of it's build process, that should be 64bit though.... But I guess if TBB works, it's obviously not _necessary_.
c) anyone else can reproduce a 64 bit build (I'm not going for full reproducibility right now, just a successfull build that is 64 bit)
I need to do some ESR31 patch work first....
Oh, no sweat - this is obviously on-the-side from deliverables =)
-tom
-
Georg Koppen -
Mark Smith -
Tom Ritter