Thanks Andrew! Great points, changes pushed.
On Mon, Oct 30, 2017 at 3:32 PM, Andrew Deason adeason@dson.org wrote:
On Mon, 30 Oct 2017 14:00:44 -0700 Damian Johnson atagar@torproject.org wrote:
Hi all. Pushed a couple changes to address feedback thus far...
Sorry if this is not the right place for nitpicking/bikeshedding, but:
Fixed the os.putenv() issue that came up for FreeBSD...
Bare 'except:' clauses are really not recommended for error handling, since it catches things like SystemExit and GeneratorExit (not to mention it also triggers if you misspell 'putenv' or something). You can use 'except Exception:' instead, but here I would suggest at least 'except OSError:'.
When sqlite3 is unavailable encouraging folks to contact us so we can provide per-platform advice. For FreeBSD providing the 'pkg install' command mentioned earlier...
s/Unfortunatley/Unfortunately/
And thanks for your work; don't mistake this for me being ungrateful :)
-- Andrew Deason adeason@dson.org
tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays