Pier Angelo Vendrame pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser
Commits:
712375db by Henry Wilkes at 2024-08-28T11:35:47+02:00
Bug 43092: Disable wayland by default in Base Browser.
- - - - -
1 changed file:
- toolkit/xre/nsAppRunner.cpp
Changes:
=====================================
toolkit/xre/nsAppRunner.cpp
=====================================
@@ -460,13 +460,14 @@ bool IsWaylandEnabled() {
return true;
}
}
+ // Keep wayland disabled in Base Browser. See tor-browser#43092.
+ return false;
// Enable by default when we're running on a recent enough GTK version. We'd
// like to check further details like compositor version and so on ideally
// to make sure we don't enable it on old Mutter or what not, but we can't,
// so let's assume that if the user is running on a Wayland session by
// default we're ok, since either the distro has enabled Wayland by default,
// or the user has gone out of their way to use Wayland.
- return !gtk_check_version(3, 24, 30);
}();
return isWaylandEnabled;
}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/712…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/712…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
ec9235a9 by Henry Wilkes at 2024-08-28T11:35:06+02:00
Bug 43092: Disable wayland by default in Base Browser.
- - - - -
1 changed file:
- toolkit/xre/nsAppRunner.cpp
Changes:
=====================================
toolkit/xre/nsAppRunner.cpp
=====================================
@@ -460,13 +460,14 @@ bool IsWaylandEnabled() {
return true;
}
}
+ // Keep wayland disabled in Base Browser. See tor-browser#43092.
+ return false;
// Enable by default when we're running on a recent enough GTK version. We'd
// like to check further details like compositor version and so on ideally
// to make sure we don't enable it on old Mutter or what not, but we can't,
// so let's assume that if the user is running on a Wayland session by
// default we're ok, since either the distro has enabled Wayland by default,
// or the user has gone out of their way to use Wayland.
- return !gtk_check_version(3, 24, 30);
}();
return isWaylandEnabled;
}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ec9235a…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ec9235a…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
3a076593 by Henry Wilkes at 2024-08-28T09:51:38+01:00
Bug 43092: Disable wayland by default in Base Browser.
- - - - -
1 changed file:
- toolkit/xre/nsAppRunner.cpp
Changes:
=====================================
toolkit/xre/nsAppRunner.cpp
=====================================
@@ -460,13 +460,14 @@ bool IsWaylandEnabled() {
return true;
}
}
+ // Keep wayland disabled in Base Browser. See tor-browser#43092.
+ return false;
// Enable by default when we're running on a recent enough GTK version. We'd
// like to check further details like compositor version and so on ideally
// to make sure we don't enable it on old Mutter or what not, but we can't,
// so let's assume that if the user is running on a Wayland session by
// default we're ok, since either the distro has enabled Wayland by default,
// or the user has gone out of their way to use Wayland.
- return !gtk_check_version(3, 24, 30);
}();
return isWaylandEnabled;
}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3a07659…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3a07659…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser
Commits:
6935ca00 by Henry Wilkes at 2024-08-27T20:38:54+00:00
fixup! Bug 40597: Implement TorSettings module
Bug 42622: Send TorConnect "Error" signal before "StateChange".
- - - - -
1 changed file:
- toolkit/modules/TorConnect.sys.mjs
Changes:
=====================================
toolkit/modules/TorConnect.sys.mjs
=====================================
@@ -686,16 +686,7 @@ class ErrorState extends StateCallback {
ErrorState.#hasEverHappened = true;
}
- run(error) {
- if (!(error instanceof TorConnectError)) {
- error = new TorConnectError(TorConnectError.ExternalError, error);
- }
- TorConnect._errorCode = error.code;
- TorConnect._errorDetails = error;
- lazy.logger.error(`Entering error state (${error.code})`, error);
-
- Services.obs.notifyObservers(error, TorConnectTopics.Error);
-
+ run(_error) {
this.changeState(TorConnectState.Configuring);
}
@@ -903,6 +894,23 @@ export const TorConnect = {
// Set our new state first so that state transitions can themselves
// trigger a state transition.
this._stateHandler = this._makeState(newState);
+
+ // Error signal needs to be sent out before we enter the Error state.
+ // Expected on android `onBootstrapError` to set lastKnownError.
+ // Expected in about:torconnect to set the error codes and internet status
+ // *before* the StateChange signal.
+ if (newState === TorConnectState.Error) {
+ let error = args[0];
+ if (!(error instanceof TorConnectError)) {
+ error = new TorConnectError(TorConnectError.ExternalError, error);
+ }
+ TorConnect._errorCode = error.code;
+ TorConnect._errorDetails = error;
+ lazy.logger.error(`Entering error state (${error.code})`, error);
+
+ Services.obs.notifyObservers(error, TorConnectTopics.Error);
+ }
+
Services.obs.notifyObservers(
{ state: newState },
TorConnectTopics.StateChange
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
e8eefc25 by Henry Wilkes at 2024-08-27T21:12:40+00:00
fixup! Bug 7494: Create local home page for TBB.
Bug 42744: Stop using prefersColorSchemeOverride for about:tor.
common-shared.css seems to have simplified since the original
implementation, so we can simply set the `color-scheme` and `color` on
the search form to keep the styling consistent in both light and dark
themes.
- - - - -
2 changed files:
- browser/components/abouttor/AboutTorChild.sys.mjs
- browser/components/abouttor/content/aboutTor.css
Changes:
=====================================
browser/components/abouttor/AboutTorChild.sys.mjs
=====================================
@@ -2,19 +2,6 @@
* Actor child class for the about:tor page.
*/
export class AboutTorChild extends JSWindowActorChild {
- actorCreated() {
- if (this.contentWindow.matchMedia("not (prefers-contrast)").matches) {
- // When prefers-contrast is not set, the page only has one style because
- // we always set a dark background and a light <form>.
- // We force prefers-color-scheme to be light, regardless of the user's
- // settings so that we inherit the "light" theme styling from
- // in-content/common.css for the <form> element. In particular, we want
- // the light styling for the <input> and <moz-toggle> elements, which are
- // on a light background.
- this.browsingContext.prefersColorSchemeOverride = "light";
- }
- }
-
handleEvent(event) {
switch (event.type) {
case "DOMContentLoaded":
=====================================
browser/components/abouttor/content/aboutTor.css
=====================================
@@ -180,15 +180,17 @@ body:not(.show-tor-check) #tor-check {
body > :not(#search-form) {
/* Same as --in-content-page-color when "prefers-color-scheme: dark" */
- --in-content-page-color: #fbfbfe;
- --in-content-text-color: #fbfbfe;
- color: var(--in-content-text-color);
+ color: var(--color-gray-05);
--link-color: var(--tor-link-color-dark);
--link-color-hover: var(--tor-link-color-hover-dark);
--link-color-active: var(--tor-link-color-active-dark);
}
#search-form {
+ /* Use light color for background and moz-toggle shadow root. */
+ color-scheme: light;
+ /* Same as --in-content-page-color when "prefers-color-scheme: light" */
+ color: var(--color-gray-100);
border-color: transparent;
}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e8eefc2…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e8eefc2…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
a8d1d771 by Henry Wilkes at 2024-08-27T21:07:58+00:00
fixup! Bug 7494: Create local home page for TBB.
Bug 43075: Drop link spacing in about:tor.
- - - - -
1 changed file:
- browser/components/abouttor/content/aboutTor.css
Changes:
=====================================
browser/components/abouttor/content/aboutTor.css
=====================================
@@ -89,14 +89,6 @@ body:not(.show-tor-check) #tor-check {
margin-inline-end: 0.3em;
}
-:is(
- .home-message,
- #tor-check,
-) a {
- /* Increase gap between the link and the rest of the text. */
- margin-inline: 0.4em;
-}
-
#search-form {
grid-area: form;
/* Occupy the entire "form" block. */
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a8d1d77…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a8d1d77…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser
Commits:
6935ca00 by Henry Wilkes at 2024-08-27T20:38:54+00:00
fixup! Bug 40597: Implement TorSettings module
Bug 42622: Send TorConnect "Error" signal before "StateChange".
- - - - -
1 changed file:
- toolkit/modules/TorConnect.sys.mjs
Changes:
=====================================
toolkit/modules/TorConnect.sys.mjs
=====================================
@@ -686,16 +686,7 @@ class ErrorState extends StateCallback {
ErrorState.#hasEverHappened = true;
}
- run(error) {
- if (!(error instanceof TorConnectError)) {
- error = new TorConnectError(TorConnectError.ExternalError, error);
- }
- TorConnect._errorCode = error.code;
- TorConnect._errorDetails = error;
- lazy.logger.error(`Entering error state (${error.code})`, error);
-
- Services.obs.notifyObservers(error, TorConnectTopics.Error);
-
+ run(_error) {
this.changeState(TorConnectState.Configuring);
}
@@ -903,6 +894,23 @@ export const TorConnect = {
// Set our new state first so that state transitions can themselves
// trigger a state transition.
this._stateHandler = this._makeState(newState);
+
+ // Error signal needs to be sent out before we enter the Error state.
+ // Expected on android `onBootstrapError` to set lastKnownError.
+ // Expected in about:torconnect to set the error codes and internet status
+ // *before* the StateChange signal.
+ if (newState === TorConnectState.Error) {
+ let error = args[0];
+ if (!(error instanceof TorConnectError)) {
+ error = new TorConnectError(TorConnectError.ExternalError, error);
+ }
+ TorConnect._errorCode = error.code;
+ TorConnect._errorDetails = error;
+ lazy.logger.error(`Entering error state (${error.code})`, error);
+
+ Services.obs.notifyObservers(error, TorConnectTopics.Error);
+ }
+
Services.obs.notifyObservers(
{ state: newState },
TorConnectTopics.StateChange
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0…
You're receiving this email because of your account on gitlab.torproject.org.