tbb-commits August 2024

tbb-commits@lists.torproject.org

1 participants
282 discussions

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag tor-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag base-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-128.2.0esr-14.0-1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] 304 commits: Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load...
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 81867153 by Timothy Nikkel at 2024-08-26T21:12:22+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - c5ac1a5f by Jon Coppeard at 2024-08-26T21:12:24+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 9c1466c0 by Arturo Mejia at 2024-08-26T21:12:24+02:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Original Revision: https://phabricator.services.mozilla.com/D216996 Differential Revision: https://phabricator.services.mozilla.com/D217718 - - - - - 326b38a5 by hackademix at 2024-08-26T21:12:25+02:00 fixup! Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Bug 43005: followup, fix backporting conflict. - - - - - 7ced890b by Henry Wilkes at 2024-08-26T21:12:25+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 7b237363 by hackademix at 2024-08-26T21:12:25+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - f9f5c90d by Henry Wilkes at 2024-08-26T21:12:26+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 7000fce3 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 69d98181 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 3d7cf0e4 by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - bea8bfcc by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 9c4d59e2 by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - b6a3022c by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 92d6849a by hackademix at 2024-08-26T21:12:28+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 56c3973e by hackademix at 2024-08-26T21:12:29+02:00 Bug 42835: Create an actor to filter file data transfers - - - - - eb3e3c90 by hackademix at 2024-08-26T21:12:29+02:00 fixup! Bug 42835: Create an actor to filter file data transfers Bug 43064: Make file filtering more specific - - - - - f381d9db by Beatriz Rizental at 2024-08-26T21:12:29+02:00 Bug 42728: Modify ./mach lint to skip unused linters - - - - - 4b0af395 by Gaba at 2024-08-26T21:12:30+02:00 Adding issue and merge request templates - - - - - 6d7c931c by Morgan at 2024-08-26T21:12:30+02:00 fixup! Adding issue and merge request templates add QA issue templates for tor browser desktop and android - - - - - 58787061 by Richard Pospesel at 2024-08-26T21:12:30+02:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 79f1bf40 by Beatriz Rizental at 2024-08-26T21:12:31+02:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 6e97802f by Beatriz Rizental at 2024-08-26T21:12:31+02:00 Add CI for Base Browser - - - - - cd9ef577 by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Bug 42997: Reduce the number of git fetches by fetching during a setup job and passing that initial fetch around as a git bundle to other jobs through the Gitlab artifacts. Further reduce the number of fetches by creating a list of changed files in the setup job and passing that around as well as an artifact. - - - - - c267bf8a by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 848f259f by Pier Angelo Vendrame at 2024-08-26T21:12:32+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 67a2bcb5 by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 70d0346a by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 29320: Replace the gnu target with gnullvm for Rust. - - - - - d8b62e8d by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - a45d24a9 by Pier Angelo Vendrame at 2024-08-26T21:12:34+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - ce7b48bb by Dan Ballard at 2024-08-26T21:12:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - d51aa221 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 50628576 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 94b32f36 by Mike Perry at 2024-08-26T21:12:35+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 2cef1eb7 by Alex Catarineu at 2024-08-26T21:12:36+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - bc4e9049 by Morgan at 2024-08-26T21:12:36+02:00 fixup! Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots - Revert 612d54e8e97017891865db8003826d8688ad5a9b - - - - - d0d68da7 by Georg Koppen at 2024-08-26T21:12:36+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - bf415a82 by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 86c1085d by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - c7124709 by Alex Catarineu at 2024-08-26T21:12:37+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - a0a00486 by Kathy Brade at 2024-08-26T21:12:38+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 0bb8c9d1 by Arthur Edelstein at 2024-08-26T21:12:38+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - edf279fa by Alex Catarineu at 2024-08-26T21:12:40+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - b7d36508 by cypherpunks1 at 2024-08-26T21:12:41+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 9d771026 by Pier Angelo Vendrame at 2024-08-26T21:12:41+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 49915074 by Georg Koppen at 2024-08-26T21:12:42+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - e66875f2 by Alex Catarineu at 2024-08-26T21:12:42+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 5e200391 by cypherpunks1 at 2024-08-26T21:12:42+02:00 Bug 41568: Disable LaterRun - - - - - 9a87dbae by cypherpunks1 at 2024-08-26T21:12:43+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 0c7995af by Pier Angelo Vendrame at 2024-08-26T21:12:43+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - fc809659 by Richard Pospesel at 2024-08-26T21:12:43+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 754cab93 by Richard Pospesel at 2024-08-26T21:12:44+02:00 Bug 42037: Disable about:firefoxview page - - - - - 63b0d2b6 by Mike Perry at 2024-08-26T21:12:44+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - ab3d9eee by Pier Angelo Vendrame at 2024-08-26T21:12:44+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - a2c5db09 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42814: Opt out from Firefox relay by default. - - - - - 64dd51aa by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42792: Explicitly turn off Pocket suggestions in the URL bar - - - - - a64af102 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42810: Explicitly disable address and credit card filling. - - - - - bd13ad68 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42886: Disable trending results. In this way we are consistent with weather and addons. - - - - - 4f6744b3 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - c55ab11c by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 5eca2524 by Morgan at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42604: Remove safe-browsing google prefs - - - - - 6e38aef1 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 3d7617e5 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - a72df0ec by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - a72b7149 by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 9a8da4ec by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - f165a887 by Pier Angelo Vendrame at 2024-08-26T21:12:49+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 2912d408 by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - f2747a92 by Alex Catarineu at 2024-08-26T21:12:50+02:00 Bug 26345: Hide tracking protection UI - - - - - 0bc53aca by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Revert change to hide tracking protection toolbar icon and preferences. - - - - - 62c98d07 by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Re-hide the tracking protections UI. We hide the toolbar button with CSS. We hide the preferences using data-hidden-from-search. - - - - - 40f0a39c by Pier Angelo Vendrame at 2024-08-26T21:12:51+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - c95f4a40 by Alex Catarineu at 2024-08-26T21:12:51+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 63dedfae by Mike Perry at 2024-08-26T21:12:51+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - ee693d0f by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 40d60411 by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox's default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - e5b640ed by Matthew Finkel at 2024-08-26T21:12:52+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 9d804773 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 862cf0a0 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 7308931b by hackademix at 2024-08-26T21:12:53+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - 2df1ea2b by Richard Pospesel at 2024-08-26T21:12:54+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 02a1403b by Henry Wilkes at 2024-08-26T21:12:54+02:00 fixup! Bug 41659: Add canonical color definitions to base-browser Bug 41817: Drop browser-colors.css. - - - - - 8e7161c9 by Pier Angelo Vendrame at 2024-08-26T21:12:55+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 7ae65523 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - fa9a86d7 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - ffe235df by p13dz at 2024-08-26T21:12:58+02:00 Bug 40283: Workaround for the file upload bug - - - - - 942e2690 by Arthur Edelstein at 2024-08-26T21:12:58+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 9c15f42f by Pier Angelo Vendrame at 2024-08-26T21:12:58+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 0e5340b6 by hackademix at 2024-08-26T21:12:59+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ea33fa7e by hackademix at 2024-08-26T21:12:59+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - ee2f0e77 by Pier Angelo Vendrame at 2024-08-26T21:12:59+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 7bdf1f4f by Pier Angelo Vendrame at 2024-08-26T21:13:00+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - e4be9c6d by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - afaf8423 by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 44885e03 by hackademix at 2024-08-26T21:13:01+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 86f677de by hackademix at 2024-08-26T21:13:01+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - ddcb4d9f by hackademix at 2024-08-26T21:13:01+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 3d4036dd by hackademix at 2024-08-26T21:13:02+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - cf1f4f84 by hackademix at 2024-08-26T21:13:02+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 5f065803 by hackademix at 2024-08-26T21:13:03+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - ca48302c by hackademix at 2024-08-26T21:13:03+02:00 Bug 41916: Letterboxing preferences UI - - - - - 1830911f by Henry Wilkes at 2024-08-26T21:13:03+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 916b00d1 by Henry Wilkes at 2024-08-26T21:13:04+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 63408484 by hackademix at 2024-08-26T21:13:04+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 97d244d6 by hackademix at 2024-08-26T21:13:04+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 340ad1dc by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 130e1830 by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 3f6199c2 by Kathy Brade at 2024-08-26T21:13:05+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 44d94c49 by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 42061: Create an alpha update channel. - - - - - f703c271 by Nicolas Vigier at 2024-08-26T21:13:06+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 15a1850f by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - faec135c by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 3106a624 by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 463c197a by Alex Catarineu at 2024-08-26T21:13:07+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - d8fc224b by Matthew Finkel at 2024-08-26T21:13:08+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 3acb44d0 by Henry Wilkes at 2024-08-26T21:13:08+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 590130a2 by hackademix at 2024-08-26T21:13:09+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 4449518c by Pier Angelo Vendrame at 2024-08-26T21:13:09+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 739d6aa0 by Henry Wilkes at 2024-08-26T21:13:09+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42644: Remove redundant separator CSS rules. - - - - - f1394ce2 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - f3e8e4c7 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level="top" attribute. - - - - - e084e430 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42641: Use moz-button-group for panel buttons. Also tweak the "Learn more" link to have block-end padding to ensure its focus outline is visible, and restrict it to align-start so that it does not span the full width. Also switch from `em` to `px` units for the vertical spacing. - - - - - 90011d06 by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - f87dc41f by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - e433bb32 by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 41817: Drop browser-colors.css. - - - - - 500fa48c by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 85bf9ccd by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 Bug 40926: Implemented the New Identity feature - - - - - 40bca4c1 by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42596: Add preferences for log levels. - - - - - b451c170 by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 608f5e2e by Pier Angelo Vendrame at 2024-08-26T21:13:15+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - c1aee63c by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - f18bfbcb by Pier Angelo Vendrame at 2024-08-26T21:13:16+02:00 Bug 42774: Always hide the third-pary certs UI. - - - - - c4891766 by Beatriz Rizental at 2024-08-26T21:13:16+02:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - ac5dd4e7 by Henry Wilkes at 2024-08-26T21:13:16+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 14208303 by Richard Pospesel at 2024-08-26T21:13:17+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 8cbf9387 by Beatriz Rizental at 2024-08-26T21:13:17+02:00 Add CI for Tor Browser - - - - - 5630f94f by Henry Wilkes at 2024-08-26T21:13:17+02:00 fixup! Add CI for Tor Browser Bug 42759: Remove localization file names that were removed in 13.5. - - - - - 88899871 by Henry Wilkes at 2024-08-26T21:13:18+02:00 fixup! Add CI for Tor Browser Bug 42480: Add android torbrowser_strings.xml to our translation CI. - - - - - 8d3dddbb by Richard Pospesel at 2024-08-26T21:13:18+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 15c4115f by Henry Wilkes at 2024-08-26T21:13:18+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Bug 43014: Add --purgecaches when running the dev build. - - - - - bc68901c by Henry Wilkes at 2024-08-26T21:13:19+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - f23a1c6b by Kathy Brade at 2024-08-26T21:13:19+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 5621ebd5 by Alex Catarineu at 2024-08-26T21:13:20+02:00 Add TorStrings module for localization - - - - - 21e43b74 by Henry Wilkes at 2024-08-26T21:13:20+02:00 fixup! Add TorStrings module for localization Bug 42212: Migrate onion service strings to Fluent. - - - - - 7c5e8a55 by Henry Wilkes at 2024-08-26T21:13:20+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - cef474ac by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 42663: Add tooltip text to the "Connection" category. - - - - - 92a684ba by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 42212: Migrate onion service strings to Fluent. - - - - - 84b89162 by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 41820: Use moz-message-bar for the downloads warning. - - - - - 8565c3fc by Henry Wilkes at 2024-08-26T21:13:22+02:00 Tor Browser localization migration scripts. - - - - - e86b6689 by Henry Wilkes at 2024-08-26T21:13:22+02:00 fixup! Tor Browser localization migration scripts. Bug 42212: Migrate onion service strings to Fluent. - - - - - 90df4040 by Henry Wilkes at 2024-08-26T21:13:22+02:00 fixup! Tor Browser localization migration scripts. Bug 41820: Use moz-message-bar for the downloads warning. We add a migration to convert the old string values into the new value. - - - - - cba7d9fb by Henry Wilkes at 2024-08-26T21:13:23+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - 00b24f37 by Mike Perry at 2024-08-26T21:13:23+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 4913b7f1 by Henry Wilkes at 2024-08-26T21:13:23+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 56d1081e by hackademix at 2024-08-26T21:13:24+02:00 Bug 41917: Tor brand-specific styles. - - - - - 04bbb15c by Henry Wilkes at 2024-08-26T21:13:24+02:00 Bug 41817: tor-browser semantic colors. - - - - - aa6c298a by Henry Wilkes at 2024-08-26T21:13:25+02:00 fixup! Bug 41817: tor-browser semantic colors. Bug 43071: Fix focus styling for primary tor-button buttons. Also, add a prefers-contrast and forced-colors variant for the tor colors that use the Firefox design system colors. - - - - - f3440bb5 by Henry Wilkes at 2024-08-26T20:11:26+00:00 fixup! Bug 41817: tor-browser semantic colors. Bug 41811: Use the tor color for .tor-button focus outlines. - - - - - 5b2142c5 by Henry Wilkes at 2024-08-26T20:11:27+00:00 Add purple tor version of the loading APNG. - - - - - 548a34b7 by sanketh at 2024-08-26T20:11:27+00:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 5809082a by Pier Angelo Vendrame at 2024-08-26T20:11:27+00:00 fixup! Bug 40209: Implement Basic Crypto Safety Bug 43001: Ship only a copy of the MIT license, like upstream. See MozBug 1838373. - - - - - 9272de51 by Pier Angelo Vendrame at 2024-08-26T20:11:28+00:00 fixup! Bug 40209: Implement Basic Crypto Safety Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - b348dab2 by Mike Perry at 2024-08-26T20:11:28+00:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - b2bc24ba by Henry Wilkes at 2024-08-26T20:11:28+00:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 3f583eb6 by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - ae7a0847 by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 4e9014aa by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - f1ebdb05 by Pier Angelo Vendrame at 2024-08-26T20:11:30+00:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - e5935ccd by Pier Angelo Vendrame at 2024-08-26T20:11:30+00:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42596: Add preferences for log levels. - - - - - 136d6871 by Cecylia Bocovich at 2024-08-26T20:11:30+00:00 Lox integration - - - - - a17d5071 by Pier Angelo Vendrame at 2024-08-26T20:11:31+00:00 fixup! Lox integration Bug 42596: Add preferences for log levels. - - - - - 1aaa1516 by Richard Pospesel at 2024-08-26T20:11:31+00:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 823de020 by Pier Angelo Vendrame at 2024-08-26T20:11:31+00:00 fixup! Bug 40597: Implement TorSettings module Bug 42596: Add preferences for log levels. - - - - - 35580a21 by Arthur Edelstein at 2024-08-26T20:11:32+00:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - a04c7525 by Pier Angelo Vendrame at 2024-08-26T20:11:32+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42596: Add preferences for log levels. - - - - - 07b46f48 by Pier Angelo Vendrame at 2024-08-26T20:11:32+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - df6f4298 by Henry Wilkes at 2024-08-26T20:11:33+00:00 Bug 41600: Add a tor circuit display panel. - - - - - ccc864ec by Henry Wilkes at 2024-08-26T20:11:33+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42488: Remove redundant role="code" from ip address <code> element. After ESR 128, the <code> element has an implicit "code" accessible role. - - - - - c1e3717c by Henry Wilkes at 2024-08-26T20:11:33+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42700: Remove !nodes condition from circuit panel. Also updated comment. - - - - - 8e17c7fd by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42695: Use --arrowpanel variables instead of em units in the tor circuit display. - - - - - c8f563a4 by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42699: Drop level="top" attribute. - - - - - 221432d0 by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42661: Rerun update_emojis.py for the circuit flags. Add missing locales. - - - - - 95c50ad1 by Pier Angelo Vendrame at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42596: Add preferences for log levels. - - - - - c691b56e by Pier Angelo Vendrame at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - a94ab28d by Henry Wilkes at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43081: Remove line-height. - - - - - e04b4d02 by Pier Angelo Vendrame at 2024-08-26T20:11:36+00:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - a54e7b7e by Pier Angelo Vendrame at 2024-08-26T20:11:36+00:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42596: Add preferences for log levels. - - - - - 85ab1dcf by Morgan at 2024-08-26T20:11:36+00:00 fixup! Bug 42247: Android helpers for the TorProvider - - - - - 402cd6b5 by Pier Angelo Vendrame at 2024-08-26T20:11:37+00:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42655: Add a backend function for the "New circuit for this site" functionality. - - - - - 19e3b0ed by Morgan at 2024-08-26T20:11:37+00:00 fixup! Bug 42247: Android helpers for the TorProvider add missing (null) GeckoBundle parameter - - - - - fb07bdb1 by hackademix at 2024-08-26T20:11:37+00:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 4475b1b9 by Pier Angelo Vendrame at 2024-08-26T20:11:38+00:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 42596: Add preferences for log levels. - - - - - 8953e733 by Amogh Pradeep at 2024-08-26T20:11:38+00:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - ddad7356 by Matthew Finkel at 2024-08-26T20:11:38+00:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - f17e5a57 by Kathy Brade at 2024-08-26T20:11:39+00:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 7fa4f229 by Pier Angelo Vendrame at 2024-08-26T20:11:39+00:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 76c953cf by Pier Angelo Vendrame at 2024-08-26T20:11:39+00:00 fixup! Bug 40807: Added QRCode.js to toolkit/modules Bug 43001: Ship only a copy of the MIT license, like upstream. See MozBug 1838373. - - - - - fef3a227 by Richard Pospesel at 2024-08-26T20:11:39+00:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 2e9acaf4 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42662: Revert changes to main.inc.xhtml and main.js that remove the firefox connection settings. - - - - - bc684777 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42662: Use data-hidden-from-search to hide the firefox network settings. - - - - - a8c93d76 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - cb143c77 by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42663: Add tooltip text to the "Connection" category. - - - - - bb70711c by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42697: Remove inline-start padding from tor bridge provider list. - - - - - 418a8b04 by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42661: Rerun update_emojis.py for the bridge emojis. Add missing locales. - - - - - 78cf42e8 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42691: Allow users to copy built-in addresses. - - - - - 6060b357 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - f99fb356 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42705: Remove line-height rule for bridge settings and tweak spacing to accommodate. - - - - - 914a73df by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 3adddb16 by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42806: Use `lh` unit in tor connection preferences. Bug 42705: Adjust spacing of the Lox update list to account for removal of 1.8 line-height. - - - - - 0b217f21 by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43067: Use html:link instead of xml-stylesheet - - - - - 40a7e771 by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41817: Use semantic color names for tor preferences. - - - - - a7548deb by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 134d30fc by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43081: Remove line-height for non-ASCII text. - - - - - 9c45aa56 by Henry Wilkes at 2024-08-26T20:11:45+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41811: Use tor colors for connect buttons in bridge dialogs. - - - - - a995fecd by Richard Pospesel at 2024-08-26T20:11:45+00:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 571f1462 by Henry Wilkes at 2024-08-26T20:11:45+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - 9008d662 by Henry Wilkes at 2024-08-26T20:11:46+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42668: Drop torconnect modification to eslint-plugin-mozilla. - - - - - 891dd32c by Henry Wilkes at 2024-08-26T20:11:46+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41817: Use semantic tor color names for tor buttons. Also, for about:torconnect: + Use dark-mode variant for the buttons colors. + Add purple focus outline to the select element to match the buttons. + Stop applying the "primary" class to the cancel button. + Remove the checkbox styling since the checkbox was replaced with a moz-toggle-button. + Removed the "danger-button" class since it does not sufficiently telegraph a distinguished action, and has no dark-mode variant. + Use warning color from common-shared.css. + Drop --grey-40 for breadcrumb arrows, which did not adjust to theme. - - - - - 6717964d by Henry Wilkes at 2024-08-26T20:11:47+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 43066: Ensure the about:torconnect title icon changes. - - - - - 86da394d by Henry Wilkes at 2024-08-26T20:13:07+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41811: Only use tor outline color for tor-button elements. In particular, a `.primary:not(.tor-button)` element will have the default blue outline. - - - - - e37f4bfc by Pier Angelo Vendrame at 2024-08-26T20:21:04+00:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - 313f74cd by Henry Wilkes at 2024-08-26T20:21:07+00:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - a5993873 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42629: Add "about:tor" to `newTabUrls` instead of checking the scheme and path individually. - - - - - e8c4aad7 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42713: Use `--link-color` rather than `--in-content-link-color`. - - - - - f49b9909 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 41817: Use semantic tor color names in about:tor. - - - - - 5ee19a49 by Henry Wilkes at 2024-08-26T20:21:09+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 43081: Remove line-height. - - - - - b8cef53f by Arthur Edelstein at 2024-08-26T20:21:09+00:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - f4839094 by Pier Angelo Vendrame at 2024-08-26T20:21:09+00:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 23653323 by Kathy Brade at 2024-08-26T20:21:09+00:00 Bug 12647: Support symlinks in the updater. - - - - - 14ac8e5c by Kathy Brade at 2024-08-26T20:21:10+00:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - c6edee2a by Kathy Brade at 2024-08-26T20:21:10+00:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 50d01ac2 by Henry Wilkes at 2024-08-26T20:21:10+00:00 fixup! Bug 16940: After update, load local change notes. Bug 43081: Remove line-height for non-ASCII text. - - - - - c7b780e5 by Georg Koppen at 2024-08-26T20:21:11+00:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 6f3c0d2f by Mike Perry at 2024-08-26T20:21:11+00:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - d03e602c by Alex Catarineu at 2024-08-26T20:21:11+00:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - e0a23f5e by Henry Wilkes at 2024-08-26T20:21:12+00:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 04c504aa by Richard Pospesel at 2024-08-26T20:21:12+00:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 3752362f by Henry Wilkes at 2024-08-26T20:21:12+00:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 42212: Migrate onion service strings to Fluent. - - - - - 6a905f52 by Pier Angelo Vendrame at 2024-08-26T20:21:13+00:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 43013: Mixed content upgrades also .onion domains. - - - - - f99575d2 by Kathy Brade at 2024-08-26T20:21:13+00:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 18dd1ec8 by Pier Angelo Vendrame at 2024-08-26T20:21:13+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42596: Add preferences for log levels. - - - - - 5b678523 by Henry Wilkes at 2024-08-26T20:21:13+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42667: Add the "description-deemphasized" class to our preferences. Also use the "description-width-side-element" class. - - - - - 80a2bc55 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42212: Migrate onion service strings to Fluent. + Use "onion site" instead of "onionsite" or "onion service". + Use sentence case by default. + Changed the prompt accept button from "Done" to "OK", in line with other prompts. + Re-ordered the saved keys dialog introduction text from "Keys for the following onionsite are..." to "The following onion site keys are..." + Use bold text for the prompt title, rather than just the onion site part. + Clear the error message in the saved key dialog whenever the user tries to remove a key (again). + Other small tidies in the touched areas. - - - - - e3a7eca4 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 43067: Use html:link instead of xml-stylesheet - - - - - b60f24b2 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 41817: Drop browser-colors.css. - - - - - 5513f78a by Henry Wilkes at 2024-08-26T20:21:15+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 51b07b1b by Alex Catarineu at 2024-08-26T20:21:15+00:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 7eacca93 by Henry Wilkes at 2024-08-26T20:21:15+00:00 fixup! Bug 21952: Implement Onion-Location - - - - - 7f7ec613 by Pier Angelo Vendrame at 2024-08-26T20:21:16+00:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - d7261a87 by Pier Angelo Vendrame at 2024-08-26T20:21:16+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 42596: Add preferences for log levels. - - - - - 422f343f by Henry Wilkes at 2024-08-26T20:21:16+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 43081: Remove line-height for non-ASCII text. - - - - - c95b2209 by Pier Angelo Vendrame at 2024-08-26T20:21:17+00:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 6b192f0f by Pier Angelo Vendrame at 2024-08-26T20:21:17+00:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 88896d1a by Henry Wilkes at 2024-08-26T20:21:17+00:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - f5c5a085 by Dan Ballard at 2024-08-26T20:21:17+00:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 08782d65 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42643: Match margin for download warning separator. - - - - - 26a9fea9 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42641: Use moz-button-group for panel buttons. - - - - - 518c72a4 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42642: Focus the "Got it" button when opening the downloads panel. This should ensure that the alert is read aloud by Orca screen reader. - - - - - 4f1c6205 by Henry Wilkes at 2024-08-26T20:21:19+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 41820: Convert downloads warning to moz-message-bar. Move the logic to DownloadsTorWarning.sys.mjs so it remains in one place. - - - - - 8a1bc12c by Henry Wilkes at 2024-08-26T20:21:19+00:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 865514c9 by hackademix at 2024-08-26T20:21:19+00:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 8d7768b5 by Henry Wilkes at 2024-08-26T20:21:20+00:00 Customize moz-toggle for tor-browser. - - - - - 693c411b by Henry Wilkes at 2024-08-26T20:21:20+00:00 fixup! Customize moz-toggle for tor-browser. Bug 42612: Reimplement the moz-toggle customization for 128 ESR. - - - - - cc4660c4 by Richard Pospesel at 2024-08-26T20:21:20+00:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 0260feca by Cecylia Bocovich at 2024-08-26T20:21:20+00:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - d2e80371 by Matthew Finkel at 2024-08-26T20:21:21+00:00 Bug 40005: [android] Modify Default toolbar menu - - - - - b5a33a01 by Alex Catarineu at 2024-08-26T20:21:21+00:00 Bug 40007: [android] Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - fb91be63 by Alex Catarineu at 2024-08-26T20:21:21+00:00 Bug 40002: [android] Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 14719e4a by Alex Catarineu at 2024-08-26T20:21:22+00:00 Bug 40009: [android] Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - fd516bf7 by Dan Ballard at 2024-08-26T20:21:22+00:00 fixup! Bug 40009: [android] Change the default search engines Bug 43057: Fix js linting in search/list.json - - - - - d20bf1ad by clairehurst at 2024-08-26T20:21:22+00:00 fixup! Bug 40009: [android] Change the default search engines Bug 43037: Fix the crash when searching with DDG from the toolbar. - - - - - 9f27f380 by Alex Catarineu at 2024-08-26T20:21:22+00:00 [android] Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 70935ff7 by Georg Koppen at 2024-08-26T20:21:23+00:00 Bug 40013: [android] Add option do overwrite timestamp in extension version - - - - - afd3a253 by Alex Catarineu at 2024-08-26T20:21:23+00:00 Bug 40015: [android] Port padlock states for .onion services - - - - - c9a3aa89 by Matthew Finkel at 2024-08-26T20:21:23+00:00 [android] Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - 074f89ab by Matthew Finkel at 2024-08-26T20:21:24+00:00 Bug 40023: [android] Stop PrivateNotificationService - - - - - 8ab13dee by Matthew Finkel at 2024-08-26T20:21:24+00:00 [android] Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - a528694e by Matthew Finkel at 2024-08-26T20:21:24+00:00 [android] Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - 363ad1bd by Matthew Finkel at 2024-08-26T20:21:25+00:00 [android] Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - bc6658fb by clairehurst at 2024-08-26T20:21:25+00:00 fixup! [android] Rename as Tor Browser - - - - - 0b1cfd71 by Georg Koppen at 2024-08-26T20:21:25+00:00 [android] Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 451d0176 by Dan Ballard at 2024-08-26T20:21:26+00:00 fixup! [android] Modify build system remove newline - - - - - d98bd74a by Matthew Finkel at 2024-08-26T20:21:26+00:00 Bug 40185: [android] Use NimbusDisabled - - - - - 60e3d583 by Matthew Finkel at 2024-08-26T20:21:26+00:00 [android] Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - 6f88d76b by Dan Ballard at 2024-08-26T20:21:26+00:00 fixup! [android] Add Tor integration and UI remove unused java deps from TAS - - - - - c4ea568d by Morgan at 2024-08-26T20:21:27+00:00 fixup! [android] Add Tor integration and UI - - - - - 539267c3 by clairehurst at 2024-08-26T20:21:27+00:00 fixup! [android] Add Tor integration and UI - - - - - fbe657a0 by Alex Catarineu at 2024-08-26T20:21:27+00:00 [android] Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - dfe3110e by hackademix at 2024-08-26T20:21:28+00:00 [android] Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 553787a8 by Dan Ballard at 2024-08-26T20:21:28+00:00 [android] Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - a858d74f by Dan Ballard at 2024-08-26T20:21:28+00:00 Bug 41972: [android] Disable mozilla onboarding - - - - - 1a4df9a8 by Dan Ballard at 2024-08-26T20:21:29+00:00 Bug 41878: [android] Add standalone Tor Bootstrap - - - - - 946776bb by Dan Ballard at 2024-08-26T20:21:29+00:00 fixup! Bug 41878: [android] Add standalone Tor Bootstrap comment - - - - - 5802293c by clairehurst at 2024-08-26T20:21:29+00:00 Bug 42089: [android] Remove ability to submit site support requests - - - - - 603c78c4 by clairehurst at 2024-08-26T20:21:30+00:00 [android] fixup! Modify UI/UX and Remove ability to submit site support requests - - - - - fd0c209d by clairehurst at 2024-08-26T20:21:30+00:00 [android] Enable the connect assist experiments on alpha - - - - - a7afc1d7 by Dan Ballard at 2024-08-26T20:21:30+00:00 fixup! [android] Enable the connect assist experiments on alpha re private nav host - - - - - 6aeda309 by hackademix at 2024-08-26T20:21:31+00:00 Bug 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache. - - - - - 48bd69cd by clairehurst at 2024-08-26T20:21:31+00:00 [android] Delete unused media - - - - - 9b5de5cf by clairehurst at 2024-08-26T20:21:31+00:00 Bug 42195: [android] Fix "Whats new URL" - - - - - 114b5aab by clairehurst at 2024-08-26T20:21:32+00:00 [android] Implement Android-native Connection Assist UI - - - - - 81957030 by Morgan at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 58314e43 by clairehurst at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 5177b099 by clairehurst at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 6b24b104 by Pier Angelo Vendrame at 2024-08-26T20:21:33+00:00 Bug 42652: [android] Pass the list of supported languages to GeckoView. It will be used to prevent leaks about regional preferences. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/helpers.py - + .gitlab/ci/setup.yml - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - + README.md - − README.txt - + browser/actors/AboutTBUpdateChild.sys.mjs - + browser/actors/AboutTBUpdateParent.sys.mjs - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ee006e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ee006e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! [android] Add Tor integration and UI
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f5220902 by clairehurst at 2024-08-26T19:39:08+00:00 fixup! [android] Add Tor integration and UI - - - - - 1 changed file: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -166,7 +166,7 @@ class TorControllerGV( } set(value) { getTorSettings()?.let { - Log.i(TAG, "setUserProvidedBridges: '$value'"); + Log.i(TAG, "setUserProvidedBridges: '$value'") // Hack: we don't have validation so lets do something quick and dirty (each line has a length) val userProvidedLines: Array<String> = value?.split("\n")?.filter { it.length > 4 }?.toTypedArray() ?: arrayOf<String>() it.bridgesSource = BridgeSource.UserProvided @@ -353,7 +353,6 @@ class TorControllerGV( // TorEventsBootstrapStateChangeListener override fun onBootstrapError(code: String?, message: String?, phase: String?, reason: String?) { lastKnownError = TorError(code ?: "", message ?: "", phase ?: "", reason ?: "") - onBootstrapStateChange(TorConnectState.Error.state) } // TorEventsBootstrapStateChangeListener View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f522090… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f522090… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 3 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5c04abb6 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41811: Use tor colors for connect buttons in bridge dialogs. - - - - - 93ecfbc3 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41811: Only use tor outline color for tor-button elements. In particular, a `.primary:not(.tor-button)` element will have the default blue outline. - - - - - 8cfb49a3 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 41817: tor-browser semantic colors. Bug 41811: Use the tor color for .tor-button focus outlines. - - - - - 9 changed files: - browser/components/torpreferences/content/builtinBridgeDialog.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/requestBridgeDialog.js - browser/themes/shared/tor-urlbar-button.css - toolkit/components/torconnect/content/aboutTorConnect.css - toolkit/components/torconnect/content/aboutTorConnect.html - toolkit/components/torconnect/content/aboutTorConnect.js - toolkit/themes/shared/tor-colors.css Changes: ===================================== browser/components/torpreferences/content/builtinBridgeDialog.js ===================================== @@ -70,6 +70,13 @@ const gBuiltinBridgeDialog = { this._result.accepted = true; }); + // Add styling for tor-button to the dialog shadow root. + const styleLink = document.createElement("link"); + styleLink.rel = "stylesheet"; + styleLink.href = + "chrome://browser/content/torpreferences/torPreferences.css"; + dialog.shadowRoot.append(styleLink); + this._acceptButton = dialog.getButton("accept"); Services.obs.addObserver(this, TorConnectTopics.StateChange); @@ -95,6 +102,7 @@ const gBuiltinBridgeDialog = { "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-accept" ); + this._acceptButton.classList.toggle("tor-button", connect); }, observe(subject, topic) { ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -133,7 +133,7 @@ </menulist> <button id="torPreferences-bridges-buttonChooseBridgeForMe" - class="primary" + class="primary tor-button" /> </hbox> <html:moz-toggle ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -85,7 +85,7 @@ const gProvideBridgeDialog = { this._acceptButton = this._dialog.getButton("accept"); // Inject our stylesheet into the shadow root so that the accept button can - // take the spoof-button-disabled styling. + // take the spoof-button-disabled styling and tor-button styling. const styleLink = document.createElement("link"); styleLink.rel = "stylesheet"; styleLink.href = @@ -183,22 +183,21 @@ const gProvideBridgeDialog = { * Callback for whenever the accept button may need to change. */ onAcceptStateChange() { + let connect = false; if (this._page === "entry") { - document.l10n.setAttributes( - this._acceptButton, + this._acceptButton.setAttribute( + "data-l10n-id", "user-provide-bridge-dialog-next-button" ); - this._result.connect = false; } else { - this._acceptButton.removeAttribute("data-l10n-id"); - const connect = TorConnect.canBeginBootstrap; - this._result.connect = connect; - + connect = TorConnect.canBeginBootstrap; this._acceptButton.setAttribute( "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-accept" ); } + this._result.connect = connect; + this._acceptButton.classList.toggle("tor-button", connect); }, /** ===================================== browser/components/torpreferences/content/requestBridgeDialog.js ===================================== @@ -33,6 +33,13 @@ const gRequestBridgeDialog = { "torPreferences-requestBridge-dialog" ); + // Add styling for tor-button to the dialog shadow root. + const styleLink = document.createElement("link"); + styleLink.rel = "stylesheet"; + styleLink.href = + "chrome://browser/content/torpreferences/torPreferences.css"; + this._dialog.shadowRoot.append(styleLink); + // user may have opened a Request Bridge dialog in another tab, so update the // CAPTCHA image or close out the dialog if we have a bridge list this._dialog.addEventListener("focusin", () => { @@ -101,6 +108,7 @@ const gRequestBridgeDialog = { "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-submit" ); + this._submitButton.classList.toggle("tor-button", connect); }, observe(subject, topic) { ===================================== browser/themes/shared/tor-urlbar-button.css ===================================== @@ -26,7 +26,6 @@ * urlbar background, but we keep the rounded corners. */ outline: var(--focus-outline); outline-offset: var(--focus-outline-offset); - outline-color: var(--tor-focus-outline-color); /* Calculate the difference between the button's border area and the outline * area. */ --tor-urlbar-focus-outline-difference: calc( ===================================== toolkit/components/torconnect/content/aboutTorConnect.css ===================================== @@ -116,10 +116,6 @@ html { list-style-image: url("chrome://global/content/torconnect/bridge.svg"); } -button, select { - --in-content-focus-outline-color: var(--tor-focus-outline-color); -} - #locationDropdownLabel { margin-block: auto; margin-inline: 4px; ===================================== toolkit/components/torconnect/content/aboutTorConnect.html ===================================== @@ -75,8 +75,16 @@ <button id="restartButton" hidden="true"></button> <button id="configureButton" hidden="true"></button> <button id="cancelButton" hidden="true"></button> - <button id="connectButton" hidden="true"></button> - <button id="tryBridgeButton" hidden="true"></button> + <button + id="connectButton" + hidden="true" + class="tor-button" + ></button> + <button + id="tryBridgeButton" + hidden="true" + class="tor-button" + ></button> </span> </div> </div> ===================================== toolkit/components/torconnect/content/aboutTorConnect.js ===================================== @@ -190,7 +190,6 @@ class AboutTorConnect { show(element, primary = false) { element.classList.toggle("primary", primary); - element.classList.toggle("tor-button", primary); element.removeAttribute("hidden"); } ===================================== toolkit/themes/shared/tor-colors.css ===================================== @@ -1,3 +1,5 @@ +@namespace xul "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"; + :root { /* Photon colors not available in Firefox. */ --purple-30: #c069ff; @@ -126,19 +128,34 @@ /* Has a higher specificity than `button` and `button.primary`. */ button.tor-button:is(*, .primary), +xul|button.tor-button:is(*, [default]), .tor-button { color: var(--tor-button-text-color); background-color: var(--tor-button-background-color); } -button.tor-button:is(*, .primary):hover, -.tor-button:hover { +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):not([disabled]):hover { color: var(--tor-button-text-color-hover); background-color: var(--tor-button-background-color-hover); } -button.tor-button:is(*, .primary):hover:active, -.tor-button:hover:active { +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):not([disabled]):hover:active { color: var(--tor-button-text-color-active); background-color: var(--tor-button-background-color-active); } + +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):focus-visible { + outline-color: var(--tor-focus-outline-color); +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d9faa5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d9faa5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.2.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.15.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new branch tor-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_115_15_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_15_0esr_BUILD1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_15_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_15_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

tbb-commits August 2024